From nobody Tue Mar 31 09:55:06 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4flNlH0dBPz6WcCw for ; Tue, 31 Mar 2026 09:55:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4flNlG4X9gz3jr2 for ; Tue, 31 Mar 2026 09:55:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774950906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QZ2gHAb1e9h+82cRmfL39rs/0y6mGcTdINlR49YvGeQ=; b=OAF6+Rlk6JfyGMSL/YaXZAVEVhK7KbTcXi/jbKeBbS2rpGB9cmbmuYvOcU52cmJSq78ufc 6aVjHDTGT3CFisHoDSegwvWLZYPzRkjw/Kzlb/ew98NWAP25kT556RTsnTuTfeAqaoeTPD yfp2FtFAHOIfQBYlORBQ3f7myYUQpHnJA4I8PfgHD+PxEm0qs00sJ/pzZLlBCLDInmI3JP aPgCRkfEArL24NYrHPnZk5LXaJ9TyI7KTXUuPm0AZOWqgaX49fWO5wI054MZaojnamCJoB PPuiU6IBn4GULYPAIQQL39I2mrN+Xjh6xim7QK8fZTwNqJnyU7MmeW0JljGqZQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774950906; a=rsa-sha256; cv=none; b=LQJ0hxbq76PYF7dH95rBuEN65Oa8Zn+Epx8d++8+CPSu6ER5cIz2qjM9h0+RqVy1qApWuw bu2FZLs0gE97zrpOQOol4YchuRec9NjwVD9qQ0oxXwfpsmCAnfgbHmcBnBiWqOKddrAPmk 30cE4aqzPdDzHhn9aNkCUSl+M8YIwRVaHW+UrWvAkQXv48SpSBCe6rZFdzjD01dP7rui+0 WEaXKthNH3hZjKIAWYuT08drOu7Rh3ZQ3UsAKMto5n3zGx/1P3PawX0D4E8s3hiU1GNKB0 GbJ84J+xrqBhyaG0Uy0TrDk0TbEoU3xxxsgV5Uc4MyWY/4K6Fuls/CWD2Eogdg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774950906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QZ2gHAb1e9h+82cRmfL39rs/0y6mGcTdINlR49YvGeQ=; b=q2AJi52J26TRPfFH34SkdIT6Vm2qOpipBK42zfeFwwQ7g4+vGMzNdcRkmW2bgibAs03lX3 N5uM7QNe7+Fs8dIQw2ukrPdZU1GvDMG+FcRoTgKr7anEEjuzuW//kbmUmBLy68Tw5A9vzY m6vw9Th7XGB63q7Yr0oYRP/qG3+iiZqx8adJEAl3mpDRvXtPREKZwf9V0W3fJVs/jQIgdy HsGYZqhTuOIhnK0BH7MHO71OKFEO1y6FVuXywBLsDbaTjPv8LMzgCnJtlVYPB0OH4JOMri 2XnVV+PY7I4rZPbe8jdM6f+LeTpA4Ytye4/ScAR+GsH3qFznA2Uobm+fY9kdNw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4flNlG44Y2z8TX for ; Tue, 31 Mar 2026 09:55:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 39a75 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 31 Mar 2026 09:55:06 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Christos Margiolis Subject: git: 7c483aa01363 - stable/15 - sound: Do not create root feeder in chn_init() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 7c483aa01363901498a495d95e303d605cca5e53 Auto-Submitted: auto-generated Date: Tue, 31 Mar 2026 09:55:06 +0000 Message-Id: <69cb99fa.39a75.26d0836a@gitrepo.freebsd.org> The branch stable/15 has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=7c483aa01363901498a495d95e303d605cca5e53 commit 7c483aa01363901498a495d95e303d605cca5e53 Author: Christos Margiolis AuthorDate: 2026-03-24 10:31:43 +0000 Commit: Christos Margiolis CommitDate: 2026-03-31 09:53:16 +0000 sound: Do not create root feeder in chn_init() The feeder chain gets destroyed when feeder_chain() is called, which is after the chn_reset() call in chn_init() further down for primary chans, or vchan_create() for vchans. This makes the root feeder creation in chn_init() essentially a no-op. Remove it altogether and let feeder_chain() after chn_reset() take care of creating the feeder properly. It creates the root one as well. Sponsored by: The FreeBSD Foundation MFC after: 1 week Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D55941 (cherry picked from commit b9f9fc473eb56273978df4d4c889acba2862b21c) --- sys/dev/sound/pcm/channel.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/sys/dev/sound/pcm/channel.c b/sys/dev/sound/pcm/channel.c index b74f76fd21ca..5e7c5772af01 100644 --- a/sys/dev/sound/pcm/channel.c +++ b/sys/dev/sound/pcm/channel.c @@ -1144,7 +1144,6 @@ chn_init(struct snddev_info *d, struct pcm_channel *parent, kobj_class_t cls, int dir, void *devinfo) { struct pcm_channel *c; - struct feeder_class *fc; struct snd_dbuf *b, *bs; char buf[CHN_NAMELEN]; int err, i, direction, *vchanrate, *vchanformat; @@ -1217,17 +1216,6 @@ chn_init(struct snddev_info *d, struct pcm_channel *parent, kobj_class_t cls, chn_vpc_reset(c, SND_VOL_C_PCM, 1); CHN_UNLOCK(c); - fc = feeder_getclass(FEEDER_ROOT); - if (fc == NULL) { - device_printf(d->dev, "%s(): failed to get feeder class\n", - __func__); - goto fail; - } - if (feeder_add(c, fc, NULL)) { - device_printf(d->dev, "%s(): failed to add feeder\n", __func__); - goto fail; - } - b = sndbuf_create(c, "primary"); bs = sndbuf_create(c, "secondary"); if (b == NULL || bs == NULL) {