From nobody Mon Jun 29 19:26:01 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gpx8T5WjRz6jjLj for ; Mon, 29 Jun 2026 19:26:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gpx8T1cb8z40jQ for ; Mon, 29 Jun 2026 19:26:01 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782761161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5Z6CmqvdSHgk1sShyC7GVQMcDsZ3fSX/JLoQOu2dBUY=; b=akm+gHPvcSrjs4MdZIsWk3BbOXfu3ZtZiYWtivRw/64UbWo/53vDwhirjVUGQlsUdbpoFD apDvd7Wnydtq6Xj6sYteAc5OBSq/NrYE4RRNUmjnMEeV6+4jfjO7eNjdJRnpIkua9hYdPf se/NEtW4xc0sRjYVaJbLR96keNX+Qpl5Z5iDFhjab2U6fHgYIPLQzLnnTDVAqKJr5UyqY2 Yvnb0ZivGbZKV9PN9AQGg+s6wtc5ntLdN76TVg/0ilplA0+IqMAVXuXtkrm4VyA/kZ1DSL S96h3JpKWLvNd9B0FW5ZCnAaS2OPE7br6FuZOkEO5nC+pOrsALMNvpbYDgewbQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782761161; a=rsa-sha256; cv=none; b=txTcbu9KzOjdGUObqdl246dBFuEZfiYW2cDMiC2vcRUDrDRZaTs2ohMUtAMlzJ9rHtCNCr LwZe5YO7a6UNGRZ09JLK9bU3HctAlvdlnJReRrNv9lVP5D2TuOsaLOqS3j1O/SnWB6Bjp9 0AG3qR7eJxIqUTaOg+gtaRAH3GKfQNTDTTmiyL3ECr4WKzfEo8xd40LNXiRZvq7tDXjyg2 JJtW+crNcjncaqUVWV9105dXrqrJdKAU5a0rPH9yaBPKhdrl2P9kAdQLQ5ZGsDAySgh8aV ptE11Hn0nRx28Wk7WvcoLXJAjEWoEC6nEQ5UWeQLYpG+oa7v0O0T0pKtH2JWDQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782761161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5Z6CmqvdSHgk1sShyC7GVQMcDsZ3fSX/JLoQOu2dBUY=; b=d+4d68Ad2x44/bcPTWwlClz/zTForEIDkrF9XJfvWLqYO582QY/FjWMfeABuSsUfCKdUz+ VlovoJrCa4XXLftaU0myx9IYg9f+tlmKRH28iqcCVAKU5xbT7kW15N7AK9A0WxrB/SqSTS e0wdo5UNKI7KPEwtcn+QbzLhU0QLKgvflOy8AgUNIc010EUorKV9RyVmk3MkPCoZI7/X2N ow705eNVSrKrY66oDCGdpfDltqfsZ3AV8Zx48IEaurKNzM/UHO2YewNi1pclcqtshJWQPk M8eifnxWmlKdWy/G99SdBK5iCRZw61oqnaxnxwJwU+Lujiyvx9y4txGf0rkmrw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gpx8T0c3Cz19fp for ; Mon, 29 Jun 2026 19:26:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 21e88 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 29 Jun 2026 19:26:01 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: a6398c245128 - stable/15 - MAC/do: Comment to explain the main invariant for configurations List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: a6398c245128cbc5a2b9a98971ea09ef03bb6234 Auto-Submitted: auto-generated Date: Mon, 29 Jun 2026 19:26:01 +0000 Message-Id: <6a42c6c9.21e88.10e774c6@gitrepo.freebsd.org> The branch stable/15 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=a6398c245128cbc5a2b9a98971ea09ef03bb6234 commit a6398c245128cbc5a2b9a98971ea09ef03bb6234 Author: Olivier Certner AuthorDate: 2026-04-29 17:11:34 +0000 Commit: Olivier Certner CommitDate: 2026-06-29 19:23:53 +0000 MAC/do: Comment to explain the main invariant for configurations Once visible, configuration structures must *never* change. Spell that out in a comment to help future readers/contributors understand the design. Reviewed by: bapt MFC after: 1 month Sponsored by: The FreeBSD Foundation Pull Request: https://ron-dev.freebsd.org/FreeBSD/src/pulls/38 (cherry picked from commit 5bedb5e44757ba83dba9d618f5b951416cf44345) --- sys/security/mac_do/mac_do.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sys/security/mac_do/mac_do.c b/sys/security/mac_do/mac_do.c index 4ba545ec5a19..a175b92c764d 100644 --- a/sys/security/mac_do/mac_do.c +++ b/sys/security/mac_do/mac_do.c @@ -212,6 +212,11 @@ struct exec_paths { int exec_path_count; }; +/* + * Once in use, i.e., being pointed to by a jail, a configuration structure MUST + * NEVER CHANGE (except for the 'use_count' field). This invariant is + * fundamental to correctness! + */ struct conf { struct rules rules; struct exec_paths exec_paths;