From nobody Sun Jun 28 18:40:33 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gpJBV5T8Dz6jkRC for ; Sun, 28 Jun 2026 18:40:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gpJBT6Sn0z3YCn for ; Sun, 28 Jun 2026 18:40:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782672033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=O13VnYFdgW3ziPvPCzs5mk0OQI9WIIfDs7idv1GfILg=; b=yOrvOhyUeIBBKSDAu5ppNXK//T7cFQUbWRpYHaSHjWwldhV6m1gL8s3gGlRPA15cT3YJqk t804a5j7Yq4kFSFktXXJPIBGlW/S8ukZMENwY/gOmCboY7/0tMBv5J1GzCDoH+H7rtZFoR 3YvLWoDFfJsyE/N3gNCk6IYf07BBQb5QllBjySG8erkLKt4PjuoK9fBVoj6eIqrz4FuC/v iqE4m7DnUw1KAfKqJ+kd3JCDzv3KXE3GsfYo6OJnoLZCc9Dq6/scrAsxvw1aqzJO9+Z1xY qix+Qq1rWwox1yMzfLlOeD5HzEotDhyWpnMlGb0K8UySv4v8ooxiVTqLq3/Vng== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782672033; a=rsa-sha256; cv=none; b=muwNmpE0kGz0fkGEWd06ELhQlGyXaUeO4b4ojae6RLpCMam4dt8BDhkrlOBYfmY1PyIPAD SJtdqNde657a77p5clHDU2fAvoO4MEOQoniUxavklu4mYRvFhPK0guRaa9KqN8Y54vakdQ Voqjz9xGrNSRaLWfH0Vd/2aaNDYd74Vzr07Dq4d/pR3pxSiqiSFVy7vH3mHLlylS6hA9tc b9iGp/gh+re6yl4l+warhqlwMwJ03ke1rTSoAiXb2lmFd+JTcq6gPz97Ce5Pz89xh1aE5c qby74N9/3YLOBhoeyXE2Cf3DEG84QmHia+/f3IFWwB6UMgBv6VUyZPzM3ueNPQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782672033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=O13VnYFdgW3ziPvPCzs5mk0OQI9WIIfDs7idv1GfILg=; b=WsPHiyxWxGY7hAdPMOm9lVfjD8q9qhqOAQRPcnMuNAJHY7UwBGv1LqUd1E7wnB9efgXPMT BNBDno9FfyX1ZODi674GA/7rFaaVstXkp43Z+QDT88WdMYkovHem2uli8IitwCNajRJu3L UsioWLBmEqTdGjSX55v3LS6c4HaGdSPGL+4m9ixvYc7GfxNjXBVLxbmOGYFpqLeHKUAEGd 7xAs3lCCha6dMCKDDWKS8BGc2dNKNe3lP6FzK2frLhqKdc4CItBCX/6qlKV01BloW5NP0e 3v282Vrklcuf+bTs4mUUgBAYGvKDZITwJsCd3+CizhJKhN+2Fgpv7eCZYo1UQQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gpJBT50XQz6nh for ; Sun, 28 Jun 2026 18:40:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1c43b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 28 Jun 2026 18:40:33 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Baptiste Daroussin Subject: git: 3973c36d1f86 - stable/15 - pw: fix uninitialized name pointer in pw_group_del List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bapt X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 3973c36d1f86653bd65025ddbd4f05f3ef4b5b1f Auto-Submitted: auto-generated Date: Sun, 28 Jun 2026 18:40:33 +0000 Message-Id: <6a416aa1.1c43b.2dc7dc7a@gitrepo.freebsd.org> The branch stable/15 has been updated by bapt: URL: https://cgit.FreeBSD.org/src/commit/?id=3973c36d1f86653bd65025ddbd4f05f3ef4b5b1f commit 3973c36d1f86653bd65025ddbd4f05f3ef4b5b1f Author: Baptiste Daroussin AuthorDate: 2026-06-04 22:12:24 +0000 Commit: Baptiste Daroussin CommitDate: 2026-06-28 18:32:26 +0000 pw: fix uninitialized name pointer in pw_group_del The 'name' variable could be left uninitialized if neither the positional argument nor -n is supplied, leading to undefined behavior when passed to getgroup(). (cherry picked from commit 13f4a37b536b60d559c766b3ec4f2d5d25279ea3) --- usr.sbin/pw/pw_group.c | 2 +- usr.sbin/pw/tests/pw_groupdel_test.sh | 16 +++++++++++++++- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/usr.sbin/pw/pw_group.c b/usr.sbin/pw/pw_group.c index 1941c03aa2c5..2840e972af59 100644 --- a/usr.sbin/pw/pw_group.c +++ b/usr.sbin/pw/pw_group.c @@ -367,7 +367,7 @@ pw_group_del(int argc, char **argv, char *arg1) { struct userconf *cnf = NULL; struct group *grp = NULL; - char *name; + char *name = NULL; const char *cfg = NULL; intmax_t id = -1; int ch, rc; diff --git a/usr.sbin/pw/tests/pw_groupdel_test.sh b/usr.sbin/pw/tests/pw_groupdel_test.sh index fa51b3814205..0fb5651944f3 100755 --- a/usr.sbin/pw/tests/pw_groupdel_test.sh +++ b/usr.sbin/pw/tests/pw_groupdel_test.sh @@ -18,6 +18,20 @@ group_do_not_delete_wheel_if_group_unknown_body() { } +atf_test_case group_delete_by_gid cleanup +group_delete_by_gid_head() { + atf_set "descr" "Test deleting a group by gid without providing a name" +} +group_delete_by_gid_body() { + populate_etc_skel + ${PW} groupadd testgroup -g 1000 || atf_fail "Creating test group" + atf_check -s exit:0 -o inline:"testgroup:*:1000:\n" \ + -x ${PW} groupshow 1000 + ${PW} groupdel -g 1000 || atf_fail "Deleting group by gid" +} + + atf_init_test_cases() { - atf_add_test_case group_do_not_delete_wheel_if_group_unknown + atf_add_test_case group_do_not_delete_wheel_if_group_unknown + atf_add_test_case group_delete_by_gid }