From nobody Wed Jun 10 04:01:03 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gZsWz4xC4z6gv7v for ; Wed, 10 Jun 2026 04:01:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gZsWz2jmMz3w9G for ; Wed, 10 Jun 2026 04:01:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781064063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gAEv4KKZUJZx8310mrYJoSbE50VCJwaICxfHMlpZk6M=; b=DDGHY1PyZN6r5YwKmILDbUZdY/ipgPIr8EgChau/YvMzDCUiWkC7Lqj2pK1KwMLLp3ZUdw E6uayzhD736MPoXPaGi0JJHY0tTO5uZL0mwkSicYCqThKPy87U64FO8G3sCawTZGDjCYgq B+8TjBKCHmD2HAzCJYQ0TjrA/l0MPagLNjg6aXXM4sf/SGTe20DWjXIE1PJcdm3EiQhyAn ZFu5CreCDKTp1gfeGvm09SKrjDRwaYPkCjGYUz3cuckgO4ZgSEGHFtxpqvWtRsTr3iZFW9 heNmpF6njwFwYpKN4dOM+J5tzzcirNFD+kmd83ECYOWpUuyrTfbM0uQAXYMHCA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1781064063; a=rsa-sha256; cv=none; b=Z/b7AYHPKP1Rti0AidM5YvXlGFWkjk+ZrwEbNeCQEvlvYwe5lG7yyI3+oP7kpLjwm0A9ef 2E9vO8hcvouc3f6dc5Q8Xy4AB/Vo2r9ycUs/DzGUu+E3fD6FWP6MXIDIVAoTENZIc/FrhK yPK0ZrXSqSBxV5sjfjl+I+F04brmveKIpU9qXoIO9NSRdcpc+z+FrnLz5u8ryHImy8WlwM gkmDQq4aF2Blq1rU41qu1eo1e+QH0ivUoXQN0zc3ye5TMHJmNAZW7E97W/TdAkcISJhfcM +SbmzeWaRapjpuTLzq+rpGYCD/H5HaOLq0HhMeNhQJvANDBiCRli0DPmUGClbA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781064063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gAEv4KKZUJZx8310mrYJoSbE50VCJwaICxfHMlpZk6M=; b=rVdUuukpMMyffzCtWfaKum8a9nu9ytzZItywcj0PR/z0F+JF2KZcY5v+rIrm1tk8lQrrsp Wa82RIC+Pf0MDuVBgrhH+S5tmNfaDnUIp6Yt5oIJKl9omiTDK/E904t83mL0cIklzEmWFU 6lJOFuJyH8zDBlM7eYEhn1VGF3QL9orFOAPOmRVO6kQd15VB7HievOB5EcC7niPK0EZCpW qRnRMtNN24oJejxwr3HMV7TyjVPlD0BJsb5VKum2U1zKBHyCIzxEJ+qlItUQZEck0tHlrL iiXcJASH9dby4THfFIpcODBbbgDv81YFojHEL43CwHYXlv70okuELbzZ0qWYYA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gZsWz2DZGz14BL for ; Wed, 10 Jun 2026 04:01:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 26660 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 10 Jun 2026 04:01:03 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Chris Longros From: Kyle Evans Subject: git: 10b44bf791c9 - stable/14 - cron: log when a crontab path is too long List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 10b44bf791c9bb77dd2a9a2d9c510e671cefec50 Auto-Submitted: auto-generated Date: Wed, 10 Jun 2026 04:01:03 +0000 Message-Id: <6a28e17f.26660.3b74d926@gitrepo.freebsd.org> The branch stable/14 has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=10b44bf791c9bb77dd2a9a2d9c510e671cefec50 commit 10b44bf791c9bb77dd2a9a2d9c510e671cefec50 Author: Chris Longros AuthorDate: 2026-04-29 04:06:29 +0000 Commit: Kyle Evans CommitDate: 2026-06-10 04:00:46 +0000 cron: log when a crontab path is too long Log via syslog when snprintf truncates the crontab path, instead of silently skipping the entry. Signed-off-by: Christos Longros Reviewed by: bcr, kevans (cherry picked from commit 91bfba010bcda665cc24a76af631cc85fcb0c688) --- usr.sbin/cron/cron/cron.8 | 11 +++++++++-- usr.sbin/cron/cron/database.c | 6 ++++-- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/usr.sbin/cron/cron/cron.8 b/usr.sbin/cron/cron/cron.8 index 23a295393df5..f1a6a30d4cb5 100644 --- a/usr.sbin/cron/cron/cron.8 +++ b/usr.sbin/cron/cron/cron.8 @@ -19,7 +19,7 @@ .\" .\" $Id: cron.8,v 1.2 1998/08/14 00:32:36 vixie Exp $ .\" -.Dd January 20, 2026 +.Dd April 29, 2026 .Dt CRON 8 .Os .Sh NAME @@ -227,7 +227,14 @@ configuration file for .It Pa /usr/local/etc/cron.d Directory for third-party package provided crontab files. .It Pa /var/cron/tabs -Directory for personal crontab files +Directory for personal crontab files. +Internally the daemon constructs the relative path +.Pa tabs/ Ns Ar filename , +which must fit within +.Dv MAXNAMLEN +bytes; in practice this allows filenames up to 250 bytes. +Longer entries are skipped and a diagnostic is logged via +.Xr syslog 3 . .El .Sh SEE ALSO .Xr crontab 1 , diff --git a/usr.sbin/cron/cron/database.c b/usr.sbin/cron/cron/database.c index 35e5fad3524d..234b5ef7fdd6 100644 --- a/usr.sbin/cron/cron/database.c +++ b/usr.sbin/cron/cron/database.c @@ -166,8 +166,10 @@ load_database(cron_db *old_db) fname[sizeof(fname)-1] = '\0'; if (snprintf(tabname, sizeof tabname, CRON_TAB(fname)) - >= sizeof(tabname)) - continue; /* XXX log? */ + >= (int)sizeof(tabname)) { + log_it("CRON", getpid(), "TABNAME TOO LONG", fname); + continue; + } process_crontab(fname, fname, tabname, &statbuf, &new_db, old_db);