git: 28833ade34e4 - stable/14 - netlink: Fix lock leak in nl_find_nhop
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 05 Jun 2026 19:38:10 UTC
The branch stable/14 has been updated by emaste:
URL: https://cgit.FreeBSD.org/src/commit/?id=28833ade34e4eabbbbf985217e552ac589fb9329
commit 28833ade34e4eabbbbf985217e552ac589fb9329
Author: Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2026-05-21 21:14:41 +0000
Commit: Ed Maste <emaste@FreeBSD.org>
CommitDate: 2026-06-05 19:37:58 +0000
netlink: Fix lock leak in nl_find_nhop
Reviewed by: bz, pouria
Fixes: 7e5bf68495cc ("netlink: add netlink support")
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D57156
(cherry picked from commit d66fec481bfd65cbabb6c12a410d76843e76083e)
(cherry picked from commit ab599e44dba31d7b002aed8c71242e06d992b21a)
---
sys/netlink/route/nexthop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sys/netlink/route/nexthop.c b/sys/netlink/route/nexthop.c
index 0d6bb5c9ec84..e7f08f2f8f3a 100644
--- a/sys/netlink/route/nexthop.c
+++ b/sys/netlink/route/nexthop.c
@@ -174,7 +174,7 @@ nl_find_nhop(uint32_t fibnum, int family, uint32_t uidx,
CHT_SLIST_FIND_BYOBJ(&ctl->un_head, unhop, &key, unhop);
if (unhop != NULL) {
struct nhop_object *nh = unhop->un_nhop;
- UN_RLOCK(ctl);
+ UN_RUNLOCK(ctl);
*perror = 0;
nhop_ref_any(nh);
return (nh);