From nobody Thu Feb 19 12:29:35 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fGt3z5TRWz6QRT0 for ; Thu, 19 Feb 2026 12:29:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fGt3z2BBmz3TKZ for ; Thu, 19 Feb 2026 12:29:35 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771504175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0vTrk3mqiAynG828UsaOdEatVdSB7f8iy01Ijl1Iwgw=; b=xdNAljMfLqb8objXvExb9o+5Nz+JwhRrJgnWSwFwV+/eVXOC+K4gmOSgW72pWm2Np/fqdj H17FH6xiB9NoQb0QjLVaA3KMIxPMlkcbx7g0f23NtKwC/dztMcaU5Sr9PyWHswcFxGLUmm ZWCO1QcAa2nkdQcD4j9+r0Z6If+8WWTz/bakSnmcKDTTAGtVdv4AiCE1qLgdQQSGWlMGFW 0HkbUERpHHeBuxJSgCIyyOg6hH5IM0JFZN71xuWHdpKRWla1IUMCWXr2fvcMmcXzSCovVy mj9o8KWy+Fw9OQyhOPbE5QfAlk2fgnBBenwm1vBbmr1Z4F/aRIVhtrCyQ8qg3Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771504175; a=rsa-sha256; cv=none; b=p0UbPDqAs4aKOgd+c18d8nWW0W+3RCCrNTBR8DpmGC7sDIO7NoVQONd9VRQd/4GkJfyN0x adg225hcoV/V9TwfoMNmJ9K726ud5iXzinOErfwUSOhrcZ7KhzQgajfJrqPgFpS6Jc1ZUV kYjT+XDFzlFm4LfZalT5RQqXTMolsozJzxIh2ry1xbBrAC9RPAa/bUJ3jkaECjh9IsAI5u crYN+nsDTs71qyrRXcYDKy+cymq+H5pmfgSfXZUdH8hITXcWpZSzrdp/GpaDrpptcQ466q AAZsC/y5MmBEZQG9wqbHUUOHZasa8Vi7T8a20u2GoSSDHZhjGY65y4b1yBhsbw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771504175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0vTrk3mqiAynG828UsaOdEatVdSB7f8iy01Ijl1Iwgw=; b=YNF0edh9bxUHzjoxDxbPwqnYnQGezpyHi1ZNYWcMg2svCTUipMsq4+9b68BT6eGwzw6dyf XLVmi0HoZmo2dGB3a7JC3/nniW1bZbAglVqzUhSnWiDhitVCddxCEGQeoNh6xt2wgyIGvb IZBSK0nfTtVoF/D52DGQbeJIAFB8SuNq15Io4+kQVeMr2irTyALsaNdVUO03LSarXzH8Nl OOcZAKMqWlLR2Aj+DQCHI6R7vV820pUeovS0WrXMrNCDSvh7Q3L/GdhEKnShzwqER9bTNj Q6v0pRddzSsTYbn4MQzlyZIIkwcpv4hKg8avtvFdIySTW2djfOOQ+irYG43U4A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fGt3z1NzMzjW7 for ; Thu, 19 Feb 2026 12:29:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 399be by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 19 Feb 2026 12:29:35 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: 27b76413615a - stable/15 - sysctl(9): Booleans: Fix old value length discovery List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 27b76413615a298d4aa2ae71bd98fbe116116db2 Auto-Submitted: auto-generated Date: Thu, 19 Feb 2026 12:29:35 +0000 Message-Id: <6997022f.399be.36dd29c5@gitrepo.freebsd.org> The branch stable/15 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=27b76413615a298d4aa2ae71bd98fbe116116db2 commit 27b76413615a298d4aa2ae71bd98fbe116116db2 Author: Olivier Certner AuthorDate: 2026-02-03 22:25:46 +0000 Commit: Olivier Certner CommitDate: 2026-02-19 12:28:52 +0000 sysctl(9): Booleans: Fix old value length discovery When calling sysctl(3) with a null 'oldp', i.e., length discovery mode, 'oldix' can be equal to 'oldlen', and we should not fail. More generally, let SYSCTL_OUT() and SYSCTL_IN() handle corner cases, simply removing the comparisons between 'oldidx' and 'oldlen' and 'newidx' and 'newlen' done by hand as the test just after is an equality that does not require to know if 'idx' is smaller than 'len'. PR: 292917 Reported by: cy Fixes: 406da392ef8d ("sysctl(9): Booleans: Accept integers to ease knob conversion") Sponsored by: The FreeBSD Foundation (cherry picked from commit 895e1c6567d9561c86f8d20b47e924911bce989e) --- sys/kern/kern_sysctl.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sys/kern/kern_sysctl.c b/sys/kern/kern_sysctl.c index dbe509b3e8e2..be0acb0a4a55 100644 --- a/sys/kern/kern_sysctl.c +++ b/sys/kern/kern_sysctl.c @@ -1637,8 +1637,6 @@ sysctl_handle_bool(SYSCTL_HANDLER_ARGS) * the output buffer, we assume that the caller expected an 'int' * instead of a 'uint8_t'. */ - if (req->oldidx >= req->oldlen) - return (ENOMEM); if (req->oldlen - req->oldidx == sizeof(int)) { int temp_int = temp; @@ -1655,8 +1653,6 @@ sysctl_handle_bool(SYSCTL_HANDLER_ARGS) * Conversely, if the input buffer has exactly 4 bytes to read, * use them all to produce a bool. */ - if (req->newidx >= req->newlen) - return (ENOMEM); if (req->newlen - req->newidx == sizeof(int)) { int temp_int;