From nobody Mon Feb 16 19:47:35 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fFCwm2L6Sz6SFyv for ; Mon, 16 Feb 2026 19:47:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fFCwl534Fz3pMH for ; Mon, 16 Feb 2026 19:47:35 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771271255; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aGLjdmEVVIAWLVQZyJwvyR8b5XCWYi3vr7HzGsLAfyw=; b=eTc15A3PdMLVUUUAJMtd6gPetkhl/Dijq94A7xO/rG1UCDkaDrCb8ws6O3BJOtGym7VVCH ItbjY4/0VzlSbdr0waBxbapdCaHE6L64ss3UdZi34aNr4n4Bfv22K4+r3X/h/KLm7sL1h/ T/58Hg+ZqvQqqwSEl+P+dUGPK1s3rW7PCLXvOQV96dqfIa8ZC5ce+x+s12g5+sn/CI2kgF fK/gKanVZ50aiyk7Hjq6reBJUix+//H1EezkTrTfWwnI+c2h+1yLO0Ud7XKrVpJXcpI7kJ XEGF/Uv1E/2WOUSyLFCtWrJgrb5gJY0vSLmsLGwmmbHhiy7OqV0WGMp6RrZWcg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771271255; a=rsa-sha256; cv=none; b=aXbrmouxhoKrYqDZ9ChGrG54fRwWO+UcO7UgntkJkr/1dzXmVEmiqLsloadQ5fdDvLgZPX xlclAdBrwUFXw36mg/r6m9tWzKiDutKY5sBDJrbTqhqLlbSeBnOmJp46H01OFJcJK/OuSY 3T+49toEGJYGXcSriZgeX1Mm2bItO/zW3N9pvVXHd0z7kopRk1JpnljlROgQylSBuTQRvF dMpYGY2ugseNFCShzsULwZZk6H9ddb88RSNgau551/INRVIY6JJjRHIrBI6NnXdDjdhhE0 AxttBRa/Mij0u7WU6mH+mctu4MaXha+n6deQhTXdhzn63o7q+7Nu1WeVARXE+Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771271255; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aGLjdmEVVIAWLVQZyJwvyR8b5XCWYi3vr7HzGsLAfyw=; b=Au4d1Qmw8kstz28BToJpAHaNddrnnaAwCeSa2tELsxtwjDiigvz2BvueCk3cw/e5C+zF10 Fuz3IxPso7JEH8c7sBUFvlh15LGTzIAQFiBe4AxPqih3IKYTuGjX9GTRsnBWTYEcW3qntq UwOKyE6fLHrMQziOqZkkm8amB0jTUZPFcdxplCG+RzchGBsaM4QGiqlfkxa5qktt8wGCqF JOrjDqGo/FMG8LPZNXlmXEHQsNIaQOkhCLJrNMG/Oy21LZn5yNy6F9heqltIp8sfDzh9Pf F6iT/HdwEMCcrOD966H4g9dwoLAfjn65fBDaOAcMLBI0vCwg9MXnOwlO0Riviw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fFCwl4Gnhzdvr for ; Mon, 16 Feb 2026 19:47:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3fde9 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 16 Feb 2026 19:47:35 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 20f81dcba998 - stable/14 - ip6_mroute: Make MF6CFIND a regular function List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 20f81dcba99874bef290745e39abb53f94a8474f Auto-Submitted: auto-generated Date: Mon, 16 Feb 2026 19:47:35 +0000 Message-Id: <69937457.3fde9.c16fbe5@gitrepo.freebsd.org> The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=20f81dcba99874bef290745e39abb53f94a8474f commit 20f81dcba99874bef290745e39abb53f94a8474f Author: Mark Johnston AuthorDate: 2026-02-02 14:57:20 +0000 Commit: Mark Johnston CommitDate: 2026-02-16 16:09:28 +0000 ip6_mroute: Make MF6CFIND a regular function This is more natural and corresponds more closely to the v4 multicast routing code. No functional change intended. Reviewed by: glebius MFC after: 2 weeks Sponsored by: Stormshield Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D54983 (cherry picked from commit b370fcc716b9cfd4d08e291f0009f02452c84d64) --- sys/netinet6/ip6_mroute.c | 45 ++++++++++++++++++++------------------------- 1 file changed, 20 insertions(+), 25 deletions(-) diff --git a/sys/netinet6/ip6_mroute.c b/sys/netinet6/ip6_mroute.c index 76e20b110d72..86b65fbbd047 100644 --- a/sys/netinet6/ip6_mroute.c +++ b/sys/netinet6/ip6_mroute.c @@ -297,26 +297,6 @@ VNET_DEFINE_STATIC(int, pim6); (g).s6_addr32[0] ^ (g).s6_addr32[1] ^ \ (g).s6_addr32[2] ^ (g).s6_addr32[3]) -/* - * Find a route for a given origin IPv6 address and Multicast group address. - */ -#define MF6CFIND(o, g, rt) do { \ - struct mf6c *_rt = mf6ctable[MF6CHASH(o,g)]; \ - rt = NULL; \ - while (_rt) { \ - if (IN6_ARE_ADDR_EQUAL(&_rt->mf6c_origin.sin6_addr, &(o)) && \ - IN6_ARE_ADDR_EQUAL(&_rt->mf6c_mcastgrp.sin6_addr, &(g)) && \ - (_rt->mf6c_stall == NULL)) { \ - rt = _rt; \ - break; \ - } \ - _rt = _rt->mf6c_next; \ - } \ - if (rt == NULL) { \ - MRT6STAT_INC(mrt6s_mfc_misses); \ - } \ -} while (/*CONSTCOND*/ 0) - /* * Macros to compute elapsed time efficiently * Borrowed from Van Jacobson's scheduling code @@ -367,6 +347,22 @@ static int X_ip6_mrouter_set(struct socket *, struct sockopt *); static int X_ip6_mrouter_get(struct socket *, struct sockopt *); static int X_mrt6_ioctl(u_long, caddr_t); +static struct mf6c * +mf6c_find(const struct in6_addr *origin, const struct in6_addr *group) +{ + MFC6_LOCK_ASSERT(); + + for (struct mf6c *rt = mf6ctable[MF6CHASH(*origin, *group)]; rt != NULL; + rt = rt->mf6c_next) { + if (IN6_ARE_ADDR_EQUAL(&rt->mf6c_origin.sin6_addr, origin) && + IN6_ARE_ADDR_EQUAL(&rt->mf6c_mcastgrp.sin6_addr, group) && + rt->mf6c_stall == NULL) + return (rt); + } + MRT6STAT_INC(mrt6s_mfc_misses); + return (NULL); +} + /* * Handle MRT setsockopt commands to modify the multicast routing tables. */ @@ -495,7 +491,7 @@ get_sg_cnt(struct sioc_sg_req6 *req) MFC6_LOCK(); - MF6CFIND(req->src.sin6_addr, req->grp.sin6_addr, rt); + rt = mf6c_find(&req->src.sin6_addr, &req->grp.sin6_addr); if (rt == NULL) { ret = ESRCH; } else { @@ -818,9 +814,8 @@ add_m6fc(struct mf6cctl *mfccp) MFC6_LOCK(); - MF6CFIND(mfccp->mf6cc_origin.sin6_addr, - mfccp->mf6cc_mcastgrp.sin6_addr, rt); - + rt = mf6c_find(&mfccp->mf6cc_origin.sin6_addr, + &mfccp->mf6cc_mcastgrp.sin6_addr); /* If an entry already exists, just update the fields */ if (rt) { MRT6_DLOG(DEBUG_MFC, "no upcall o %s g %s p %x", @@ -1115,7 +1110,7 @@ X_ip6_mforward(struct ip6_hdr *ip6, struct ifnet *ifp, struct mbuf *m) /* * Determine forwarding mifs from the forwarding cache table */ - MF6CFIND(ip6->ip6_src, ip6->ip6_dst, rt); + rt = mf6c_find(&ip6->ip6_src, &ip6->ip6_dst); MRT6STAT_INC(mrt6s_mfc_lookups); /* Entry exists, so forward if necessary */