From nobody Wed Feb 11 20:42:08 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fB9N11GYHz6SBR7 for ; Wed, 11 Feb 2026 20:42:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fB9N06gSJz3NDg for ; Wed, 11 Feb 2026 20:42:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770842529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=amcPGpqCurW2EiUSGr5KdCUNFksiEvJn7Z8lJZQSp/s=; b=BJh3I+BZn59D2x4K5HOffimy1NR54LVAjbxCKLr3zoHa5bBdAMyqv387Rb6fF7UMaryxoJ Z/6HZcJIgTZzpE1n45fovWrqOmnTwFUa0e40xsBw/Q5ZjBll1TU9SUG77Q5V8yNjpga3lz Ab0nekMI+udobvzD+ZPxeLw4b2lyHNd496ZJxqkzCif7YT+B3/65/fYygN4pKcPnNH98Hx /Y/7i6gitpXxQ2kn5I6Hf1VstGpIrgPS3HDJEH33nQC4GZ6IhAEyTh9/CdD/2qfSxv4PV6 JO74kL9QlxpwS4QJavOj8H4nDF3fnMHt3keGncMMTb81RoxBQgCsz/wbOeV8WA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770842529; a=rsa-sha256; cv=none; b=qf5PkRgP+BRc2nYAj9lLY3nyN9jpjLVR2qr9u55ILH9KbjOYr552b9F1F4p25P2YRzSRyG f5sK1ClnSgoaw0a3HMMFOFXGdou5JuYcLEKKpkcu/NJIjrfrfMSBHjkUmnO7Ar7uocqh3m DSoWU6StYDthsadp4KFwgNi5/pVwMXYJOMdRtD0v0nTk3C2EkIMCUiC0pmfWkDAekZkTsy 2Pp6Ji18ASuwmaFWzIvX3fEUghzEZMLJRLoGGeA/ehYL2tCpqXZdAH/wBpPK0oXZ72rl4D zQ4CZMPPIsVwl7bCTu+2vjzbgF5bb88Qvv9EcWChIJIGMlyRZBMPL8QXpSJUYA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770842529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=amcPGpqCurW2EiUSGr5KdCUNFksiEvJn7Z8lJZQSp/s=; b=C80auzvLaxHM1TkCCcniJvY5lppzTOL6Yk8tvdIXg+riODG3YlGSgY95wG9J6D5CIYSci4 t7V64Tb1ZdAVJN9iauBbfN02I3+6VIdBpAn3HShdUzwT6ZM5G7nrFiKnZy25xenuuOCD9B tQ112nFi4sV82aoT0Q9KBFcIBTrWjN7QWKD6dixIqf5k+di9KQFIBbcuFySaZT7TFHrVVW KiIlyStLyyheka8SWCk20Y5xEGmD9PTxGzkhe7tvlawbhNOsE0vi0f+PBDpeGUnIQAcA/R usHLGmuGPkENCjpxR3nnVzhF2eXS5zE1rV0+ixYj+lm9dCPyC7zso2OnwYyJHQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fB9N06F9Xz14Qy for ; Wed, 11 Feb 2026 20:42:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 46a74 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 11 Feb 2026 20:42:08 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 767f1ebcf75e - stable/13 - libfetch: Check for failure to create SSL context List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 767f1ebcf75e85912b65f9a117c9ab4f76ce71c0 Auto-Submitted: auto-generated Date: Wed, 11 Feb 2026 20:42:08 +0000 Message-Id: <698ce9a0.46a74.5d1ccd84@gitrepo.freebsd.org> The branch stable/13 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=767f1ebcf75e85912b65f9a117c9ab4f76ce71c0 commit 767f1ebcf75e85912b65f9a117c9ab4f76ce71c0 Author: Dag-Erling Smørgrav AuthorDate: 2026-02-07 14:24:40 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-02-11 13:54:33 +0000 libfetch: Check for failure to create SSL context * Drop the ssl_meth member, there is no reason to hang on to it. * Replace deprecated SSLv23_client_method() with TLS_client_method(). * Check the return value from SSL_CTX_new(). MFC after: 1 week PR: 292903 Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D55098 (cherry picked from commit 4e160c6197f75fda3d5d5997ce893087058cf718) --- lib/libfetch/common.c | 10 +++++++--- lib/libfetch/common.h | 1 - 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/lib/libfetch/common.c b/lib/libfetch/common.c index 723cba62bb57..ca5022df38b4 100644 --- a/lib/libfetch/common.c +++ b/lib/libfetch/common.c @@ -1180,8 +1180,11 @@ fetch_ssl(conn_t *conn, const struct url *URL, int verbose) X509_NAME *name; char *str; - conn->ssl_meth = SSLv23_client_method(); - conn->ssl_ctx = SSL_CTX_new(conn->ssl_meth); + if ((conn->ssl_ctx = SSL_CTX_new(TLS_client_method())) == NULL) { + fprintf(stderr, "SSL context creation failed\n"); + ERR_print_errors_fp(stderr); + return (-1); + } SSL_CTX_set_mode(conn->ssl_ctx, SSL_MODE_AUTO_RETRY); fetch_ssl_setup_transport_layer(conn->ssl_ctx, verbose); @@ -1192,7 +1195,8 @@ fetch_ssl(conn_t *conn, const struct url *URL, int verbose) conn->ssl = SSL_new(conn->ssl_ctx); if (conn->ssl == NULL) { - fprintf(stderr, "SSL context creation failed\n"); + fprintf(stderr, "SSL connection creation failed\n"); + ERR_print_errors_fp(stderr); return (-1); } SSL_set_fd(conn->ssl, conn->sd); diff --git a/lib/libfetch/common.h b/lib/libfetch/common.h index 7396c8a68ab6..06089aae5451 100644 --- a/lib/libfetch/common.h +++ b/lib/libfetch/common.h @@ -56,7 +56,6 @@ struct fetchconn { SSL *ssl; /* SSL handle */ SSL_CTX *ssl_ctx; /* SSL context */ X509 *ssl_cert; /* server certificate */ - const SSL_METHOD *ssl_meth; /* SSL method */ #endif int ref; /* reference count */ };