From nobody Wed Feb 11 20:29:49 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fB95p5VWlz6S9Hp for ; Wed, 11 Feb 2026 20:29:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fB95n73xyz3HRF for ; Wed, 11 Feb 2026 20:29:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770841790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=irtTE6mIqhzmGNUszT2sJorFVT2WOMXZfhtWXgrxtg8=; b=oNYPt0BnhVRC1yDDFO/2Ia3m3RbhijyFk2egp0lOGRDzyL/7aZhb9YkruJGBnexKkfMzu5 O5RbEUG2ipAPBFzmYDSXvolCq8j7tS2Ao6Aa74tVYelimNZnbJ6mGOBHv3CWfSX0TOLTwD 7XCaBPEHcqS7ZcKYqYmFtBfJSVwVqr2JkWFOO2wvog39VkxwDetbuMKEmoAM9PH3lepXSV aGFrKVQLCYhSJtf7m13QHbwmIL32A4pRhNiL5Zfef7lG2uNSg0YmoVCFhaxOZhAbU84liU C06y2nP6AXD1W+CiWDY9Mpt7VV1ZibvHEYMjGRReLp7RIpgN/jjbMoJ4Esknmw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770841790; a=rsa-sha256; cv=none; b=WiRIMOJQuWTurKM9gFEXdUnnCmgS+rAKcubyeAviU9k/V+zqkpshy3RcaZvW7otVGFy+SM VKos0HO8lLkapXTt7cGeBtvlXnfcT1sNSoBbo0cjDf7SJV8eMSrzWcXxni4xD50ddU3yH9 ggVKCHWHWp5a7c9p2uhuFE9DGRzgV+Bqwl8mmLKhOXlLrg1zSacMKV1mK5BZ1Avu0M+0Ye aJjyNdC4shSJcGTN9lm7PSx0ECA4n2Ww/m6d0QOanVOIBlQ//Myoz5e7dqXKrNfHHj2QkC Bu+NPycJnkE5oG1Zs0AYYU/QcYf15AGgdoewSfu4aXldxsvR1wHzFqdIwqNlGw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770841790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=irtTE6mIqhzmGNUszT2sJorFVT2WOMXZfhtWXgrxtg8=; b=sU2Aj00HbqimacN1EOXf9aIc+2IkhZgfWuLNlMqzNxS3CtLGnw4NSHVdOgujA4tQja0f/3 XGu2R93S5qh4XAa4KXXTj/+1Ha4Or4KO5+ZpkZ2tYXfpkVH2BwcYkKNvrMMvkOcl1PqCm1 4fQcACJfVVLKMV9F61+xmmgI+S/MEqmx2wbbODtktmjAA16BCgUmx0hcqTf1pN6ELRkPlq JvGju9wuOqYcl/QCnjvuDE1WKoWVrryKd0t+pBb5m0tZYaVon45wA08bFMMDr4iyRcK6eA ehJw8NZanY9MloDziK9O7pI9GhHDw6XFpCI/NEJelt6Gv88Xc1sTbfDnQQ0b/A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fB95n6cRjz14Pr for ; Wed, 11 Feb 2026 20:29:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 451b3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 11 Feb 2026 20:29:49 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Zhenlei Huang From: Colin Percival Subject: git: 7d0345d32bbd - releng/14.4 - qlnxe: Avoid reinitializing the interface when it is already initialized List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.4 X-Git-Reftype: branch X-Git-Commit: 7d0345d32bbdfe490ce88bb8704ef9d4e6adb189 Auto-Submitted: auto-generated Date: Wed, 11 Feb 2026 20:29:49 +0000 Message-Id: <698ce6bd.451b3.65526bde@gitrepo.freebsd.org> The branch releng/14.4 has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=7d0345d32bbdfe490ce88bb8704ef9d4e6adb189 commit 7d0345d32bbdfe490ce88bb8704ef9d4e6adb189 Author: Zhenlei Huang AuthorDate: 2026-02-06 17:52:54 +0000 Commit: Colin Percival CommitDate: 2026-02-11 20:29:10 +0000 qlnxe: Avoid reinitializing the interface when it is already initialized qlnx_init_locked() unconditionally uninitialize the interface thus is actually reinitializing the interface. Well the init routine qlnx_init() is to initialize the interface by net stack when assigned with the first inet or inet6 address. The ioctl SIOCSIFADDR for the first inet6 address is handled by ether_ioctl() thus the interface is reinitialized no matter it was initialized or not. Add a driver status check for that to avoid reinitializing. Further plan is removing SIOCSIFADDR ioctl from the driver and let ether_ioctl() handle it. Approved by: re (cperciva) Reviewed by: kbowling MFC after: 5 days Differential Revision: https://reviews.freebsd.org/D54887 (cherry picked from commit c10e6bc0f0079e90cb484323ad71d437f1882422) (cherry picked from commit 8731ff4871d5397bae65bf184c44629a52c0e97b) (cherry picked from commit ee6495580925b337f5851b6ee0f1188f81d7a6c8) --- sys/dev/qlnx/qlnxe/qlnx_os.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/qlnx/qlnxe/qlnx_os.c b/sys/dev/qlnx/qlnxe/qlnx_os.c index b0dac3a82582..bc0282e3c22b 100644 --- a/sys/dev/qlnx/qlnxe/qlnx_os.c +++ b/sys/dev/qlnx/qlnxe/qlnx_os.c @@ -2431,7 +2431,8 @@ qlnx_init(void *arg) QL_DPRINT2(ha, "enter\n"); QLNX_LOCK(ha); - qlnx_init_locked(ha); + if ((if_getdrvflags(ha->ifp) & IFF_DRV_RUNNING) == 0) + qlnx_init_locked(ha); QLNX_UNLOCK(ha); QL_DPRINT2(ha, "exit\n");