From nobody Wed Feb 11 20:29:47 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fB95l6lcXz6S94y for ; Wed, 11 Feb 2026 20:29:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fB95l5W5wz3HLt for ; Wed, 11 Feb 2026 20:29:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770841787; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GwiwrrTASNGJ7Z6pNLFoIpUn0Pzp3sntsgrGF0HLBCM=; b=jIayCnMTaXop66pP4RhGOtQygajQskFvEsxe5vajrJQTC++ZEdHgowmjzb5+espdXMHv1Z W0Tv94hvASOcHAEzFCotBGHMmb91axt6Kqte6mMpRU4cJNHhPr7mX2iOTmqffSJg0po3FG DlgCzGUUJqz+xGrTXU0VWQYw5P7ywNOCk9IU1pltvf+TNvQnbP6GGcqD6ZWWXn/xCAcpJh 3LdYhNXpB5ucxLNVzenH0F411982TSEKm2RtYhgy7Q4k4s17nyk8kpnPOWjwGJPNbK/E8/ CCnlcZ8xNnGQKEjHdLmodhsooRW9ZLhQiKGNH0hA51sX9z0kf/dCkUPKp80Hdg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770841787; a=rsa-sha256; cv=none; b=hMsWgnO43TIpgmOsNI+tpc6RhFj1USJGRTVqmB+GOLBEdm8q9L9OqioTh22SlWz/688Fi7 LwtsxrZjI3vcKw+HlDQZ5xhDaJkYrah2fR6OCywplSEdz3VNKS32zOHXZnk09nlAPH1TiT /PPaCqvnqYjgk4Zi8W7ytYfWkNWswvIF7ivnSksmt6GcYhmmwnbAVksK6/qjkXY8131Xjz Osnc+4RFc4sJ4NgBa+S+XXuFbUMnZbI61X4J1Ak9mhEUU9qZjP4rBHbffmwy1hH23K2itj tjK1kNtkhS6bgzBnFLMEW/ystY1dG6YnoQfDZtFhTDpN92RJqIu93Y89xuXXsg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770841787; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GwiwrrTASNGJ7Z6pNLFoIpUn0Pzp3sntsgrGF0HLBCM=; b=TPhDrHLtg0CtMY5hXxU4USauvgIakpaR2fev+jokOd8rHSEhl93fefDQX5vcYClc3XgXu8 ML8V9aKFfaHHY1JbLQGzYrBcG7bRvU7DzrH2/9Ivwl3iNzvnBYU64tHSXan02vHF1mkEgl sZqocDQ4aT8e4jpnyagwsiCOIJtrL1EvNdIY06CGy4mtLNUqHKcyKHg6uRKUxRsuAZSTP8 QCvdfFeVv+yuzSriDxkWzXNFI9b7HK9R5dW3VZmv72GTEmH5MKQz9zvDJshzCcK8MCp3A6 VyfIRwjvJtKF716M4ZwvGswnA2AmIPZOvDrtb8dqXx2N/qxORrDoWVt4CPn8pg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fB95l4xJHz14bx for ; Wed, 11 Feb 2026 20:29:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 45997 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 11 Feb 2026 20:29:47 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Zhenlei Huang From: Colin Percival Subject: git: f8e20e75a61b - releng/14.4 - qlnxe: Fix setting the unicast MAC filter of RX path List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.4 X-Git-Reftype: branch X-Git-Commit: f8e20e75a61bf2e9bc108e6745dca57eb51316c7 Auto-Submitted: auto-generated Date: Wed, 11 Feb 2026 20:29:47 +0000 Message-Id: <698ce6bb.45997.7ec9e2b6@gitrepo.freebsd.org> The branch releng/14.4 has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=f8e20e75a61bf2e9bc108e6745dca57eb51316c7 commit f8e20e75a61bf2e9bc108e6745dca57eb51316c7 Author: Zhenlei Huang AuthorDate: 2026-02-06 17:52:53 +0000 Commit: Colin Percival CommitDate: 2026-02-11 20:29:04 +0000 qlnxe: Fix setting the unicast MAC filter of RX path When an Ethernet interface is added to lagg(4) as a child interface, its type, aka if_type, is changed from IFT_ETHER to IFT_IEEE8023ADLAG. Well changing the link-layer address of the lagg(4) interface will be propagated to all child interfaces, hence the drivers of child interfaces shall not presume the type of the interface will not be changed. Meanwhile, on initializing, an ifnet has been fully attached and it is guaranteed to have non-null link-layer address so stop NULL checking for it. Approved by: re (cperciva) Reviewed by: kbowling Fixes: 792226e53023 qlnxe: Allow MAC address override MFC after: 5 days Differential Revision: https://reviews.freebsd.org/D54885 (cherry picked from commit f250852c9a0c1021c3be4b498e27cfc7b42a81db) (cherry picked from commit 6d138e958ffb318595eec29b910cada414e2f86d) (cherry picked from commit 93719f8c8348a5d13c9037352072ce67f530288b) --- sys/dev/qlnx/qlnxe/qlnx_os.c | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/sys/dev/qlnx/qlnxe/qlnx_os.c b/sys/dev/qlnx/qlnxe/qlnx_os.c index 1c885133c3ec..ec2fd7cacfae 100644 --- a/sys/dev/qlnx/qlnxe/qlnx_os.c +++ b/sys/dev/qlnx/qlnxe/qlnx_os.c @@ -7057,20 +7057,10 @@ qlnx_set_rx_mode(qlnx_host_t *ha) int rc = 0; uint8_t filter; const if_t ifp = ha->ifp; - const struct ifaddr *ifa; - struct sockaddr_dl *sdl; - ifa = if_getifaddr(ifp); - if (if_gettype(ifp) == IFT_ETHER && ifa != NULL && - ifa->ifa_addr != NULL) { - sdl = (struct sockaddr_dl *) ifa->ifa_addr; - - rc = qlnx_set_ucast_rx_mac(ha, ECORE_FILTER_REPLACE, LLADDR(sdl)); - } else { - rc = qlnx_set_ucast_rx_mac(ha, ECORE_FILTER_REPLACE, ha->primary_mac); - } - if (rc) - return rc; + rc = qlnx_set_ucast_rx_mac(ha, ECORE_FILTER_REPLACE, if_getlladdr(ifp)); + if (rc) + return rc; rc = qlnx_remove_all_mcast_mac(ha); if (rc)