From nobody Wed Feb 11 20:29:45 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fB95j5Ffmz6S8pP for ; Wed, 11 Feb 2026 20:29:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fB95j4PTPz3H5S for ; Wed, 11 Feb 2026 20:29:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770841785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=34d6xVPux+SKClmRB37b3yEVA8TGiwKseR5QpeVnC5k=; b=FkwlOwUNsjVwVop/JRxnsVeVEzcNhkoLnapxzZ6GJsy1bW9o87qGc0SrYrNNiwGZQ2Sv09 ljcC9ivunCQdlCyU7uoxIzFEyVJNeSQHU/4aXiiGqRzNnC8lPwDEqID0tco8ULPuqfok4/ +zQRl+pHJFYNZWvc4Qy/241HtpH63ObWc4mOVibiAXepGTOo8CeqHn0JCxp2myLPwSLjoi FosuA+aFzozwXXEhZl6/tK8A4OpTXAbp5th2jLLlQ/CS/5arFug5SwkjUJJGkomIqhgzJg Ezt01j1GJNvh69hq2X1oWn+kVW8JjVA5eSMipsUCf6vpjA6KD5bnVsbYB0Kcyg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770841785; a=rsa-sha256; cv=none; b=DAqOtSSa4mn7lsIe/V6gmcw9Rhyx5GAJRkAAR86pE2ThQNkvytqO1JvAr9wH/yKk1j9KxK MKHTQ3DLgxdXTUmvo2WsT/zuVMyO6fyACP+YpFvBvUGsRPrCB42IFye5xrc6QZOVPhqcjc rLfL5a8aBFQAJC+0GYrRIqmpQ99RA8lDMAvZgvfprwmUxefm9NrlToO1Qhr0LoPSTMbD/a jue4flCt+iwXfr4HLhV8NEGNAG7MOryjwRlWSzVkvYQCYMwWRoyUla8WGS+BJbjGcCclot rPPrdOnno8/u/L4rLKtrVGDi1GpLea46jJD4mh3x8arTGoe8Inz6YmUR7R+kZw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770841785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=34d6xVPux+SKClmRB37b3yEVA8TGiwKseR5QpeVnC5k=; b=LULa2jXgD//id1T+hhAYmzzfzolhcenfde/G/EwcI9mCVkz56VJUcGD+604b5Q8d4Htj4K De2xFpUzMV0HQVmc9VlpI6vTlhW1QPauZvmYDnWL44z0Ru5lNIdtgbJZUqXTJscPPRukL2 PJ8m+tDYFsFgAuJnpAEpsPdXjuZHV0t8VwURuEr0XGNFbEPRWRc3NmaD9BDUQ4XPu7cFdl DHoqTsQ+uodj36fMPOEAaWwtjsCoKmpzY1sRePp3dlwt1gBwXpVrEXcAc507C2a6biMoLh l6ExA/govp0y4EPw8C06+YhWTpgHXJ1HCAQob9n9eb0uhhYu3bq9FnIOz0ne/w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fB95j3nHvz14N3 for ; Wed, 11 Feb 2026 20:29:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 45a83 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 11 Feb 2026 20:29:45 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Zhenlei Huang From: Colin Percival Subject: git: 644486902097 - releng/14.4 - qlnxe: Remove a pointless copy back from the link-layer address List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.4 X-Git-Reftype: branch X-Git-Commit: 644486902097959108c30721a92420a2a4f15223 Auto-Submitted: auto-generated Date: Wed, 11 Feb 2026 20:29:45 +0000 Message-Id: <698ce6b9.45a83.35a28c00@gitrepo.freebsd.org> The branch releng/14.4 has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=644486902097959108c30721a92420a2a4f15223 commit 644486902097959108c30721a92420a2a4f15223 Author: Zhenlei Huang AuthorDate: 2026-02-06 17:52:53 +0000 Commit: Colin Percival CommitDate: 2026-02-11 20:28:56 +0000 qlnxe: Remove a pointless copy back from the link-layer address On ifnet attaching, ether_ifattach() makes the link-layer address by shadow copying the ha->primary_mac. Well, the link-layer address will not be altered during attaching, thus it is pointless to copy it back. No functional change intended. Approved by: re (cperciva) Reviewed by: kbowling MFC after: 5 days Differential Revision: https://reviews.freebsd.org/D54883 (cherry picked from commit 4ac3081b282800158df7abe93f307d76e1b5b808) (cherry picked from commit 23ffd1650cc431e762387d384ede99ae085bc130) (cherry picked from commit 7d7cee09b9a4ac5cbcbac79cb7ccfef5d6db1e0f) --- sys/dev/qlnx/qlnxe/qlnx_os.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/dev/qlnx/qlnxe/qlnx_os.c b/sys/dev/qlnx/qlnxe/qlnx_os.c index 99110e5e2d8f..9616d9f4d611 100644 --- a/sys/dev/qlnx/qlnxe/qlnx_os.c +++ b/sys/dev/qlnx/qlnxe/qlnx_os.c @@ -2392,8 +2392,6 @@ qlnx_init_ifnet(device_t dev, qlnx_host_t *ha) ifmedia_set(&ha->media, (IFM_ETHER | IFM_AUTO)); ether_ifattach(ifp, ha->primary_mac); - bcopy(if_getlladdr(ha->ifp), ha->primary_mac, ETHER_ADDR_LEN); - QL_DPRINT2(ha, "exit\n"); return;