From nobody Sun Aug 30 01:43:35 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hXZf002g3z6pv3L for ; Sun, 30 Aug 2026 01:43:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hXZdz6dz3z3xv4 for ; Sun, 30 Aug 2026 01:43:35 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788054215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gBHHOmZ5h9t0CB+nRq53TMQ33oFeZOXCEaU9Xsby09Q=; b=afTk9xBOLrJZFR1lwF7zjslm4XEMv2tY7hanQlHFnVN79jSIGHmJnCVh4qEhAhmL0gMlP8 byxQlpgi61aCKT5CPZsGOEfbvUsPj7l/TmrS2uBGdiTF6XS6Xs9ttuyjI9C2Bz62DW+oLi uaE1A1A1inJeFvkeVtqfuylu9Wt/y9a3xDdoZ/2dczeHMZW10nfm5hYnykNHtdXPlFQJk2 v9NRJiY4dv/sUUAjthei0f2QcbrKkaecfy6kiXnTic0xR0zTVCf3tLU5cOu1K7Voa7WTMy gRsevGMXa4SOpWn0Ja7uSE6HQyuDMU/LBm9j3Ik/NdT586Tz7XLyZUdstr8NcQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1788054215; a=rsa-sha256; cv=none; b=MUgnIk99R2IsAdHUZrh4I3te6GMB34Lhjbpf0ZppLd2nENr/2gfAw+a6XPdjtlsUbdybew jvqk6mjxi5RWHLrrQZeeECVn9D+JZUrqx+vgMvRLeS63UAhZbUEGzTvQx++NHFMyTAt0F+ D/GPVvi/TKnahNwUX4+k6GoLBJGz9UbqnSDIP0FOMQXHwiaUSFMe9pFP86mrBtYoGTTUhE lrPZSi4tiEdsE7NgzeLy9mxYimx/JyG44hBS9Jymi+QA886hxMDtz5a8IkcuGTbI8NY3GF sqTEECyKvRr3RvbqLEKUl8HpgDDoyE6XCzLDB+znFJRgLZN70kktOwS8B3xXMg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788054215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gBHHOmZ5h9t0CB+nRq53TMQ33oFeZOXCEaU9Xsby09Q=; b=vfWTTRVEXcEz+C1I7pGqkRWW96qB29YQRvL+gXsioEc1VUiXifpBOpIgL9h/SvsyYTM6AK xcqp0HM/28Phh3sYVjChnkxQWnZIRYaYGOXHhkkXTRy63fBeXWRwL505VZDgLSpeuGqVjE xIZt/tSHmPvqESuqVGE29+a636YZtY29scN4Fj0NiHTjsl8MI/t9iWV7pITpgqmxo39cnH wH8CkKcPR9BWOqtNmQ1ul3rPX4RQVvC1pG3NMdjyhs2StHlE8ITVOSbgij0S1n5mCAq//t w0+lgGB9Qa0I3W3PIS0Yf3FMYReoy2lPsNvq1kA4I04nv+q4H3eo3L6ChA0N1g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hXZdz543cz14GF for ; Sun, 30 Aug 2026 01:43:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 404f9 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 30 Aug 2026 01:43:35 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: 8a6c20aee2fa - stable/15 - igb: Guard register dump during queue setup List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 8a6c20aee2fae9bca0c81dde271f7362c9ac3bb3 Auto-Submitted: auto-generated Date: Sun, 30 Aug 2026 01:43:35 +0000 Message-Id: <6a938ac7.404f9.710f1fce@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=8a6c20aee2fae9bca0c81dde271f7362c9ac3bb3 commit 8a6c20aee2fae9bca0c81dde271f7362c9ac3bb3 Author: Kevin Bowling AuthorDate: 2026-07-30 02:26:48 +0000 Commit: Kevin Bowling CommitDate: 2026-08-30 01:43:22 +0000 igb: Guard register dump during queue setup The register-dump sysctl is installed before iflib allocates the queue arrays and remains visible while they are freed. Return ENXIO outside the queue lifetime instead of dereferencing a NULL or stale array. Sponsored by: BBOX.io (cherry picked from commit bcb62ec0e3d592892f0f304269ed2722d1bae75a) --- sys/dev/e1000/if_em.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c index 93bab0e65ee6..99495e93d265 100644 --- a/sys/dev/e1000/if_em.c +++ b/sys/dev/e1000/if_em.c @@ -795,6 +795,13 @@ static int em_get_regs(SYSCTL_HANDLER_ARGS) u32 *regs_buff; int rc; + /* + * This sysctl is registered before iflib allocates the queue arrays, + * and remains registered while iflib tears them down. + */ + if (sc->rx_queues == NULL || sc->tx_queues == NULL) + return (ENXIO); + regs_buff = malloc(sizeof(u32) * IGB_REGS_LEN, M_DEVBUF, M_WAITOK); memset(regs_buff, 0, IGB_REGS_LEN * sizeof(u32));