From nobody Tue Aug 25 00:43:02 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hTTXQ4Hnqz6pP8s for ; Tue, 25 Aug 2026 00:43:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hTTXQ2V6gz3GZ3 for ; Tue, 25 Aug 2026 00:43:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787618582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BKeUKDZzdqX8y9vefiYiE5DT6Rv6lIkBndixTfsiq2w=; b=hA1lYBwu0l1uu593UxWxTq0H8zPA27IzjdIwmSL2unHu8AqLZiy+iLjX1IO9TcrQ8R3MJG lJja1xxhU551rr6PWR35P0nQlPeiQz0yVB9a4UHWHUypxRz9LrLIGwEoLnBzBHZ7Zrwb+A Ra9Z66O51K29YKJssGPLySBoRa+gkk1zKDA8eQccRzek9g42SV0ncHF9+61Eg3Lllel0nk +h5doPssYu9D+t82LcSOOU2Tiah/FSGumqTOu9mi9WtG4ija2td6hwK4V0dvb8MmCaBs8Y aTfuK6K+WRFTCJgWHfoth6IDutJl6N2GYlwqh1U8rY1a+OxXl64UavXERzg+hw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787618582; a=rsa-sha256; cv=none; b=g4fPEEHaXz5i9nnpvvi1hiHdgNMm6Kq1v7/YJ1FHGhhm5YGDBINp1EYnSrOlqTlapeFMrv JnkhnsQ2UH0VB0zQEXiFZ21zbxE/yGMMWcqvsDFgplAUTWX93tH5o9OIgZTen8+tHiKc4w sOxNePcEkR5i+QWniBrXTMjOX2YhQc70jEg1+Idx+KuCGh+eg8UfmeeJQc/N2vCAEnc4aN pfcbnr1AuX61afVCaydqwhl5QF0euSYislFAbVrMqCib7Rp+AnmWXRnMbn1l5vKLn75kM+ GdJMGUpWzP9F+ykvRYRYgnf7G60kOn6+ro23HOk1TJ6KedpDOuuWvn70bRsh+g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787618582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BKeUKDZzdqX8y9vefiYiE5DT6Rv6lIkBndixTfsiq2w=; b=Q5Q4wVd96S9gcxiULsJhx4W6nKjgyqyjyfNLCK8mlaQJKUttmNTvumKC+J7CHhuAQi0RVY mSs8/z/h1OYaFc4DHa5+RYUL6jnCh4VgQIJmuA8mWmlNTNHa3WtkTMZwFUTFMJ21iBc+yi YimEQI0tg4i80o7GCrED/vQb7GPKv6xfN3V0hqJ3R/88KANChQbhm/XAnOx8Xfxfl4coW3 Nu7IM3nwk/KSClOzN4LbHfeBMvIOFwNPA4YlCdnsiTbtgGgePC0bjuyp8eP4HGw2t2jKSL taYorjpkBTjmhYbFz9QjYJH7Z1WXpAq2OYuWnBDt3EZnPfgUWgFOp8gB2TRSqw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hTTXQ1LH3zCnl for ; Tue, 25 Aug 2026 00:43:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 40dcc by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 25 Aug 2026 00:43:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: eee64d77475d - stable/14 - igc: Avoid a signed shift while assembling the PHY ID List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: eee64d77475d2fe3cebf0f67d66e139cc55d3988 Auto-Submitted: auto-generated Date: Tue, 25 Aug 2026 00:43:02 +0000 Message-Id: <6a8ce516.40dcc.3da39512@gitrepo.freebsd.org> The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=eee64d77475d2fe3cebf0f67d66e139cc55d3988 commit eee64d77475d2fe3cebf0f67d66e139cc55d3988 Author: Kevin Bowling AuthorDate: 2026-08-11 19:40:56 +0000 Commit: Kevin Bowling CommitDate: 2026-08-25 00:42:19 +0000 igc: Avoid a signed shift while assembling the PHY ID The PHY identifier word is promoted to signed int when the cast is applied after the shift. Cast the 16-bit register value first so identifiers with their high bit set are assembled as unsigned data. (cherry picked from commit f5fd839fe688181e57171850ce51e4dec71e62fd) --- sys/dev/igc/igc_phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/igc/igc_phy.c b/sys/dev/igc/igc_phy.c index 24ecefb2c625..fffdfad3b237 100644 --- a/sys/dev/igc/igc_phy.c +++ b/sys/dev/igc/igc_phy.c @@ -143,7 +143,7 @@ s32 igc_get_phy_id(struct igc_hw *hw) if (ret_val) return ret_val; - phy->id = (u32)(phy_id << 16); + phy->id = (u32)phy_id << 16; usec_delay(200); ret_val = phy->ops.read_reg(hw, PHY_ID2, &phy_id); if (ret_val)