From nobody Tue Aug 25 00:31:19 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hTTGw4LFXz6pMJs for ; Tue, 25 Aug 2026 00:31:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hTTGv74sxz486j for ; Tue, 25 Aug 2026 00:31:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787617880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=R84s6vrA3dHK+Qshmu8GtAzFcrXXLdqAtqUKe3LJtyo=; b=TEHadqiudFzVKRt3+TOIP/QiaVFzcWjAkTRbppnMJ94vECfnyIaQD/SAylURQWqxzY/SnW yHgNoOfs4y2UaWb7Kvvt8/1UF+S6/cljpmXj5FY025sSK2L9MBmloEauG18d5LE3nyhRTZ Sb1/c27jVNILJ2kPSvbhcFopKDeXrUsemkC1vccTotZFl8VrOzMxW1vlUdnt401A7yLFUd c8ZX2OUs+C/lVPnID6kBbmK0Dv4k5klAnxaQLXLDOqqRFB33Ht2nQFLRxy9he8B9afRJpg hUVNCQEJipA7oOA/1myKL8gZsv62FDrssWHSb4jqiy/rNZqUozRbnHYV7Lp96Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787617880; a=rsa-sha256; cv=none; b=SrQGctMLZW3K2WaXi5X3SInGCMQIqkS2VSBhzM146L8vO8339lW0KQOjO5kVwBX3WO1hFc hf4acpQ2kxnKTXGyZPWAo8XhxvM1E6eOjnN5I00PgGzlmOpCskRuu36lPFbNNfxeSB73YR +G4W2ZOU66L5mLv2fET4dRf4H4qFUYMFQVMad2/2AJFVJWv/Xym99n/tHhh1lphqDFvkQt ybqwea6OlR9q8snkJxWG7x3qDOvBwOyNYkC9HO9oOwP7QjZnVtOTqesEHDftAJM7dzm4ji Gi9dD5XgIcU9p17ldavCtB+Jndt5DCUkNU8jKzIZA2vAEqbW3YmJfgegei+rUw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787617880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=R84s6vrA3dHK+Qshmu8GtAzFcrXXLdqAtqUKe3LJtyo=; b=GpuA3SpocTGhKKxerFji11dcpsXFaxxG58hwjy74mXY5Do8vMxBgjm8i/owXqOwNqWCRRp p0oePtI8SUEmDUM5T4TGRu8FKh5SBoPci6aLDzqz8akSCmqZyiPiYsNvCjfDS2kC+KCmcN /liyvz/dOlV5E8Fpcdl/vZWi8NtGI6XOmHikQLGfdHdBZtHEvBXmyP/dMBoXhqOEf57HNQ qBJdNhNQL9pbbeEXWWgpL9BzxjW/XF9Ub4EwjbiBYvFMb+sdVGSRJqxg29G2hC7ngnw0JJ G0GrNsUn+oTkl5pHy5jeifytpk9j8btiLtlQq+eMShrUjnx6w8UMIzXYfLnU4Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hTTGv3mlgzC22 for ; Tue, 25 Aug 2026 00:31:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3d9e8 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 25 Aug 2026 00:31:19 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Sasha Neftin From: Kevin Bowling Subject: git: d94f3e16141e - stable/15 - e1000: improve NVM checksum handling List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: d94f3e16141e830a51aff73cf21310e34b7f763c Auto-Submitted: auto-generated Date: Tue, 25 Aug 2026 00:31:19 +0000 Message-Id: <6a8ce257.3d9e8.e4cd5fe@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=d94f3e16141e830a51aff73cf21310e34b7f763c commit d94f3e16141e830a51aff73cf21310e34b7f763c Author: Sasha Neftin AuthorDate: 2025-02-07 12:45:22 +0000 Commit: Kevin Bowling CommitDate: 2026-08-25 00:23:59 +0000 e1000: improve NVM checksum handling DPDK commit message net/e1000/base: improve NVM checksum handling When reading NVM checksum, we may encounter the following scenarios: - Checksum may be invalid, and can be updated - Checksum may be invalid but cannot be updated because NVM is read-only For the latter case, we should just ignore invalid checksum and not attempt to update it. Signed-off-by: Sasha Neftin Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson Obtained from: DPDK (5241c17f0d) (cherry picked from commit 8e8755e011955d12abab7c2be324429cccf0b975) --- sys/dev/e1000/e1000_ich8lan.c | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/sys/dev/e1000/e1000_ich8lan.c b/sys/dev/e1000/e1000_ich8lan.c index d454b2ede3dc..1a67f4d8f42d 100644 --- a/sys/dev/e1000/e1000_ich8lan.c +++ b/sys/dev/e1000/e1000_ich8lan.c @@ -4436,13 +4436,20 @@ static s32 e1000_validate_nvm_checksum_ich8lan(struct e1000_hw *hw) return ret_val; if (!(data & valid_csum_mask)) { - data |= valid_csum_mask; - ret_val = hw->nvm.ops.write(hw, word, 1, &data); - if (ret_val) - return ret_val; - ret_val = hw->nvm.ops.update(hw); - if (ret_val) - return ret_val; + DEBUGOUT("NVM checksum valid bit not set\n"); + + if (hw->mac.type < e1000_pch_tgp) { + data |= valid_csum_mask; + ret_val = hw->nvm.ops.write(hw, word, 1, &data); + if (ret_val) + return ret_val; + ret_val = hw->nvm.ops.update(hw); + if (ret_val) + return ret_val; + } else if (hw->mac.type == e1000_pch_tgp) { + /* Transitional TGP images may omit the valid bit. */ + return E1000_SUCCESS; + } } return e1000_validate_nvm_checksum_generic(hw);