From nobody Sat Aug 22 00:50:08 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hRdr12WNSz6prVZ for ; Sat, 22 Aug 2026 00:50:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hRdr06SqNz3NkT for ; Sat, 22 Aug 2026 00:50:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787359808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Khxz5oLAgeJ650UEkaoQjrDkKQzQwAP4panm6XVWECc=; b=PPD12vgahYSxBTpqQRAmAJiIk3V2a4cWcLH1cMcgHfUJfnr2HKWeMGG1paA/dRxMTeKwEQ cQdwIlO46r/N4ImxbmEmcwM4ucbqlLJ9YRM7HJyoJ3KIK9ggSOBIB+qlBeI+WlqA5rRsPS SOPnj+JgHu39E7qgmFlj63QE3o6YqtaK8GCn/CBBbaG4XSEwBRKOGaV2qCG0qahjbycu+2 eYQGnLHN4n+1ZZV450o2UHWp2Im4vxiQ5i/2UDKXuPrHx3mN/8z6kneLzVwE1bSvJ1ndd0 i4mCktZH+dTpJw/DQhE5x0SWqwzTuRIHkSRF4J/fSX36pdsjGbhDzi1iNa6svA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787359808; a=rsa-sha256; cv=none; b=Q/aciFAKOVlKXGwCoi4xwUXKgNAgL2Q41NGOW0t1u+/icRq61uWOtcdIcEhWG17W+sWru2 FeyrZaVb5yk5RFa/Fd/TZF/MtfqGx9yPXFjriMpH8GjdO1gi1z68TNc1L2jp/3Z28O3JoO Th7pyRVktk7cQO6pltwFjvvxrhbUvFdx8TjjH52T9oti7AdwrHXNtdghMqNMJOIe2FlJpK YroteT4Oq8UXv3hGa29L5EzxGRxAEMhfYH64U7el40Z478Br9BHy+4apRkfQ5FVNT906Ih IqlzwuxoB3Mu4MOYJ/qHt5oHyQhb8wCim//4BNWMkWcIAtSWMvAWp+teU2viAA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787359808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Khxz5oLAgeJ650UEkaoQjrDkKQzQwAP4panm6XVWECc=; b=d3x5BD7RwymUVhgVw8pMovgdAFPPwxGvFgcTqT4Awh2M6jud+gcAxu48pTiAI1LZZxlPO7 q6DTMed+8V74jhiQYc/jSAt4u3FhNrNj5qQFnFk/m4V5uT4fYB5I1l7ccWsRxpQmThRghA wdlSOzqoVdx+7+hA07aa9Psl9hox3g49QjW870jOf708qhGXR6fDradQJCBNkJiQGxUbTn qGrJ9KSaCW5kg4qVlhrGB5mqNlXp4lzF1xcNZwL/VWrbxkoNntY42iGjoSnJoKP2jN0ity 7oPCTTH+N+FBM5Aurp0BBY60+nY4rG+bLmg0EtnhR20w98TPgev2cTQX4gt27Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hRdr04tH6zB8N for ; Sat, 22 Aug 2026 00:50:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 25fbf by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 22 Aug 2026 00:50:08 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: 036522d3b97f - stable/14 - igb: Match Tx descriptor control to iflib List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 036522d3b97fc3cb165524d85e697d2219219225 Auto-Submitted: auto-generated Date: Sat, 22 Aug 2026 00:50:08 +0000 Message-Id: <6a88f240.25fbf.4bd43b82@gitrepo.freebsd.org> The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=036522d3b97fc3cb165524d85e697d2219219225 commit 036522d3b97fc3cb165524d85e697d2219219225 Author: Kevin Bowling AuthorDate: 2026-08-08 11:29:44 +0000 Commit: Kevin Bowling CommitDate: 2026-08-22 00:50:00 +0000 igb: Match Tx descriptor control to iflib iflib requests transmit completion status only on selected descriptors. Program a zero writeback threshold so igb hardware honors those sparse RS bits instead of writing back every descriptor in threshold-sized batches. Use the existing family specific prefetch threshold: eight descriptors on most controllers and 20 on I354, with a host threshold of one. These values match the Intel-derived Linux and DPDK drivers. Their nonzero writeback settings are not appropriate here because those drivers set RS on every packet. A zero writeback threshold also avoids depending on interrupt timer flushes affected by 82576 specification update erratum 26. Remove the old IGB_TX_WTHRESH macro as well. It has had no callers since the iflib conversion, so its 82575 conditional no longer implements any policy. (cherry picked from commit fddc393d93169b428fe64e9513ee463b5154b62a) --- sys/dev/e1000/if_em.c | 41 +++++++++++++++++++++++++++++++++-------- sys/dev/e1000/if_em.h | 7 +++---- 2 files changed, 36 insertions(+), 12 deletions(-) diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c index 5603d63e480b..13187ea210cf 100644 --- a/sys/dev/e1000/if_em.c +++ b/sys/dev/e1000/if_em.c @@ -3747,6 +3747,36 @@ em_legacy_txdctl(struct e1000_hw *hw) return (txdctl); } +static u32 +igb_txdctl(struct e1000_hw *hw) +{ + u32 pthresh; + + switch (hw->mac.type) { + case e1000_i354: + pthresh = I354_TX_PTHRESH; + break; + case e1000_82575: + case e1000_82576: + case e1000_82580: + case e1000_i350: + case e1000_i210: + case e1000_i211: + case e1000_vfadapt: + case e1000_vfadapt_i350: + pthresh = IGB_TX_PTHRESH; + break; + default: + KASSERT(0, ("%s: unsupported MAC type %d", __func__, + hw->mac.type)); + pthresh = IGB_TX_PTHRESH; + break; + } + + return (pthresh | (IGB_TX_HTHRESH << 8) | + E1000_TXDCTL_QUEUE_ENABLE); +} + /********************************************************************* * * Enable transmit unit. @@ -3797,15 +3827,10 @@ em_initialize_transmit_unit(if_ctx_t ctx) E1000_READ_REG(hw, E1000_TDBAL(i)), E1000_READ_REG(hw, E1000_TDLEN(i))); - if (hw->mac.type < igb_mac_min) { + if (hw->mac.type < igb_mac_min) txdctl = em_legacy_txdctl(hw); - } else { - txdctl = 0; - txdctl |= 0x1f; /* PTHRESH */ - txdctl |= 1 << 8; /* HTHRESH */ - txdctl |= 1 << 16; /* WTHRESH */ - txdctl |= E1000_TXDCTL_QUEUE_ENABLE; - } + else + txdctl = igb_txdctl(hw); E1000_WRITE_REG(hw, E1000_TXDCTL(i), txdctl); } diff --git a/sys/dev/e1000/if_em.h b/sys/dev/e1000/if_em.h index d504f86ad390..4873eb330e87 100644 --- a/sys/dev/e1000/if_em.h +++ b/sys/dev/e1000/if_em.h @@ -316,10 +316,9 @@ #define IGB_RX_WTHRESH ((hw->mac.type == e1000_82576 && \ (sc->intr_type == IFLIB_INTR_MSIX)) ? 1 : 4) -#define IGB_TX_PTHRESH ((hw->mac.type == e1000_i354) ? 20 : 8) -#define IGB_TX_HTHRESH 1 -#define IGB_TX_WTHRESH ((hw->mac.type != e1000_82575 && \ - sc->intr_type == IFLIB_INTR_MSIX) ? 1 : 16) +#define IGB_TX_PTHRESH 8 +#define I354_TX_PTHRESH 20 +#define IGB_TX_HTHRESH 1 /* * TDBA/RDBA should be aligned on 16 byte boundary. But TDLEN/RDLEN should be