From nobody Wed Aug 12 20:30:58 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hL0W62nh0z6nvxw for ; Wed, 12 Aug 2026 20:30:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hL0W61jLKz4Fr0 for ; Wed, 12 Aug 2026 20:30:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786566658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+YPKvEM1J3EaHGA8q8a6Q5WTq7oOEzcluxTLBqLvOAk=; b=vlzMJ05Nwe1/pP0dTw9kSqdTSC7Kdp1TUEJBUreEqs0tvTHxDDH4g73Xk0L4P0dUhC7f08 ZjS3siZHyNEmtlFgvt1xW4yRCM2HDPKY+j36MU2UEjVs24mJ90djnBVUzsFhLgGMrIEbFJ j9R39q67OY8ruVWZiJBnF6UUlbGBJHEyli9lpaEQOeadrsf9SNxxj8+J8quHITurOkT3I8 TJ4oRh3iExHOZgyosUeWHUNBrcdbTnnVVBGIfcCIoaANIzADegREoMgX8j8+YGbCxd3rRi 1qmPZlbn3ihF/RurSnPJwoGVnaQxcf5s1S+5LGgb2hrRe42WghxjIavNV/0nYA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786566658; a=rsa-sha256; cv=none; b=cTVUH+OX15qHWiihcbSdqiy26waEaAFknReaLmXeMgFaZAAjYqimzcx6CrMqxGhvfaFBBB 0ql6CZcIG15Tija990uZdgSbkGxMbJzPOfVJN3qTwZQLbbik7KLmYCq3ZEw4CNVpmqlrq5 /ZKL7ddlT/mPPazRDhxtYBQIFjzEDnYZv2ffbbfpuyKfacRvxB7oaHPeXFY99YIz7j98CR qlIAA5fUkQYUmo/Zz2mPtrN3I8HQ0AUeI0Nxr5ZpKq9ROgdriVNB+FWlT9FeKkBE8I4Sws L689w6Unto4878HfA8zFqYClSLQJodS0wkBpsK3MFq1iFyYSIKiABuFwColGGw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786566658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+YPKvEM1J3EaHGA8q8a6Q5WTq7oOEzcluxTLBqLvOAk=; b=bZhSLQUyns8Y4Iqdo+Uq9FAk30IKnxaK2OG69/vyQSOt/QibO7aP0xrtxNGMkDrjRIrEIH /DZyxJ9of93RknG1qW7ooAFIN5FoXA+kqZDBzsdvRqGN2vl8f3SknTGi1a358eXeHVld8X WtiAV3G8W2EeTG7OA5lJVccxbcM5uanX7BUqjn8szeN18w7zbIxhzitTj8qPd202Wu7gsn FiC6AQnBp2yx7b8LieVDjTTakaS2qCT3i5G12aDicrt0Q6NC7noYVmnEhxU25CiOJ96LwL rW1WOOJMEY7JhvYZgCyaZNcdqbIck6MygS2RVbnPYnr+cfMgHp+n+OU8SzH5lA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hL0W60FjZzhVk for ; Wed, 12 Aug 2026 20:30:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 384a1 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 12 Aug 2026 20:30:58 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Abdelkader Boudih From: Kevin Bowling Subject: git: a58471a2789d - stable/14 - igc: defer sysctl-driven reinit to the admin task List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: a58471a2789dd6c96933d9ecb8c30bafb1705fba Auto-Submitted: auto-generated Date: Wed, 12 Aug 2026 20:30:58 +0000 Message-Id: <6a7cd802.384a1.302da04c@gitrepo.freebsd.org> The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=a58471a2789dd6c96933d9ecb8c30bafb1705fba commit a58471a2789dd6c96933d9ecb8c30bafb1705fba Author: Abdelkader Boudih AuthorDate: 2026-08-05 04:40:58 +0000 Commit: Kevin Bowling CommitDate: 2026-08-12 20:30:46 +0000 igc: defer sysctl-driven reinit to the admin task igc_sysctl_eee() and igc_sysctl_dmac() called igc_if_init() directly. Request the reset through iflib instead, and skipping while the interface is down; the new value is picked up by the next init. Unlike e1000, igc has no ASSERT_CTX_LOCK_HELD and no acquire_swflag path, so the defect is silent here rather than an assertion failure. While here also remove unnecessary igc_if_init uses: iflib_if_init_locked() already runs after IFDI_RESUME and IFDI_MEDIA_CHANGE, so the trailing *_if_init() only added an unstopped IFDI_INIT that the following iflib_stop() undoes. Differential Revision: https://reviews.freebsd.org/D58629 (cherry picked from commit 30ccf2f48c11e54fc0540510dcec7cd006a2c366) --- sys/dev/igc/if_igc.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/sys/dev/igc/if_igc.c b/sys/dev/igc/if_igc.c index fe278f2029f3..c49948f7c57e 100644 --- a/sys/dev/igc/if_igc.c +++ b/sys/dev/igc/if_igc.c @@ -807,8 +807,6 @@ igc_if_resume(if_ctx_t ctx) */ igc_disable_broken_l1_2(ctx); - igc_if_init(ctx); - return(0); } @@ -1288,8 +1286,6 @@ igc_if_media_change(if_ctx_t ctx) device_printf(sc->dev, "Unsupported media type\n"); } - igc_if_init(ctx); - return (0); } @@ -3224,6 +3220,16 @@ igc_set_flowcntl(SYSCTL_HANDLER_ARGS) return (error); } +static void +igc_sysctl_request_reinit(struct igc_softc *sc) +{ + if ((if_getflags(iflib_get_ifp(sc->ctx)) & IFF_UP) == 0) + return; + + iflib_request_reset(sc->ctx); + iflib_admin_intr_deferred(sc->ctx); +} + /* * Manage DMA Coalesce: * Control values: @@ -3269,7 +3275,7 @@ igc_sysctl_dmac(SYSCTL_HANDLER_ARGS) return (EINVAL); } /* Reinit the interface */ - igc_if_init(sc->ctx); + igc_sysctl_request_reinit(sc); return (error); } @@ -3290,7 +3296,7 @@ igc_sysctl_eee(SYSCTL_HANDLER_ARGS) return (error); sc->hw.dev_spec._i225.eee_disable = (value != 0); - igc_if_init(sc->ctx); + igc_sysctl_request_reinit(sc); return (0); }