git: e05d4c4c08b2 - stable/14 - ethernet: Prefer memcmp() over bcmp()

From: Zhenlei Huang <zlei_at_FreeBSD.org>
Date: Sat, 27 Sep 2025 15:14:00 UTC
The branch stable/14 has been updated by zlei:

URL: https://cgit.FreeBSD.org/src/commit/?id=e05d4c4c08b2d515713e909cb9c5a30a7c9da153

commit e05d4c4c08b2d515713e909cb9c5a30a7c9da153
Author:     Zhenlei Huang <zlei@FreeBSD.org>
AuthorDate: 2025-09-03 17:09:11 +0000
Commit:     Zhenlei Huang <zlei@FreeBSD.org>
CommitDate: 2025-09-27 15:11:36 +0000

    ethernet: Prefer memcmp() over bcmp()
    
    The link-level address and the mbuf shall not overlap. Prefer memcmp()
    over bcmp() for slight performance gain.
    
    No functional change intended.
    
    Reviewed by:    glebius
    MFC after:      2 weeks
    Differential Revision:  https://reviews.freebsd.org/D52345
    
    (cherry picked from commit 51098f0529f0d1cc532512e0eae9bfcffb8e68e4)
---
 sys/net/if_ethersubr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/net/if_ethersubr.c b/sys/net/if_ethersubr.c
index b0e459dd1bdf..d33d8f682521 100644
--- a/sys/net/if_ethersubr.c
+++ b/sys/net/if_ethersubr.c
@@ -712,7 +712,7 @@ ether_input_internal(struct ifnet *ifp, struct mbuf *m)
 		 * seen by upper protocol layers.
 		 */
 		if (!ETHER_IS_MULTICAST(eh->ether_dhost) &&
-		    bcmp(IF_LLADDR(ifp), eh->ether_dhost, ETHER_ADDR_LEN) != 0)
+		    memcmp(IF_LLADDR(ifp), eh->ether_dhost, ETHER_ADDR_LEN) != 0)
 			m->m_flags |= M_PROMISC;
 	}