From nobody Fri Sep 26 09:40:47 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cY5Db758gz681Ys; Fri, 26 Sep 2025 09:40:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cY5Db6Snxz3Dd1; Fri, 26 Sep 2025 09:40:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758879647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0Iwfu8cYmKbiNsM9fxID6jLfOVfasVcdmzQvUykKmTU=; b=PP0Ho8gyui15TCQyQOkAJVR2C4LamTPnNZKVkoAhkyCM3rWvJCA7gmmH8/HE5swgZ2CdyT not9LUcKtrnK9aiKPyDj75PTDH0sbB9hOVG+bb2AUxBKr/UBZdSnd7SvuYKaXOtDQXhDLg VSB5G4wHJk4iHM7AWD9VYwkfenltIpVIPOjyQlXkYuOwDnArIT/NrE4/mMERPy1nY2CF++ /K4iwJlMxgkXflsaN9xHyMRKVPn4yRGVb92pLSj70dREhCZa8rWGWVnsPoQ4hN/4lkeVLW oal7AGmauV1FbIuDlS8s52MMxlO7ZGurFIM1JI8aDvYtmsTbUQlz0j3MKQKQgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758879647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0Iwfu8cYmKbiNsM9fxID6jLfOVfasVcdmzQvUykKmTU=; b=lsuhzzetXiZmBKGRGKAVQ3LLKf/1207y/QjjmjZWJMgapoEz3vdK6bl4/EQO0PaVhs5o7u D+BvV6x3WRjDDj53gUaNhehyDA/YCnDide4AgEUasWE7TjRJlqZ2B20YCwaFAlf9yW3fzu flxyDAAHwWD5z8t2mXwj73zx9InN70ikm4xqqokj0RVfpgvcSi7euiNOr5zf6vGR3rM/If 1yy8wJ7uLikXDI5mVegzGv7yirAKhuFYrFrbbHzRpyWEEI2enheZz/ETSkpjSZkyWn6kYr sfweS1f9iA+Xv8JMc+/5ZufnZRN9MUfVc5I25U5mXZjz7Hyyf9P3RtzEKqe5eQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758879647; a=rsa-sha256; cv=none; b=RTkgEpq1yCdB+E2MK0LXS2FQff9ymjh2zEC7j4LAXumpRRl+/crGuKlP4P1lyRILFMhu2y UvWfvfBDKTUDjdUSG1TZicqPAVGP/DzDMWaw5AEu/z5uRTgb1W6hStZABjsNvP13lXVVzb YNf1QOblVeL3qIiBx69E2BgTHbGtMi5NugjRi0aZp24O+52PI/wfn7RYGBmkTGxM0oJv8n xclL4QWSNSwGlZmNY3kJ2iu5oRR/TamxXGIDPXtK5XtnHrEdy8gZ4kyMR42VB8tBrmTvYc TtKj7hQ9NnI44SB2weFCrHx0aQgbYZ6MWzIBrc/QEUyjUSw7OporTC/uuapy/w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cY5Db61YYzj2b; Fri, 26 Sep 2025 09:40:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58Q9elYP055026; Fri, 26 Sep 2025 09:40:47 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58Q9elXm055023; Fri, 26 Sep 2025 09:40:47 GMT (envelope-from git) Date: Fri, 26 Sep 2025 09:40:47 GMT Message-Id: <202509260940.58Q9elXm055023@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: 4010352306ef - stable/14 - tcp lro: remove redundant check List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 4010352306ef73b6d5b3c2f652dac346f035e481 Auto-Submitted: auto-generated The branch stable/14 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=4010352306ef73b6d5b3c2f652dac346f035e481 commit 4010352306ef73b6d5b3c2f652dac346f035e481 Author: Michael Tuexen AuthorDate: 2025-09-23 18:28:54 +0000 Commit: Michael Tuexen CommitDate: 2025-09-26 09:38:46 +0000 tcp lro: remove redundant check Remove a check which is also done in tcp_lro_rx_common(). Reviewed by: gallatin Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D52683 (cherry picked from commit 43bbecaeb95fe5ea1d7acffab4f2874247ba6915) --- sys/netinet/tcp_lro.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/sys/netinet/tcp_lro.c b/sys/netinet/tcp_lro.c index 10afed17bf3b..2a5839440d69 100644 --- a/sys/netinet/tcp_lro.c +++ b/sys/netinet/tcp_lro.c @@ -1428,17 +1428,6 @@ tcp_lro_rx(struct lro_ctrl *lc, struct mbuf *m, uint32_t csum) { int error; - if (((m->m_pkthdr.csum_flags & (CSUM_DATA_VALID | CSUM_PSEUDO_HDR)) != - ((CSUM_DATA_VALID | CSUM_PSEUDO_HDR))) || - (m->m_pkthdr.csum_data != 0xffff)) { - /* - * The checksum either did not have hardware offload - * or it was a bad checksum. We can't LRO such - * a packet. - */ - counter_u64_add(tcp_bad_csums, 1); - return (TCP_LRO_CANNOT); - } /* get current time */ binuptime(&lc->lro_last_queue_time); CURVNET_SET(lc->ifp->if_vnet);