From nobody Tue Sep 23 12:03:41 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cWJXt1gjCz68YPK; Tue, 23 Sep 2025 12:03:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cWJXs4ZbXz3F2J; Tue, 23 Sep 2025 12:03:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758629021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=R0ummlf0Ur3IwgrYA+SFXfq1/Jp4UFc8I5Oid7n21B8=; b=Zm/Qto/zOf57IV26FFBNrjc3kokV82O8NxxYuFIa/C+ioSMaoGHut0ZTu32MKwaEo76Tf/ zgEBVbXJa+/WhAXye/6yU/MhmspYQiP/OihOiC60fD+OsSYo/Feko5uJzQWw+xAQ+jbXRT xSVrLGJ+/sVQTZWfpcxNXwkD2xKt5WjLsZLEaq8akwJpEn9Oze8vGEieR4QacAwKscvixC yzXLq1l+JanTuNaqPCa7fgxJWtJXzPnSmWKD3B0MEmH8U4jTY1ADp/asS/GhbZfow/Nf7r ddq4mI91Tgkt8RcTAqXuNnysTv+Su/etkMBzvQezh37ijQ34u4kKb5qxp7TlXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758629021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=R0ummlf0Ur3IwgrYA+SFXfq1/Jp4UFc8I5Oid7n21B8=; b=LRRsygxumMWMFDld4Llu8ERYyiDIHJghW9Bqzkz59Kle69Oqg/E14w/SAlruB5bvCP4SGg fU7ES81MRcGVqpmWBjvj7qI4iHRR3JlGxePQGm28eSYbhjsx3/WBRFgl1U5+mLgTeDfwU+ K3s5szR/pg5nUJ/bIwcSrnwnD31LLuRGPqB2/MdX6CV19WLw1PYcY14LnyiHKUmXuMi/1X Vgsv/72w8HCxHZ1HdjsrhWV0YKS/rUKkaG00q4cjOkdYb3Dh+foUtXvBAw6M6JweuUlQsb qFlFIeqO2257mkkzVFJKomckiDLC+E3CvSs6FWwVQpTIQMRjlVVtSeV6lwzLPQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758629021; a=rsa-sha256; cv=none; b=MkE8Y1mMOoZL6OJV9O4lFLnf2pDp6D6CIf/mR5c3NFSpqSSJDWGan0qKXkBwkVGoli159e +NByEFPAWlOuxsb/dfSfrJqv3THnQkRFrCA0DVeXLMYrXsW7bpdwyqQGi9aY4/TIf9H9DI HAV2lvwPJKulXzEAHXqjZ+vYD36NcO2g8YDrCeflWjekq0XhcDvS7l9sZssl+4ZBAZdSOp OvQF/Qic9sEzR5n31LFR7in5FIpzMh7NgFe/nE2II+7gmD9s7b0X/L0ueoCcBBZwLewIx1 nmhNFOfSPh6/gkG5tpVw1NEdDMCCqXBYOcpeLKbtqs2f1lpHotu0ZzmtqoclSg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cWJXs1w3DzlfQ; Tue, 23 Sep 2025 12:03:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58NC3fli008687; Tue, 23 Sep 2025 12:03:41 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58NC3fqC008684; Tue, 23 Sep 2025 12:03:41 GMT (envelope-from git) Date: Tue, 23 Sep 2025 12:03:41 GMT Message-Id: <202509231203.58NC3fqC008684@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: fa96d3e64efc - stable/15 - linux: setgroups(): Avoid allocation under the process lock List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: fa96d3e64efc8f789524f3871bc4e68f61d3d213 Auto-Submitted: auto-generated The branch stable/15 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=fa96d3e64efc8f789524f3871bc4e68f61d3d213 commit fa96d3e64efc8f789524f3871bc4e68f61d3d213 Author: Olivier Certner AuthorDate: 2025-08-28 15:47:38 +0000 Commit: Olivier Certner CommitDate: 2025-09-23 12:02:44 +0000 linux: setgroups(): Avoid allocation under the process lock This was missed in commit 838d9858251e ("Rework the credential code to support larger values of NGROUPS (...)"). No functional change (intended). MFC after: 5 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D52278 (cherry picked from commit b7a87d7c0dd19016e82f5d33f2c5ec90479c31fe) --- sys/compat/linux/linux_misc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/compat/linux/linux_misc.c b/sys/compat/linux/linux_misc.c index fb86de6e7302..0925ffb64480 100644 --- a/sys/compat/linux/linux_misc.c +++ b/sys/compat/linux/linux_misc.c @@ -1045,8 +1045,7 @@ linux_setgroups(struct thread *td, struct linux_setgroups_args *args) crextend(newcred, ngrp); p = td->td_proc; PROC_LOCK(p); - oldcred = p->p_ucred; - crcopy(newcred, oldcred); + oldcred = crcopysafe(p, newcred); if ((error = priv_check_cred(oldcred, PRIV_CRED_SETGROUPS)) != 0) { PROC_UNLOCK(p);