From nobody Thu Sep 04 20:01:02 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cHr2Q2LVvz66gCT; Thu, 04 Sep 2025 20:01:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cHr2Q1Mw0z3Y25; Thu, 04 Sep 2025 20:01:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757016062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yUhc3aC9eQIMR8aRAzD+gqn77w1ltbkaxd63EjsSoNg=; b=rShcErWgpEiqftmzMshjPHhRSilkNvB3NVxhXjjkb3JksM5zjdxFzrbAni9258ffxF2ElZ h+Na/A8USaTV2t6A/gnS9VwKirkYxJK+Mmad5kpyZl1ZRgOzJfNl1s88JGunZppYNtgocN RQO0t7J1cow2HenAa95fHa2xNmYkPi4S5exy9D6dhAIbSNcgz+iQO30+SxfBcv7Z7GHs2o 7gqjaqSPL6xCfESG0+79E5nuvVZX+9eJbz3V/INkeBmw+s4pXdMuN248NauPC/LWTE3LzM NPkBCMvSr0hHkUHZpeLcSzwGeb7KiqNXlIDJ3e7W3289YRXpgzY9GYDFg05Wrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757016062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yUhc3aC9eQIMR8aRAzD+gqn77w1ltbkaxd63EjsSoNg=; b=CAV1ANIb89ynOFjYkF5YPsUaN/+L+hqvwEGsjZx6269xAfkEUv+jH3/8CgGYKevGDCksgY 6EquvKaUfdm6N7rx8WkXhMf96Hkjj2+A9MuKPjOjpvDieDf+z9dsEyCjdpp5grneb9TPx2 gtriOkTS/f86FsMIaUCx+dadQE7DobjPldn9u5TvOuJ+proYFDebXz5NnTZdnZhtHU0zKF yeS5j7dVSDzS6Xlh1dely2NqBilVpzUZeTBOExBnZMKqu8b64HkDAFL7vWzAtXsQ1Gi+Cn hizwJMGMYoSrTpG3p2YmHG3U7ax0qsZlURtU9idDhOQQn46+9ycJsQMIehhoMA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1757016062; a=rsa-sha256; cv=none; b=ayT1qvAxdKwcMi2uZ5EZs4W+GSRint/zzBGo0liX2ldXsJeYX7NORI9IDpQKBHH8TpOemu 87BBCU3laInrY0vIeqIbDfr7FNX9Hq8owJHc5J2Sg4+UuACitwS8sW+ujApWA79C/HCifm GvKaasHDGwkEHE/u3uzSfqdf0ZWOIkGRKJLfBv5EODQKFVgyVV81NtCrjP8sExglo0rsdC zAxF23ygF8A3tp3ripgOtBMpMEpl3JizgZ4T0zQydBXfd4hNHuclEcaW11irGL7Egq4GBX Gs5ucPeStkMm82JtdxX63aKyzSQSlFNNCvZYtj3SxOjozkf5K/c56IS0MMkigw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cHr2Q0jxbz1x8; Thu, 04 Sep 2025 20:01:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 584K12HS039107; Thu, 4 Sep 2025 20:01:02 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 584K12ab039104; Thu, 4 Sep 2025 20:01:02 GMT (envelope-from git) Date: Thu, 4 Sep 2025 20:01:02 GMT Message-Id: <202509042001.584K12ab039104@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: 6e95753ac517 - stable/14 - ddb: add show all tcpcbs List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 6e95753ac51716aec45cef049e1493d3c96874b1 Auto-Submitted: auto-generated The branch stable/14 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=6e95753ac51716aec45cef049e1493d3c96874b1 commit 6e95753ac51716aec45cef049e1493d3c96874b1 Author: Michael Tuexen AuthorDate: 2025-05-28 10:25:26 +0000 Commit: Michael Tuexen CommitDate: 2025-09-04 20:00:15 +0000 ddb: add show all tcpcbs Add a command to show all TCP control blocks. Also provide an option to limit the output to TCP control blocks, which are locked. The plan is to run show all tcpcbs/l when syzkaller triggers a panic. If a TCP control block is affected, it is most likely locked and therefore the command shows the information of the affected TCP control block. Reviewed by: markj, thj Tested by: thj Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D50516 (cherry picked from commit f1430567f26bc84db3818914fa91c74507d1602a) --- share/man/man4/ddb.4 | 10 +++++++++- sys/netinet/tcp_usrreq.c | 23 +++++++++++++++++++++++ 2 files changed, 32 insertions(+), 1 deletion(-) diff --git a/share/man/man4/ddb.4 b/share/man/man4/ddb.4 index 0bab4dc3e61b..cb14f42da489 100644 --- a/share/man/man4/ddb.4 +++ b/share/man/man4/ddb.4 @@ -24,7 +24,7 @@ .\" any improvements or extensions that they make and grant Carnegie Mellon .\" the rights to redistribute these changes. .\" -.Dd May 24, 2025 +.Dd May 28, 2025 .Dt DDB 4 .Os .Sh NAME @@ -580,6 +580,14 @@ The modifier will print command line arguments for each process. .\" .Pp +.It Ic show Cm all tcpcbs Ns Op Li / Ns Cm l +Show the same output as "show tcpcb" does, but for all +TCP control blocks within the system. +Using the +.Cm l +modifier will limit the output to TCP control blocks, which are locked. +.\" +.Pp .It Ic show Cm all trace .It Ic alltrace Show a stack trace for every thread in the system. diff --git a/sys/netinet/tcp_usrreq.c b/sys/netinet/tcp_usrreq.c index 7bad828c4821..e0e921ebc42e 100644 --- a/sys/netinet/tcp_usrreq.c +++ b/sys/netinet/tcp_usrreq.c @@ -3255,4 +3255,27 @@ DB_SHOW_COMMAND(tcpcb, db_show_tcpcb) db_print_tcpcb(tp, "tcpcb", 0); } + +DB_SHOW_ALL_COMMAND(tcpcbs, db_show_all_tcpcbs) +{ + VNET_ITERATOR_DECL(vnet_iter); + struct inpcb *inp; + bool only_locked; + + only_locked = strchr(modif, 'l') != NULL; + VNET_FOREACH(vnet_iter) { + CURVNET_SET(vnet_iter); + CK_LIST_FOREACH(inp, &V_tcbinfo.ipi_listhead, inp_list) { + if (only_locked && + inp->inp_lock.rw_lock == RW_UNLOCKED) + continue; + db_print_tcpcb(intotcpcb(inp), "tcpcb", 0); + if (db_pager_quit) + break; + } + CURVNET_RESTORE(); + if (db_pager_quit) + break; + } +} #endif