From nobody Sun Oct 26 03:14:59 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cvMFc6ZPsz6Dn0p; Sun, 26 Oct 2025 03:15:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cvMFc372vz3QjV; Sun, 26 Oct 2025 03:15:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761448500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=F9R+DSoyeYOnO7VQsZt1+agIv1HsWGohsUiCZKvtJKU=; b=ToqI38BxL4LYXA4snyyv1vJZTreSjaNW/TUgfBPfVywtMzmZOxqQfed7fsbP3ZPvoJ/P9A ncCVG8ws3tUl5+D8E3LVFDHOs1eTZ221VBne7xhwELAir6C3kPPjBgXvutkZqxp32/7P26 zFBAIYZ1JCRK5y1D8+9Mdy4lhhhWcvsV5m2i2brIo0CdWbE52X/DFFPymFcaPibrzHzlyD 0/uljq0NvHZiZg0G5Xo+tzpLDXYpZ2qLJPkJECkxteCmNuPW2xq3Q133UB3X2JNUz+BSRg +A7y0PkYs/CxQIK3IbxJciKLokj3pPhO42QbvDefXkhFCdcIoXe7Ns3HX1/ezQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761448500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=F9R+DSoyeYOnO7VQsZt1+agIv1HsWGohsUiCZKvtJKU=; b=TCANq7hAVYulH8d6yyiV0kH76CdAtKMqJ/G5LEATzYm4xPx6Isnf4AcFXRphkKOLHNq5dC v8ASHZXO7fwq9oJlqV4Gj7neuZcks1Moc98+1FRX+lavQqAVqmsjWugYcdTxqsfIlT7cCl bSCPU/Z8DoZ1JP0KIfm30bRGT5AW/zMt9GnSmoKtGGOtXh8Qdm0IBnJkvQNAn2gY2M626m Grok3R1zoApol73xrEMXMQJvWPSpUTCgrCuVuM+TDb8TS5e2SQQx6G1hhZSaoKAN0SAoAU 0p93kYz7a/lQfSU5tmQiwu4BDGXPLmiUJK69VbRy5162+saGLEfju2DILiEkaw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1761448500; a=rsa-sha256; cv=none; b=fpcq/mwpKsJfs1R+ldZvE6v+0DCdj0CmWc4X8pqtMw6RdZZBD5hZkPxoQ3Iep/mA8zsDX6 sw1J/fYa6BvsU1BgKsLqOHZjDxhs2y78r2oRgxCoMIXB+eKDYHSVvaukRJfcl7vo2e6Su/ 7TMUbWIjKYcDLox27keSknuqsyB4f+lbTIRJSfCPmXAWX82qVwgYKQtFYvD/3irW6WwUoT Zxbd3rzM/7axxA6puetSJcleZvPUweydE9bJTquWhAP1+ptO3SjsTHNvL1eUfFnzph/c5C 6eAt+B3KYi6eegvwzmwCMo3zoin7JWpxg+V8+b/q74dw+T5oRFZ+PhdIqyqUIQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cvMFc0M1fz13j; Sun, 26 Oct 2025 03:15:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59Q3Ex6n063678; Sun, 26 Oct 2025 03:14:59 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59Q3ExUd063675; Sun, 26 Oct 2025 03:14:59 GMT (envelope-from git) Date: Sun, 26 Oct 2025 03:14:59 GMT Message-Id: <202510260314.59Q3ExUd063675@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Cy Schubert Subject: git: e190f21c98ae - stable/14 - ipfilter: Plug ip_htable kernel information leak List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: e190f21c98aeee4e284147eb43f8d446d585c0db Auto-Submitted: auto-generated The branch stable/14 has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=e190f21c98aeee4e284147eb43f8d446d585c0db commit e190f21c98aeee4e284147eb43f8d446d585c0db Author: Cy Schubert AuthorDate: 2025-10-22 16:29:03 +0000 Commit: Cy Schubert CommitDate: 2025-10-26 03:14:51 +0000 ipfilter: Plug ip_htable kernel information leak ipf_htable_stats_get() constructs an iphtstat_t on the stack and only initializes select fields before copying the entire structure to userland. The trailing padding array iphs_pad[16] is never initialized, so ~128 bytes of uninitialized kernel stack memory can be leaked to user space on each call. This is a classic information disclosure vulnerability that can reveal pointers and other sensitive data. We fix this by zeroing out the data structure prior to use. Reported by: Ilja Van Sprundel Reviewed by: emaste Differential revision: https://reviews.freebsd.org/D53275 (cherry picked from commit 0d589ecbc7aa916537fd21c0344919491cfcb293) --- sys/netpfil/ipfilter/netinet/ip_htable.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/netpfil/ipfilter/netinet/ip_htable.c b/sys/netpfil/ipfilter/netinet/ip_htable.c index 1907aa0f9f5f..be5b71d9f6d4 100644 --- a/sys/netpfil/ipfilter/netinet/ip_htable.c +++ b/sys/netpfil/ipfilter/netinet/ip_htable.c @@ -233,6 +233,8 @@ ipf_htable_stats_get(ipf_main_softc_t *softc, void *arg, iplookupop_t *op) return (EINVAL); } + bzero(&stats, sizeof(stats)); + stats.iphs_tables = softh->ipf_htables[op->iplo_unit + 1]; stats.iphs_numtables = softh->ipf_nhtables[op->iplo_unit + 1]; stats.iphs_numnodes = softh->ipf_nhtnodes[op->iplo_unit + 1];