From nobody Sun Oct 26 02:36:33 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cvLPF2gdTz6DjFN; Sun, 26 Oct 2025 02:36:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cvLPF1zFYz3KmQ; Sun, 26 Oct 2025 02:36:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761446193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iTa5e7NqoyIYixYUGJDi4CX8gGbFiKrDfqFtpnYOTpw=; b=a0k5S88wpMMlFkxkI3kdDYTpMp+Ai19buUSOWG6Py45iApXSjUS7TDw9kXtl0FyoE+t1Z5 a93K37nH0OW82z+snz8cnBhTTOv+iMzl08IAOl9KRIFWSfNxK0x2Pc2Y67i3SkgSDX0z+/ q8okJLP8icEsBZbYdi4ulY/1Uns1lEttrXLaQVxV0lQzLbW2ttrvs2JlpA+iSm2H2LsuGK 9Hf5Arm+pXSQuEmqG84VKP6djjU0/fC6c3eUoaayIRYLNnRoVsVAIXwShcjQNyCIDpCPtu Aq4iVKd9wA35NVBCR8mlfwEf535IzGai6oOWSGulX0AE9cI4bAHut6i8J7fveg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761446193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iTa5e7NqoyIYixYUGJDi4CX8gGbFiKrDfqFtpnYOTpw=; b=RVbh/3VS/zyiiK4855Gqqecz4MaSuKQqEx/w14RQocOIWWUHc+sc8hQngXRztpnDuiAAw7 UpLnvr8RBSFoOMiGyZz6khB4bYbaBMy/Ivs1sCE7Wttbr1Z60g8SJR7fxWhVSOu51tt4Nj CJWEzeGXdoZhZ0jfj0VKegU2zgB9NZGl1/3AggyognqbTuoqK7a4cEn0+Csdbl0olpJPBV ZjRcTzCvnab6GeI2RWxoJDz1RxhPb8fr/b7k59LQ9iZL/LMA6J7XLO98btvmwZodLIQsvG 9h/kpIFVuwSxK2syjGjV/2juI0p9YbaqKU1uThkgc556nRExiK31RkkW3xPfbQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1761446193; a=rsa-sha256; cv=none; b=AsYDLSI9TzRb89oOVfxfV9+nqvZJ/L2+m4S8tsQTGlVNrr0RU5TlrgPpQ8FY7TAr7vPkOI YdTTAaaoJYflSs0aURFfeZFHWaO7YI/BxHmDQdKeFkQxJYTBtK1cvifUHg+MUl74LiJQVO Ma/enZucoPewnN1HpMY6EPL3R/V8ijRd7xPOfA8ZPm1IWrx1fpNdZTA+jNZr6KDGdBj/5u XZaunVOwGq1Fnbx/RXR8zHMwK8grAxk8UqUB5GyMP28KtXiPz7ZEoME1tVocYEzsLNcno3 sv41SscZkA5SgaR4bB9Sl+BByYbgGdeNu/Y9vd3lU1i4QyI9R3fSLEYzI5wMTg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cvLPF1PlKz1Cqs; Sun, 26 Oct 2025 02:36:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59Q2aXT3087251; Sun, 26 Oct 2025 02:36:33 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59Q2aXY0087248; Sun, 26 Oct 2025 02:36:33 GMT (envelope-from git) Date: Sun, 26 Oct 2025 02:36:33 GMT Message-Id: <202510260236.59Q2aXY0087248@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Lexi Winter Subject: git: 7ffd190ae9c8 - stable/15 - inet_net_test: Use int to hold expected return values from inet_net_pton List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ivy X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 7ffd190ae9c82e4359d8a6f6ae2d1b82e8eb6453 Auto-Submitted: auto-generated The branch stable/15 has been updated by ivy: URL: https://cgit.FreeBSD.org/src/commit/?id=7ffd190ae9c82e4359d8a6f6ae2d1b82e8eb6453 commit 7ffd190ae9c82e4359d8a6f6ae2d1b82e8eb6453 Author: John Baldwin AuthorDate: 2025-10-20 18:31:41 +0000 Commit: Lexi Winter CommitDate: 2025-10-26 02:29:57 +0000 inet_net_test: Use int to hold expected return values from inet_net_pton GCC warns about the sign mismatch in comparisons: lib/libc/tests/net/inet_net_test.cc: In member function 'virtual void {anonymous}::atfu_tc_inet_net_inet4::body() const': lib/libc/tests/net/inet_net_test.cc:86:17: error: comparison of integer expressions of different signedness: 'int' and 'const unsigned int' [-Werror=sign-compare] 86 | ATF_REQUIRE_EQ(bits, addr.bits); | ^~~~~~~~~~~~~~ lib/libc/tests/net/inet_net_test.cc: In member function 'virtual void {anonymous}::atfu_tc_inet_net_inet6::body() const': lib/libc/tests/net/inet_net_test.cc:205:17: error: comparison of integer expressions of different signedness: 'int' and 'const unsigned int' [-Werror=sign-compare] 205 | ATF_REQUIRE_EQ(bits, addr.bits); | ^~~~~~~~~~~~~~ Fixes: 8f4a0d2f7b96 ("libc: Import OpenBSD's inet_net_{ntop,pton}") (cherry picked from commit e1aeb58cbbc3839db93ec38ce491b7b9383d5649) --- lib/libc/tests/net/inet_net_test.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/libc/tests/net/inet_net_test.cc b/lib/libc/tests/net/inet_net_test.cc index 4ecf5a3de492..c4411373165e 100644 --- a/lib/libc/tests/net/inet_net_test.cc +++ b/lib/libc/tests/net/inet_net_test.cc @@ -50,7 +50,7 @@ ATF_TEST_CASE_BODY(inet_net_inet4) struct test_addr { std::string input; - unsigned bits; + int bits; std::string output; }; @@ -134,7 +134,7 @@ ATF_TEST_CASE_BODY(inet_net_inet6) struct test_addr { std::string input; - unsigned bits; + int bits; std::string output; };