From nobody Tue Oct 14 14:16:18 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cmGVC0Vqrz6CWKk; Tue, 14 Oct 2025 14:16:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cmGVB516xz3XGL; Tue, 14 Oct 2025 14:16:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760451378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9ld+KEh5dOk95GHS0IwWB6Ix76Yofh4XUoIAIr1KFVw=; b=qz70R6YEfRAi5vNfprIj3GoLGYcl45S/Rq41WMgOqYGJSiF0MY12XKHfD25dfKR8pL2RsC hGwd0RubZ4eWkxthV4bBB/bMf9igoQux8RK6webpsuYe1R4QSENIVSibh1rdohf8tcSFll DQCHFrtI1AkCZ8OC2chFchuOqjQ5gRga4HIkn1URRh+QpiN5atv6zk2mvxwFCgDnIIdkEd SFDaGRtI508PbK+tgmS5iF9gELh9+a+cGTv8DVGZicKl6Rs3DQJ6APC7+Fi7YKjeLXiSn+ 5xztUIoRjG8gdjr+rmCLUg88erBcds8vEMmwxjTTm7I/9ZafAOM0mV6wuFq05g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760451378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9ld+KEh5dOk95GHS0IwWB6Ix76Yofh4XUoIAIr1KFVw=; b=Uc7QW9/VibuNJiAZwfZISFiZ4g4vXWOfe7AZZ/LkXJDlpYsSofjTOCSuo2TsabqhhAKgqM vBxra6hMPvJY4qQQWyg2KNDeEvEeYMfs34nZVq0MFc9cv/km2eZvDTky73kgb+rZfuwBMq XmWNwZHAfy55/UA3ObLWUCLhekxLHG14VHMyFLnifZHX/92Kpsjrp9Mo4kMPbHTNYqAne7 pQCYCwW4GTX9yYz6JOjiJJyPFrYo+1ciTYPzYT8w9tXvIN6Gl1wK5xzAE9hbnt5uXINmrt U/j6yNnS3FeGl3QVAke5obpEGQhL2SKjXuAuhocfueNMuFZJ9xu8s5RsTmaS8g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1760451378; a=rsa-sha256; cv=none; b=v8tPxJ9b+Wgr7nWvm4aYWxG/unv0qrwYfYnEFe5T29c+akVbeSd9P+u3XPnUxYPqNl+2qd rEtpf3umYZGoxPO4vsdh/SlMNoY8Ik29Yqx7ZLSuaTbdV3dDsBH+Xk4St3TM+txntYNkpc esVH6kFVKK8UfzagEOhPkPSVBhAr8yoxsXVkBK+h7i0beDqavdvmFOoTmACx2Oh/S6zP5c bpByO2vxUIuILJhlHqF3eRr6bGsItUeD6ejTkiUNN5htcTFQypJ2EwEEChYVZl3Oqbosn7 f+haRBOefS3Om/ybeG/xh/d8X4s6FzsKHrXP0fn/mjTgNHnSUWHEaGnNVxtOcw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cmGVB4cPGzwPM; Tue, 14 Oct 2025 14:16:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59EEGIrw028256; Tue, 14 Oct 2025 14:16:18 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59EEGIYX028253; Tue, 14 Oct 2025 14:16:18 GMT (envelope-from git) Date: Tue, 14 Oct 2025 14:16:18 GMT Message-Id: <202510141416.59EEGIYX028253@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org, dev-commits-src-branches@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ahmad Khalifa Subject: git: 583e976d6d09 - stable/15 - libm: remainder: make sure x is zero List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 583e976d6d09770a6299a19603d4f0dbaa562cac Auto-Submitted: auto-generated The branch stable/15 has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=583e976d6d09770a6299a19603d4f0dbaa562cac commit 583e976d6d09770a6299a19603d4f0dbaa562cac Author: Ahmad Khalifa AuthorDate: 2025-10-10 09:30:52 +0000 Commit: Ahmad Khalifa CommitDate: 2025-10-14 13:42:31 +0000 libm: remainder: make sure x is zero Make sure the entirety of x is zero before flipping the sign bit. Otherwise the sign would be wrong for small values of x when x is negative and |n*y| > |x| Reported by: alfredo PR: 251091 Reviewed by: kargl MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D53023 (cherry picked from commit 25cca51ed294890d20a3c0290814cd26875db686) --- lib/msun/src/e_remainder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/msun/src/e_remainder.c b/lib/msun/src/e_remainder.c index a5fb7141d01a..cc6cd320073e 100644 --- a/lib/msun/src/e_remainder.c +++ b/lib/msun/src/e_remainder.c @@ -64,8 +64,8 @@ remainder(double x, double p) if(x>=p_half) x -= p; } } - GET_HIGH_WORD(hx,x); - if ((hx&0x7fffffff)==0) hx = 0; + EXTRACT_WORDS(hx, lx, x); + if (((hx&0x7fffffff)|lx) == 0) hx = 0; SET_HIGH_WORD(x,hx^sx); return x; }