From nobody Tue Nov 18 00:52:10 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d9R0C00r6z6HH0l; Tue, 18 Nov 2025 00:52:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d9R0B5qJqz3yj0; Tue, 18 Nov 2025 00:52:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763427130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=140Pp7kS0bmz0YO2dhWwrdAR09JQ8QxigaE7raFgSR8=; b=jCb2AwB06R+L51tvTSenrEJNESIrv3ZQfCEhb4trRgYedWO+rESIfK/F/Eo4tj6u3jP9X1 xqnm6ss72+B2qte8m+jC6Aajhhs8QtyR5LLKT47u5Jvo/1pjIQ370wnCJmUtt/yj0tAQII dLNNFu4QfIXz0c1cas82CaO6BAk4JH38UoGrIDhazJWN/JYtmLrqpLksTXKEfO0nWUcsv5 I9umhRLMcNbXo9lW7GYWMPQ7Eh44N3/5P6wDx5OKSbAYyuXhxTtwzCoctByb8hpjEo/SxA lN71IPny6TY0ZHisHjgQXVFLpvs4yfD2TJGmNZCY6KVrVF8lweEIariN3IyOWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763427130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=140Pp7kS0bmz0YO2dhWwrdAR09JQ8QxigaE7raFgSR8=; b=GtX/DVxMlmKbuV0DJ4hG6GCpPEI6VkYSOafoghyPhw8d47zwf7WyRxm04O0+60CKqswC/+ 6VxwRa1hHITsGD9Y4B88vWW4jZ00MSa4tLMsTk7iuqYg4DD8oseFy7Y9aSZad0/Cs72ddC WL0YSYY4hqe0RHaLbP4Wi6NrFm6wYjD3A9ovzc8tDkKusR3bjtzI1++35Nx8xP1gcw6bHa qji1mTlHRfoZV2oRXgKpGBmAfUMNKwrSNusL+8h8q1YsSoedev2nQHvpDXMAZk9CLg9PwK xVXEtTrL0coWxDWXmnTpdnx+tXeh+XJ0kop4esG3q6uNmbtY3k5exKCrD75ZtQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1763427130; a=rsa-sha256; cv=none; b=yEgK6vRR4Kse9zx0GSEosmXjLuUbo6JFZuO23bcwDB822i+nP5OmHKopjL29YHVqbmnFA8 7OHtPc7soZpSGfgvBXKeP62EmX5tFeBZTUGquZY2W9u/0aF6xW/RQze+oLflYKDRKnsvED 57G0X4x/jrzvJegMEv57KHCfv5XxgVfuh7ili0nzvb2JiBtRMwpfqpXX4Q/3W7WkqIePLQ PeW2uJclRmkeQvVXl7G1Px9NjTi9JZz4lFVyiXcsT5RqAmJ3hsxBQFD5Bjjhm+2vUgRqs+ shtr2najBjSRSoZJnnjhgH4lt7Vts9e5AY6IEE6iYKda2Q4rDnZnHfLoHCpAWg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4d9R0B5R6DzY9V; Tue, 18 Nov 2025 00:52:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5AI0qAqU046815; Tue, 18 Nov 2025 00:52:10 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5AI0qAOm046812; Tue, 18 Nov 2025 00:52:10 GMT (envelope-from git) Date: Tue, 18 Nov 2025 00:52:10 GMT Message-Id: <202511180052.5AI0qAOm046812@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Christos Margiolis Subject: git: ad348a08586f - stable/15 - sound: Remove unnecessary initializations in feeder_create() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: ad348a08586f9244a363a7cb9098a395c772e448 Auto-Submitted: auto-generated The branch stable/15 has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=ad348a08586f9244a363a7cb9098a395c772e448 commit ad348a08586f9244a363a7cb9098a395c772e448 Author: Christos Margiolis AuthorDate: 2025-11-11 12:06:32 +0000 Commit: Christos Margiolis CommitDate: 2025-11-18 00:51:24 +0000 sound: Remove unnecessary initializations in feeder_create() We do not need to zero out fields since the struct is allocated with M_ZERO. Also we no longer need to have a special case for the root feeder. Sponsored by: The FreeBSD Foundation MFC after: 1 week Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D53558 (cherry picked from commit 699fd108c50ccbd576476a2c95fa03e16492f2f9) --- sys/dev/sound/pcm/feeder.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/sys/dev/sound/pcm/feeder.c b/sys/dev/sound/pcm/feeder.c index 874148cd9ab0..75c0f0405040 100644 --- a/sys/dev/sound/pcm/feeder.c +++ b/sys/dev/sound/pcm/feeder.c @@ -88,19 +88,10 @@ feeder_create(struct feeder_class *fc, struct pcm_feederdesc *desc) if (f == NULL) return NULL; - f->data = NULL; - f->source = NULL; - f->parent = NULL; f->class = fc; f->desc = &(f->desc_static); - - if (desc) { + if (desc != NULL) *(f->desc) = *desc; - } else { - f->class->type = FEEDER_ROOT; - f->desc->in = 0; - f->desc->out = 0; - } err = FEEDER_INIT(f); if (err) {