From nobody Fri Nov 14 14:27:22 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d7KGf25f7z6GWCr; Fri, 14 Nov 2025 14:27:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d7KGf1cqYz3QQs; Fri, 14 Nov 2025 14:27:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763130442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FxZ8OzUDm3zcD9BpK7krw21wduUu90iiRisg2zR2GhA=; b=v5NNWTTIzPiJFDRn+6GtOxJ6lrznTLVXZsfkVQArRBGVFSfr7ohKckXeG4rMQHce8iigNm nga4ya5Bk5eOf1kqeNJslpSUJKik/6HxQV2QS42aJCx/4D6zhJ+EIZtxgwIeripiRSiL6H RRHlJAkn+/LoPhfMJpJn/qrercf50hdFJqzEFk7BHPUmZfmM5JhNgwfmS7Tu58HQ4uOKOo eHthub940jMi/yQa4cUlCrtd10SnIm0RVIQ604gqd8RsPUX69KlwB3VhXNmFI4HlZzNpHv 5FOYTktRZw8gKK3PFPsgvNu/Mxu/JaNr1sdoAA0RPaS1Axuj9yRc8ZGIOp/9DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763130442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FxZ8OzUDm3zcD9BpK7krw21wduUu90iiRisg2zR2GhA=; b=WHBGm77+FTdP2vTdyW0Bi6gA/5GZRd7dtHevF9qEIsv0kbCP+vJvZrzYtKRn0TVLK+L4eD UwGKeL5YeIbSSYbClJShziC3jJ2wb5xWUasbafCcN+17inpCtPL1snEJyfv0Q4b6htmAQl 8iL9dJl5fWRmWZ3EW8aNsvsEc9FbD5yguYpqwutJ1khqpNFl38YkeqcQqjSr1kgDxdjNod xnGsFj3+2xlaDloZW5wjUDMY4pZQoR7vfX/ih02QdcnuIwPohXpuuBHDa8uqYLP8SEEega mfTtHD3n+i1FoHoF+NcaoNt9rDPgf058zSNH6qxkBL7+163ZAids2Q8hWI2adQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1763130442; a=rsa-sha256; cv=none; b=HndQGhiI2rgqmFhje7yUcK7Gsyi96L6vpmDjvkq7QaBdKCXRgUa0xX9uS6eF/j7w0He2Mn /i/dsUK4RMtqOfQ82Q7IkACVJta11t7AtU4i0TIwHVFIthMa+HF6DFNwnZmuAAfOghitkU Ki7/QaSPiJpMnEgWhPKbY2boV3GUu7rfgFsNgAfub+g5lVmlJuzUtsgjoUCLH2Vc+mBSfF uY3fXrOxZockymlnK+WvtLwsjGBmNe/tUPJfUYEAjPMtK0fH+pcut2oQh1Q8B6C10X4BYs XUjD+4tqwUR/9xZ44mKeMxwMiGwWmJMNmFZfSpyxTo6ZpmY7OZ49McRZ1mPXVw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4d7KGf19tZz18Y7; Fri, 14 Nov 2025 14:27:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5AEERMAG038404; Fri, 14 Nov 2025 14:27:22 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5AEERM5Y038402; Fri, 14 Nov 2025 14:27:22 GMT (envelope-from git) Date: Fri, 14 Nov 2025 14:27:22 GMT Message-Id: <202511141427.5AEERM5Y038402@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mateusz Piotrowski <0mp@FreeBSD.org> Subject: git: 3078279c3336 - stable/14 - dtrace_io.4: Use bio_length instead of bio_bcount in examples List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: 0mp X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 3078279c33369c81b5391410936572b70715fcd8 Auto-Submitted: auto-generated The branch stable/14 has been updated by 0mp: URL: https://cgit.FreeBSD.org/src/commit/?id=3078279c33369c81b5391410936572b70715fcd8 commit 3078279c33369c81b5391410936572b70715fcd8 Author: Mateusz Piotrowski <0mp@FreeBSD.org> AuthorDate: 2025-10-26 16:52:11 +0000 Commit: Mateusz Piotrowski <0mp@FreeBSD.org> CommitDate: 2025-11-14 14:27:17 +0000 dtrace_io.4: Use bio_length instead of bio_bcount in examples Tracing bio_bcount makes little sense for some devices like for example md(4), as it is set to "0" instead of to the actual I/O length. markj@ suggested the following DTrace one-liner to identify some cases where bio_length is set but bio_bcount is not: dtrace -n 'io:::start /args[0]->bio_length != args[0]->bio_bcount/{printf("%d %d", args[0]->bio_length, args[0]->bio_bcount); stack();}' For future reference in the context of bio_length vs bio_bcount, phk@ mentioned in the code review that: > the original intent was to get rid of of bio_bcount Reviewed by: markj MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D53365 (cherry picked from commit db25448ab9ffa8bfe52d852674cc466494b849d1) --- share/man/man4/dtrace_io.4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/share/man/man4/dtrace_io.4 b/share/man/man4/dtrace_io.4 index 30ec44768fbf..1699cebab8e9 100644 --- a/share/man/man4/dtrace_io.4 +++ b/share/man/man4/dtrace_io.4 @@ -22,7 +22,7 @@ .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" SUCH DAMAGE. .\" -.Dd April 18, 2015 +.Dd October 26, 2025 .Dt DTRACE_IO 4 .Os .Sh NAME @@ -84,7 +84,7 @@ The following script shows a per-process breakdown of total I/O by disk device: io:::start { - @[args[1]->device_name, execname, pid] = sum(args[0]->bio_bcount); + @[args[1]->device_name, execname, pid] = sum(args[0]->bio_length); } END