From nobody Wed Nov 12 23:30:05 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d6KPn75Y9z6Gmlf; Wed, 12 Nov 2025 23:30:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d6KPn6SWBz4Pm9; Wed, 12 Nov 2025 23:30:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762990205; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BBu2Cg7KXfEMwDWxalYl9yfpBJYXUTr4G3eWi57t6ao=; b=bvC8l5Vr+1NTUizvhjnLH/PSoSYvWiDgPPL8RIULQMesjLtuSTA78rORQrRQxVZCsWdhl+ 1TEl1wwLY1TONT3wrdT4A69MDEnuwi10yInY/FVWT63ky+zyC4qkqyxlieIFGQ84WzUWFv 5wAmDypfEksa1LbmFElJ0Ry1cpVSFCwcXqHCeXrKXQlB+TmmQVB6dBe0c2SjXOvHCoLqO3 DNWYgyk4UV4oa+JakXq4tBC993zlcHMxG8KTsc2NbBdXpb//2AN8zed9oCokh010LX6LCl f/Xsq3YFWzxyWWN8SuW3MnwoheNFxEe5xQfcWJSKUpdstJ4Gew6X6q5kK2utvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762990205; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BBu2Cg7KXfEMwDWxalYl9yfpBJYXUTr4G3eWi57t6ao=; b=CJCM+sY/gxC5MKFwpLJ4KnWKAMTwW2Wt2v90fGN7FeHoQqIlRVMUR9v22ma2x9TlhbfhLX tIGEwmfqpz14SBp4XtIo7bEZaaCHWX+no1A2z3fQEj8ExkZLj1caemUxlEb6Z5jwc+vyHY VBxyfyiW31m+8r5nGzKioMDDnQ/zClBEnPdGx6qCQEYJq6SKDQbRissM143h0HO9nOMAA4 LeTCyrzi+yXCrMRSzyvHgTeRJLAz3pZBZuxRDqQKVcItGYslmwtLa59IrTFNUKnhdRVAt5 9zLMHk0fxEoYe4ZIGaJjkTnQ4H5LdE/Ey79LmAYdRV9mUta3p2LmlhI+DK0vBw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1762990205; a=rsa-sha256; cv=none; b=FlsPv9MPjNR1Pvh/zf1JnQLru3AChmhMh/+iVz/G/yqx4o2RRAQDv8I8o2nFJ9hUdmli/K wPQZ5ON0i9EaAuJa6WzWircSKoyhU5P1tywrIymDwFjIaB3vPPrg4FZhvEF8oMwUc9zGGB QtHP79F2WR+t+1+kY23nobhFsSaSnaZQSS+r0JkvfsPd03yJZ5e42AkH5cPmAzrOpfRtAb SJHC+/C8j6VnC5bLhewZkBnfud2JnHvinP1zKbn4X/ea4C2764kk2uMzWyP/nhUgNU15Io KgXBigljtJtqunHmHIf4dEk49Vd3Stdm3SaWkpkjvQsDIWu3exbdhKHY/Zp4GQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4d6KPn4mwMzvpV; Wed, 12 Nov 2025 23:30:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5ACNU5Ke033787; Wed, 12 Nov 2025 23:30:05 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5ACNU52T033783; Wed, 12 Nov 2025 23:30:05 GMT (envelope-from git) Date: Wed, 12 Nov 2025 23:30:05 GMT Message-Id: <202511122330.5ACNU52T033783@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kristof Provost Subject: git: ac562a719ba0 - stable/15 - libpfctl: fix error handling List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: ac562a719ba0b3fe83d1c86387b8b0c23c147aaf Auto-Submitted: auto-generated The branch stable/15 has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=ac562a719ba0b3fe83d1c86387b8b0c23c147aaf commit ac562a719ba0b3fe83d1c86387b8b0c23c147aaf Author: Kristof Provost AuthorDate: 2025-11-03 13:55:44 +0000 Commit: Kristof Provost CommitDate: 2025-11-12 23:29:36 +0000 libpfctl: fix error handling In two cases we returned E2BIG where it should have been a boolean ('false'). MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit 9bb1c46b4c38c44565fc24f13acdc19b0cb5a1c4) --- lib/libpfctl/libpfctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/libpfctl/libpfctl.c b/lib/libpfctl/libpfctl.c index fbf9796d9887..8dea373d8941 100644 --- a/lib/libpfctl/libpfctl.c +++ b/lib/libpfctl/libpfctl.c @@ -1484,7 +1484,7 @@ snl_attr_get_pf_rule_labels(struct snl_state *ss, struct nlattr *nla, bool ret; if (l->i >= PF_RULE_MAX_LABEL_COUNT) - return (E2BIG); + return (false); ret = snl_attr_copy_string(ss, nla, (void *)PF_RULE_LABEL_SIZE, l->labels[l->i]); @@ -1554,7 +1554,7 @@ snl_attr_get_pf_timeout(struct snl_state *ss, struct nlattr *nla, bool ret; if (t->i >= PFTM_MAX) - return (E2BIG); + return (false); ret = snl_attr_get_uint32(ss, nla, NULL, &t->timeouts[t->i]); if (ret)