From nobody Wed Nov 12 08:40:02 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d5xfp4QYjz6Gf58; Wed, 12 Nov 2025 08:40:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d5xfp3Sv3z3CcY; Wed, 12 Nov 2025 08:40:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762936802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TK68nlb/WJOq2q5wdw+2JzXNDQRf2kYgAlOlXvrXr1o=; b=wuntbTk/bkkpwCktp0QGmX0J6VVFFMicyfgjhHR8Q2rYvShfum8uqV1kaA9O49sYocRWyt Ymtsf3wYaRsKuTpnNRB1MpoIbUjPf/TjjLiJu6FAl43D0t52i+MLRFU+K1xea0dVxByRjs Ps+zRbKvbE9/ASgF2EVKTaZytthaMKxEMf/v/SfOamb1lSXh4Q3bJOQ8XxPjIjKZs4Qeq8 z7yMfjd8aTm4MBm4oJJGxVUpnzj7OHy5LYsWZR/w9uk1aXv1N1A8iZZ3tMLOqCgVI4l8h3 WxIYYN2Vrv3FmewTq6UTXd3JAqrYFb7XN/O11IUCTfGGdZ4IB7/PB9Zc+ktvOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762936802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TK68nlb/WJOq2q5wdw+2JzXNDQRf2kYgAlOlXvrXr1o=; b=rLpM8I/Vn/hwaCcL3FFfC7F5DeudpM8oHLplSWk6gEiZje7/aODP9vK3CiX9ThzOo257Cu YY+/uSvRvS3UoWYhFaBR+01jiZGi8Cs3QmvFsw5Z55Znlq1oeSFUyaVwlut2PhEIo8f4D9 9Ps8CX4wqfdccJl/MuSu9sDvvSNKiE9xvQH4sberIx5/I0vUAw5rZbcjnEUE6dN4B9g0rt mW46515Om3tgBlRfaPqVH8+SnJhijAabqMdd/ME5/RRPmKSDeae2F8+Y68iZ1lHsueKZSl 2k6GN4cffY/HZmEh80nAQRDPSmne0R6zJLTAEGhoGkcGzQoJBgNQaGt6mPraIw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1762936802; a=rsa-sha256; cv=none; b=FZfuk+x/aF1l2Mp6BXjBquMto6hN6qBKK6xcFatN/NOkmA1muu3woD5gX8MpfovC0aaEYi LMPx8dpbschjdTX3vAxUxGtbfnOPUe12wiA0cSanJWU3FhlSZU7fIO+P10I1dHBFSekurp pbWcZD8x/wzF3vtifm3xadN2ER0CeeSgASALYdH6FaBmy2dKZKCpASo35FT+Y43iaICuGF nzu38oCAgGv+bAZzI54xd6I0euAPFrZ1uLkcLyCN1v/dgi2Ml658mYgINdjwP6uDF2kniM d38uysI1vCxPVQiihXzWqpu2PXBCMrbeCmqDNx+G2c88tFQ8KZyDTIV/3b31Lw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4d5xfp2klwz9ld; Wed, 12 Nov 2025 08:40:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5AC8e2Qv049585; Wed, 12 Nov 2025 08:40:02 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5AC8e2Mm049581; Wed, 12 Nov 2025 08:40:02 GMT (envelope-from git) Date: Wed, 12 Nov 2025 08:40:02 GMT Message-Id: <202511120840.5AC8e2Mm049581@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: 52df18d91b83 - stable/14 - vtnet: fix enabling/disabling tso List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 52df18d91b83038d870c595799a47d983d7da645 Auto-Submitted: auto-generated The branch stable/14 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=52df18d91b83038d870c595799a47d983d7da645 commit 52df18d91b83038d870c595799a47d983d7da645 Author: Michael Tuexen AuthorDate: 2025-11-10 15:34:53 +0000 Commit: Michael Tuexen CommitDate: 2025-11-12 08:39:01 +0000 vtnet: fix enabling/disabling tso Transmit segment offloading depends on transmit checksum offloading. Enforce that constraint. This also fixes a bug, since if_hwassist bits are from the CSUM_ space, not from the IFCAP_ space. PR: 290773 Reviewed by: Timo Völker Tested by: lg@efficientip.com Differential Revision: https://reviews.freebsd.org/D53629 (cherry picked from commit 4c50ac68166caf7e08c5a9984d63fa91490fa50d) --- sys/dev/virtio/network/if_vtnet.c | 28 ++++++++++++++++++++++++---- 1 file changed, 24 insertions(+), 4 deletions(-) diff --git a/sys/dev/virtio/network/if_vtnet.c b/sys/dev/virtio/network/if_vtnet.c index 8c08a81820e7..643353190966 100644 --- a/sys/dev/virtio/network/if_vtnet.c +++ b/sys/dev/virtio/network/if_vtnet.c @@ -1344,20 +1344,40 @@ vtnet_ioctl_ifcap(struct vtnet_softc *sc, struct ifreq *ifr) VTNET_CORE_LOCK_ASSERT(sc); if (mask & IFCAP_TXCSUM) { + if (if_getcapenable(ifp) & IFCAP_TXCSUM && + if_getcapenable(ifp) & IFCAP_TSO4) { + /* Disable tso4, because txcsum will be disabled. */ + if_setcapenablebit(ifp, 0, IFCAP_TSO4); + if_sethwassistbits(ifp, 0, CSUM_IP_TSO); + mask &= ~IFCAP_TSO4; + } if_togglecapenable(ifp, IFCAP_TXCSUM); if_togglehwassist(ifp, VTNET_CSUM_OFFLOAD); } if (mask & IFCAP_TXCSUM_IPV6) { + if (if_getcapenable(ifp) & IFCAP_TXCSUM_IPV6 && + if_getcapenable(ifp) & IFCAP_TSO6) { + /* Disable tso6, because txcsum6 will be disabled. */ + if_setcapenablebit(ifp, 0, IFCAP_TSO6); + if_sethwassistbits(ifp, 0, CSUM_IP6_TSO); + mask &= ~IFCAP_TSO6; + } if_togglecapenable(ifp, IFCAP_TXCSUM_IPV6); if_togglehwassist(ifp, VTNET_CSUM_OFFLOAD_IPV6); } if (mask & IFCAP_TSO4) { - if_togglecapenable(ifp, IFCAP_TSO4); - if_togglehwassist(ifp, IFCAP_TSO4); + if (if_getcapenable(ifp) & (IFCAP_TXCSUM | IFCAP_TSO4)) { + /* tso4 can only be enabled, if txcsum is enabled. */ + if_togglecapenable(ifp, IFCAP_TSO4); + if_togglehwassist(ifp, CSUM_IP_TSO); + } } if (mask & IFCAP_TSO6) { - if_togglecapenable(ifp, IFCAP_TSO6); - if_togglehwassist(ifp, IFCAP_TSO6); + if (if_getcapenable(ifp) & (IFCAP_TXCSUM_IPV6 | IFCAP_TSO6)) { + /* tso6 can only be enabled, if txcsum6 is enabled. */ + if_togglecapenable(ifp, IFCAP_TSO6); + if_togglehwassist(ifp, CSUM_IP6_TSO); + } } if (mask & (IFCAP_RXCSUM | IFCAP_RXCSUM_IPV6 | IFCAP_LRO)) {