From nobody Mon Nov 10 19:57:25 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d50nK2z1Dz63Ln2; Mon, 10 Nov 2025 19:57:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d50nK2MGjz3bn9; Mon, 10 Nov 2025 19:57:25 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762804645; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=T9OrA9Br0DmvXZX9LQv/TR+duY6arMhKgwwqVHzc5EM=; b=BjCqneCkMalKC0FrC//vcnt59RvF7gfSY6TdOaKKAF1RE8mMvvCQ4wa9aehPfvG0Dvr/CV p7X2juLmFu039PzvuZM0xnoJccDeiUpMu/IW8H9e8JmQzWxAvadJY4TPVW+ic9sHFrsxNN JZiWHGCYujVvkzOvLfoWYKVDIJ1Hzzpb4RqjWOJruTHiFLDIbyAqZN+7R316OZC4GOkLzy +o/HqHjVsIHApHRzBxEwiNtEmGMVK866OgRz8kp4NWVYKeoh52M24lqyfFBKCgHpdlkrI2 uHwu5KDFk4WGwT1aWXy+3HV7YNruW8ddsr578mcoC50TLNI91UwkvTDpeyd7/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762804645; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=T9OrA9Br0DmvXZX9LQv/TR+duY6arMhKgwwqVHzc5EM=; b=bLiUCWu5w2yX/4Q/MWUUXpqUCqzuEoN0nMUDbNDQEmdcImSySTmBqBi9kDMN09+eb2I5ut TaqT+RTcWaTBma7Rf3+V4ZEGY3q9u01S9vlBW06MLu6TUhj3QIBnz26+/5FNuv488cjfkz +SEfkqvT5sGhpLL+gn2h6+fHHMkc3K903VAw35oxK9YoQeCP0UOZ/ZEeGyX/4CgeV0aGYv Jg8+9zN2kM17EPQySIlu2xHlh+hg6WDCfVUKSoY0ZwsGGIQ1oUfI//d8a/cB6WnaNsBMva gwebqsU813HA9gwPyi/TsWn9rGvXkYsAE80CO0ZozVR+nace7bL0N98y+WpLzg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1762804645; a=rsa-sha256; cv=none; b=APgz71aWJc8jEKU+XxR1AY0tOLt7ureTN8RffqAoKWpSchg3cMYwMz1OA9hXLgEOFApgmY lIxP2coL+eehfdOChppxnR56UUVGqAHA6Ar6MzZoH005wo4qXcJNpDA2K0oEH6D3ZjdlLb KtRpdDe3FJs+EjfpIiveykwm04zxdTdnC1YsBc6C4c0DOmkRohGPG9ESHWkp9wlfzY8FiU Ys+0G6+xPukx0ct0wzsci4hX5ObEDTwgnxFO7pJap/WcdPY+HcS0dSCFWautcVUHjZVEG2 VaRvLlKIG+nCWi5rUSBCvrkOxSSrLSLIIPVGCMiHPJpj7gUuRmZGjA6juCaPJw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4d50nK1k2HzY5B; Mon, 10 Nov 2025 19:57:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5AAJvPkd009044; Mon, 10 Nov 2025 19:57:25 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5AAJvPj7009041; Mon, 10 Nov 2025 19:57:25 GMT (envelope-from git) Date: Mon, 10 Nov 2025 19:57:25 GMT Message-Id: <202511101957.5AAJvPj7009041@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: 7cd81bf4e74f - stable/14 - tcp: improve comments in the syncache code List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 7cd81bf4e74f39b784f97afe1a5c4a251f1fd39f Auto-Submitted: auto-generated The branch stable/14 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=7cd81bf4e74f39b784f97afe1a5c4a251f1fd39f commit 7cd81bf4e74f39b784f97afe1a5c4a251f1fd39f Author: Michael Tuexen AuthorDate: 2025-11-07 15:27:56 +0000 Commit: Michael Tuexen CommitDate: 2025-11-10 19:56:59 +0000 tcp: improve comments in the syncache code Add a comment explaining why syncache entries are dropped and fix a typo in a comment. Reviewed by: rrs, glebius Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D53564 (cherry picked from commit 17fb082104ee281365b72bd5135604cea5051df2) --- sys/netinet/tcp_syncache.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/sys/netinet/tcp_syncache.c b/sys/netinet/tcp_syncache.c index 376a5d958504..41195fa02a4e 100644 --- a/sys/netinet/tcp_syncache.c +++ b/sys/netinet/tcp_syncache.c @@ -543,6 +543,10 @@ syncache_timer(void *xsch) TCPSTAT_INC(tcps_sndtotal); TCPSTAT_INC(tcps_sc_retransmitted); } else { + /* + * Most likely we are memory constrained, so free + * resources. + */ syncache_drop(sc, sch); TCPSTAT_INC(tcps_sc_dropped); } @@ -742,7 +746,7 @@ syncache_unreach(struct in_conninfo *inc, tcp_seq th_seq, uint16_t port) goto done; /* - * If we've rertransmitted 3 times and this is our second error, + * If we've retransmitted 3 times and this is our second error, * we remove the entry. Otherwise, we allow it to continue on. * This prevents us from incorrectly nuking an entry during a * spurious network outage. @@ -1569,6 +1573,10 @@ syncache_add(struct in_conninfo *inc, struct tcpopt *to, struct tcphdr *th, TCPSTAT_INC(tcps_sndacks); TCPSTAT_INC(tcps_sndtotal); } else { + /* + * Most likely we are memory constrained, so free + * resources. + */ syncache_drop(sc, sch); TCPSTAT_INC(tcps_sc_dropped); } @@ -1754,6 +1762,9 @@ syncache_add(struct in_conninfo *inc, struct tcpopt *to, struct tcphdr *th, TCPSTAT_INC(tcps_sndacks); TCPSTAT_INC(tcps_sndtotal); } else { + /* + * Most likely we are memory constrained, so free resources. + */ if (sc != &scs) syncache_free(sc); TCPSTAT_INC(tcps_sc_dropped);