From nobody Sat Nov 08 02:55:53 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d3LCZ13n0z6FM3m; Sat, 08 Nov 2025 02:55:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d3LCZ0Kshz3wjx; Sat, 08 Nov 2025 02:55:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762570554; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BANCTWTGlx46ws1A3ZsNm2j9oD0sZGyqjR8IEPfYb6o=; b=AQOKK5S3eAz2VOUgH+Ugtg0RUCEi7Pzi6Ff8Ek6bGEjypw7VjRZU9UzsBghsy2B/Cz/HN2 vl9Vug5pfEBSwqyIbExIDFk7h+p/tHKSBZwF9dM+spOiY5Bvjkrz6qr7CIl+aOEnHS/LDr cS/p5vn2g62WEYmSTLHVBYfqxR+LtJoGX/WgR/cxMk3aAP50ue9OeMqw4KBsq7u+cdrwnt 2qRx/86vFQuhbZeNjzTqdm6itt8YGQsXoLmdpV+XbmC7TvqwA6QVHWTkL8musAqEE8UF0/ GSSYQvycKB9PXh1vPuNXYUSX8gBvzkohY9prlZM89mcmMND7zDcY7JrPUl5gBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762570554; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BANCTWTGlx46ws1A3ZsNm2j9oD0sZGyqjR8IEPfYb6o=; b=RCX84d2uG26fZJcQrvCRixvCIg1EZajtYAp0tYf35jHc7Wrvhr201b4KIZjEkmHfpjMncS Eo0Yudym9CwBbrQ8cNJmfj0xRZbo9KQaEoxDIWUA4OEPOs98zrSyJ9KbNCGdZh2VIa+A77 xLcIElHFmkTPkanHNuDWH2ZVuwH6qVkbtyh6qKf9bSxxFu/sa9WuHfJgclPW8/0FfFF7oc N8xccXNh8aHpxLcEaWzlPlejpbIFTIc0OpA3FG0wb1a6lXmLeZJNwWONpTj7SBId9H57Fl Z7FdVqsI1Hf14RI3QovlX1qz4wkG/2ZmmLS7yB+U/h66KaE+SfICi/7dIbszxw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1762570554; a=rsa-sha256; cv=none; b=SyGbpBC0yNREnTLcVcDSZF9VvBY1hfrLjKHpTSfKqEssSpL6kn2UuJrf20w0G6e7Ym3uWJ 5zd92tstmB6Dv/Xc9e2XGLtINQBoVKyvH5sK5xOx8BjMoHGPXkoJJLOVbYMTMEKg3pqsqg GRjdA+kCIc0djuAgv0qnerBEybmc5yvj/RhSHJB2JCPfs0HIzgLQ4GJhEPmuyqzYJHO7rU EYWqTzAeOcCVLwto+HFj+rTYUgi5fM14qVQeB8BCjw/oDMSteBV/W8et/8H+psRXpQt07g ravNcSOG4euiGBkEr4luRCmfoZ8djwQO/nGGeq+0O1nWIjszRs1h+TYa77SKCg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4d3LCY6gWXzBvF; Sat, 08 Nov 2025 02:55:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5A82trKe043621; Sat, 8 Nov 2025 02:55:53 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5A82trdO043618; Sat, 8 Nov 2025 02:55:53 GMT (envelope-from git) Date: Sat, 8 Nov 2025 02:55:53 GMT Message-Id: <202511080255.5A82trdO043618@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: "David E. O'Brien" Subject: git: e224f2c1b98b - stable/15 - random: Have RANDOM_PURE_START be a cross-platform source List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: obrien X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: e224f2c1b98ba065942c83d322cdb8e3987d0c81 Auto-Submitted: auto-generated The branch stable/15 has been updated by obrien: URL: https://cgit.FreeBSD.org/src/commit/?id=e224f2c1b98ba065942c83d322cdb8e3987d0c81 commit e224f2c1b98ba065942c83d322cdb8e3987d0c81 Author: David E. O'Brien AuthorDate: 2025-11-08 02:18:13 +0000 Commit: David E. O'Brien CommitDate: 2025-11-08 02:19:13 +0000 random: Have RANDOM_PURE_START be a cross-platform source and one that will be with us in the long-term future. (this helps reduce diffs in the future and for down-stream users that trim entropy sources). Also, move deprecated (removed in 16.0) sources to the bottom of the list to reduce changes to 15.x. Reviewed by: glebius Obtained from: Juniper Networks Differential Revision: https://reviews.freebsd.org/D53311 (cherry picked from commit 9f3886347c1750cf80a82314470fc7186088eb9a) --- sys/dev/random/fenestrasX/fx_pool.c | 20 ++++++++++---------- sys/dev/random/random_harvestq.c | 8 ++++---- sys/sys/random.h | 8 ++++---- 3 files changed, 18 insertions(+), 18 deletions(-) diff --git a/sys/dev/random/fenestrasX/fx_pool.c b/sys/dev/random/fenestrasX/fx_pool.c index 3aefe17a045a..35d06c2a9df1 100644 --- a/sys/dev/random/fenestrasX/fx_pool.c +++ b/sys/dev/random/fenestrasX/fx_pool.c @@ -167,13 +167,7 @@ static const struct fxrng_ent_char { [RANDOM_RANDOMDEV] = { .entc_cls = &fxrng_lo_push, }, - [RANDOM_PURE_SAFE] = { - .entc_cls = &fxrng_hi_push, - }, - [RANDOM_PURE_GLXSB] = { - .entc_cls = &fxrng_hi_push, - }, - [RANDOM_PURE_HIFN] = { + [RANDOM_PURE_TPM] = { .entc_cls = &fxrng_hi_push, }, [RANDOM_PURE_RDRAND] = { @@ -200,9 +194,6 @@ static const struct fxrng_ent_char { [RANDOM_PURE_DARN] = { .entc_cls = &fxrng_hi_pull, }, - [RANDOM_PURE_TPM] = { - .entc_cls = &fxrng_hi_push, - }, [RANDOM_PURE_VMGENID] = { .entc_cls = &fxrng_hi_push, }, @@ -215,6 +206,15 @@ static const struct fxrng_ent_char { [RANDOM_PURE_ARM_TRNG] = { .entc_cls = &fxrng_hi_pull, }, + [RANDOM_PURE_SAFE] = { + .entc_cls = &fxrng_hi_push, + }, + [RANDOM_PURE_GLXSB] = { + .entc_cls = &fxrng_hi_push, + }, + [RANDOM_PURE_HIFN] = { + .entc_cls = &fxrng_hi_push, + }, }; CTASSERT(nitems(fxrng_ent_char) == ENTROPYSOURCE); diff --git a/sys/dev/random/random_harvestq.c b/sys/dev/random/random_harvestq.c index f2206044fe7d..0e90b4d6ef9b 100644 --- a/sys/dev/random/random_harvestq.c +++ b/sys/dev/random/random_harvestq.c @@ -662,9 +662,7 @@ static const char *random_source_descr[/*ENTROPYSOURCE*/] = { [RANDOM_UMA] = "UMA", [RANDOM_CALLOUT] = "CALLOUT", [RANDOM_RANDOMDEV] = "RANDOMDEV", /* ENVIRONMENTAL_END */ - [RANDOM_PURE_SAFE] = "PURE_SAFE", /* PURE_START */ - [RANDOM_PURE_GLXSB] = "PURE_GLXSB", - [RANDOM_PURE_HIFN] = "PURE_HIFN", + [RANDOM_PURE_TPM] = "PURE_TPM", /* PURE_START */ [RANDOM_PURE_RDRAND] = "PURE_RDRAND", [RANDOM_PURE_RDSEED] = "PURE_RDSEED", [RANDOM_PURE_NEHEMIAH] = "PURE_NEHEMIAH", @@ -673,11 +671,13 @@ static const char *random_source_descr[/*ENTROPYSOURCE*/] = { [RANDOM_PURE_BROADCOM] = "PURE_BROADCOM", [RANDOM_PURE_CCP] = "PURE_CCP", [RANDOM_PURE_DARN] = "PURE_DARN", - [RANDOM_PURE_TPM] = "PURE_TPM", [RANDOM_PURE_VMGENID] = "PURE_VMGENID", [RANDOM_PURE_QUALCOMM] = "PURE_QUALCOMM", [RANDOM_PURE_ARMV8] = "PURE_ARMV8", [RANDOM_PURE_ARM_TRNG] = "PURE_ARM_TRNG", + [RANDOM_PURE_SAFE] = "PURE_SAFE", + [RANDOM_PURE_GLXSB] = "PURE_GLXSB", + [RANDOM_PURE_HIFN] = "PURE_HIFN", /* "ENTROPYSOURCE" */ }; CTASSERT(nitems(random_source_descr) == ENTROPYSOURCE); diff --git a/sys/sys/random.h b/sys/sys/random.h index af6b1e117423..64f2a1e1b40c 100644 --- a/sys/sys/random.h +++ b/sys/sys/random.h @@ -89,9 +89,7 @@ enum random_entropy_source { RANDOM_ENVIRONMENTAL_END = RANDOM_RANDOMDEV, /* Fast hardware random-number sources from here on. */ RANDOM_PURE_START, - RANDOM_PURE_SAFE = RANDOM_PURE_START, - RANDOM_PURE_GLXSB, - RANDOM_PURE_HIFN, + RANDOM_PURE_TPM = RANDOM_PURE_START, RANDOM_PURE_RDRAND, RANDOM_PURE_RDSEED, RANDOM_PURE_NEHEMIAH, @@ -100,11 +98,13 @@ enum random_entropy_source { RANDOM_PURE_BROADCOM, RANDOM_PURE_CCP, RANDOM_PURE_DARN, - RANDOM_PURE_TPM, RANDOM_PURE_VMGENID, RANDOM_PURE_QUALCOMM, RANDOM_PURE_ARMV8, RANDOM_PURE_ARM_TRNG, + RANDOM_PURE_SAFE, + RANDOM_PURE_GLXSB, + RANDOM_PURE_HIFN, ENTROPYSOURCE }; _Static_assert(ENTROPYSOURCE <= 32,