From nobody Thu Nov 06 23:11:50 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d2dHW29GJz6FtNf; Thu, 06 Nov 2025 23:11:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d2dHW0YMDz3gf2; Thu, 06 Nov 2025 23:11:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762470711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6ytsFrtLGRgKDVRNiF1u/qDM6PD14uCdGIRAFrabuic=; b=oh33BMIrt5D3J+KyqjyVquL57IIEWa85g6+kJtPr1Xr1gHzgCgFbkeKnjYHZ5gBMk3FblU kTNNk1jdeKxP5QWhbHXJe1gNG5WeraiqIpqpg7+tw0LklDgRGBmG+MGevsT/aNzzp50N21 dPRWZVC6GuKe+BUB7MrJGhn242x3omhGj9fCCGw8mWWaR1ZPl3U8BqN+vwL3sv+SJM5ZwU mKqKEtk6fdsaYX3vaiZfgShMJQ1+fi6Pbq3CGQjezOe6qDTxKE5KdUefHB76i49TDxYRdb 46OR0GCIK9rDAr2ELPFRFpL1WQM/LdM7BupEWWp4pusQWkWSVYKG63VAjsLjqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762470711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6ytsFrtLGRgKDVRNiF1u/qDM6PD14uCdGIRAFrabuic=; b=bkPXkONAkI29PmIrdsu33WA1bxrf8YVVq4Uc9C/vJdteIOlQYgWaa6RqE0pAhFaNyLFC+v c6WBqKQyghWuj2J6qm5hyuV45CDX3vIPVauuYzCXFOm+vWUYEew+6sSIG0sm5kZjQsjnqT SsMVqKiw9m+KHEdR8JMdDUxi7aofuFGXgLCH20KeTl7kP7OMe/BGmAovRunVSikydaF8LU ax4HedHP3PTMoqsgQ/Bec7UP/Z/zXCpJJ66g1EDAednhqLSYqF+sQzw8wgZ8egGdPxt2pg 0eRzWuhWSDey4KY9T1Xw50bVcRS+JCFDnjxK59IACpjhNEvAlQJU5reRfRo67g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1762470711; a=rsa-sha256; cv=none; b=uccW+MahFbMnOoo/9+3dbIaCr8Pzv0wKXMM7v2Cyj9hV2iay1nFCJ5niUEjgMAd7rpyTeP vfvpkAsyanq1q8PQohTbAbuwrkDaOhLyvniImeBuwAgq90IhdfOhAiv2o0SrmWuB7XurQj QemSuvLQl61AnlQFwZ26PhA7Ykt2dRNeiWjrQ51iOWMMOge6J/SiFtBFi9l4km3hFuucV8 YgSvcZ8w3RInOuyRAo17r7in9tmShthz6qS8DTNKhrEeTckRMVReNo7TlUzN4a6spimQoI VZ7E6RRP5688nEcIdoQ1VRIJqqV3K2ymcyRb/lZUc+hMbVa0Rj2+40gSyAAAMw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4d2dHW07X3zZjC; Thu, 06 Nov 2025 23:11:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5A6NBoDq010367; Thu, 6 Nov 2025 23:11:50 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5A6NBoBi010364; Thu, 6 Nov 2025 23:11:50 GMT (envelope-from git) Date: Thu, 6 Nov 2025 23:11:50 GMT Message-Id: <202511062311.5A6NBoBi010364@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Colin Percival Subject: git: 914064cf193b - releng/15.0 - fusefs: fix intermittency in the BadServer.ShortWrite test List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/releng/15.0 X-Git-Reftype: branch X-Git-Commit: 914064cf193bb696734b7e5a08e8a7e594c33507 Auto-Submitted: auto-generated The branch releng/15.0 has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=914064cf193bb696734b7e5a08e8a7e594c33507 commit 914064cf193bb696734b7e5a08e8a7e594c33507 Author: Alan Somers AuthorDate: 2025-10-14 02:18:48 +0000 Commit: Colin Percival CommitDate: 2025-11-06 23:10:55 +0000 fusefs: fix intermittency in the BadServer.ShortWrite test This test implicitly depended on the order in which two threads completed. If the test thread finished first, the test would pass. But if the mock file system thread did, it would attempt to read from an unmounted file system, and fail. As a result, the test would randomly fail once out of every several thousand executions. Fix it by telling the mock file system's event loop to exit without attempting to read any more events. Approved by: re (cperciva) Reported by: Siva Mahadevan MFC after: 1 week Reviewed by: Siva Mahadevan Differential Revision: https://reviews.freebsd.org/D53080 (cherry picked from commit d1bd541b385d49d2ae3a8bad9df72779b606e208) (cherry picked from commit a1c3537148a59f6a1c86ebcb686b2e2c8e404b5f) --- tests/sys/fs/fusefs/bad_server.cc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/sys/fs/fusefs/bad_server.cc b/tests/sys/fs/fusefs/bad_server.cc index af2ca146e431..c3d195735446 100644 --- a/tests/sys/fs/fusefs/bad_server.cc +++ b/tests/sys/fs/fusefs/bad_server.cc @@ -65,6 +65,11 @@ TEST_F(BadServer, ShortWrite) out.header.unique = 0; // Asynchronous notification out.expected_errno = EINVAL; m_mock->write_response(out); + /* + * Tell the event loop to quit. The kernel has already disconnected us + * because of the short write. + */ + m_mock->m_quit = true; } /*