From nobody Wed Mar 26 21:35:25 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZNKp61LFLz5rF80; Wed, 26 Mar 2025 21:35:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZNKp56V2tz47Hv; Wed, 26 Mar 2025 21:35:25 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743024925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zb7LUGEH6XXwsALydCZf24nca79LF8wiWoMVJzOznZE=; b=ujM93lJVhQ5IFvhRE7C3w7bZeT8xrqNVSndy4HGPfxrMeqm7zSrH6i8E6d+koAH67xRPa+ NlPJZNLwlGbL80G7QLZjAtH0D9lQt10L8DMPKT2kvfjxZGHSge45Ar5MrSrqWitqv9pevS ehxlgjW86yKCQA9J/FCXwqB/HGgftDnuSHG9ObZDD8YH9Va61a1OtFvXRc6XmjH4UQcm7k S0XhEn0Rhb8ryjDMQjO8jlSym6HkS8znA8vg+MJXU/Srwn1aWqKhuug45uznLTv9HSuFjJ EB+YmXK0J53UC9tvBhfEDlKa5K/p1kEeMmAMyTrxL+q1m05mVlAHWhnQpi6srQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1743024925; a=rsa-sha256; cv=none; b=o8rZcEvixZAarux70TfIZNKooDiRLLhlv17HwbN1i8Xk5yvI/CdVImRpxgM0BmQ10G8Mwd Z3BB3eeTbnr4B4p5763pPVSncxp7p0hq+Gb3osUF4if0pNylutxvVINkpL2qBIFnINh49I DtCpI5V0NVHTSofBbJ9PHOPiziXimIwhHDPq7vsf7IqRHZ21e00sZcuxPircTPHnegUidL cGv7cpXuUla7XlCjSIeJZE8jC6xc70wImIZ+TQr82n3WzbKs8Whyd72ESXLHDk90xz969p qYW/WJItth5XwZ8iCoy8zjBzLwsCpsSefQNCwfw2ct5EYoMsV49He/CPesK1NA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743024925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zb7LUGEH6XXwsALydCZf24nca79LF8wiWoMVJzOznZE=; b=j5FowQbomJusv6A1+dPYjHRAxJCOjZ+nU/zmCqzBSCqKxnmcjbRHrXX3L0KCzqK/ayR4uj PaS1nGk+HkLdt+WO4R6Bwn2CJlvd+hvkqcdylbZctnE7fC26a7dU2ge5t/sIiZvexJazhr /UB2ZN9B0TV95DLHb943zX0/zNe0eALyrrM/7+je6OgHNLDeuIkqZCpWf+AlbYoDIQgvB2 R4aBzihpCCVDhc5sMidsA3ZFCrF0dTgFc5EiSQ2ghDDy3bfaxVcsCAp3givQ4hsnDrKRdH X2iUzdC5wMNz66gfdixgiF+oQOKz4SgXFu73YYqcCIFE1z//BWK16bRIogtiyg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZNKp55tSszCdT; Wed, 26 Mar 2025 21:35:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 52QLZPMs008364; Wed, 26 Mar 2025 21:35:25 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 52QLZPSw008361; Wed, 26 Mar 2025 21:35:25 GMT (envelope-from git) Date: Wed, 26 Mar 2025 21:35:25 GMT Message-Id: <202503262135.52QLZPSw008361@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Enji Cooper Subject: git: d6552ebf26bc - stable/14 - mca_log: add missing breaks when handling thresholds List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ngie X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: d6552ebf26bc5bb605c65fd05deb4301574f396b Auto-Submitted: auto-generated The branch stable/14 has been updated by ngie: URL: https://cgit.FreeBSD.org/src/commit/?id=d6552ebf26bc5bb605c65fd05deb4301574f396b commit d6552ebf26bc5bb605c65fd05deb4301574f396b Author: Enji Cooper AuthorDate: 2025-01-29 21:24:53 +0000 Commit: Enji Cooper CommitDate: 2025-03-26 21:27:24 +0000 mca_log: add missing breaks when handling thresholds Per the "Intel® 64 and IA-32 Architectures Software Developer’s Manual Combined Volumes: Vol. 3B 17-7", the Green and Yellow threshold indicators are mutually exclusive. Add the missing `break` statements so they're treated that way. MFC after: 1 week Reported by: Coverity Differential Revision: https://reviews.freebsd.org/D48722 (cherry picked from commit 36d7d2044b934103ad9254cd03ea61245c16ccda) --- sys/x86/x86/mca.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/x86/x86/mca.c b/sys/x86/x86/mca.c index b293fcedbd84..4ba49469d3a2 100644 --- a/sys/x86/x86/mca.c +++ b/sys/x86/x86/mca.c @@ -453,8 +453,10 @@ mca_log(const struct mca_record *rec) switch ((rec->mr_status & MC_STATUS_TES_STATUS) >> 53) { case 0x1: printf("(Green) "); + break; case 0x2: printf("(Yellow) "); + break; } } }