From nobody Wed Mar 26 21:31:41 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZNKjn1xjXz5rDjj; Wed, 26 Mar 2025 21:31:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZNKjn1QjLz458D; Wed, 26 Mar 2025 21:31:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743024701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HoMimVY0HQcy3g9UYyduhQxxYYYWIsf097fdchjilGE=; b=f5JDu67Zmdw7ei8cNYvlmgE4ILrkg4zF7yYI0CyXxY+CrcccuVaA8HmO8FIe7RuAPj/ox0 hxvikn3Pwdt01qE5bfuagwbccOH4S0DWaiaKLOKaFtnTUujkH5iYWCap5DkYhVkZ3TYD5C +BVKvNgoDPKWTKmzdS4eABT5fQAmCbW3F66CsEFnmGk3qAjYUDAbJlTXjNEC+DdhtjS2D6 Pz2+0a0E3RhrnI0zcOZ2KdfEWsIEbhnWoDsMAOgmKKQZMNuZa3IA3mgMiw/UucDy+NLKuK sIgoDghsU3DKiQ7MPEEHhl5GzxII2Wke22yDoUv+uFGpXmlkJ/RxOUkilz2/BQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1743024701; a=rsa-sha256; cv=none; b=tZFlxJiW1qCw/TYlMeRZBiVEEhmSqXYw8ROymN72ZXprHnjovbNq2f4q9G8pcwPj3MLe4K 2J+crOW2lCBfglxX/M6xMFgvNECuhgcS42CnAcscWWKSh7X2wHpowoMGtCG+GvcNkJSSIP DNwpVPyTJbiWtbp8toWVwrKGGVXFXAHLmYQ2ygnJzAJPiimv3YEwXbpHfZ1XTIQMJmEEnJ n4Zs3zAjjHmlXUCOYsKt/f1g7vFFGu9q6Jp/m9f9kiKaEjUIizNvLjHsgmMG1NYq7KpgW/ qeHmco9+02jknnso60dLNyznjYAkFVa6Xup5wTQp/WsYpw/rTFP6AjUJlDWZCQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743024701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HoMimVY0HQcy3g9UYyduhQxxYYYWIsf097fdchjilGE=; b=yZPWMzDBN+2ad9JxmO17JUvrJ4IoG8YAQuqPwQZ0vgNF7EyDL0tIIQQdIux/1+ep9T8LGS 4cDB1IVRJutemC6Kw47JE5FXgecybJrUV+Ylyi9Vn8QVko1s8f6kD0Zd3LTbHuYv7pCwUX RqnjxXe/ookX0b1LjyE9EGMlAJI42GoW54HwCnZyfpT+dM9GhZ0fsoKvfdpbtz6vO8rBZO zEgEgwQLkV7mXaS/v03jXgIZT16W2m+2+SkZh9++TAIX1RBUaIHa2LsjAeyFMje0Z6y/Sg 7b+nMpCE6jgGIx5TXdMbVeviVYLz+VlZmZOhRsIGsfgnxDqDpDYb21CWcW0LPw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZNKjn0tS1zCf0; Wed, 26 Mar 2025 21:31:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 52QLVfR3002640; Wed, 26 Mar 2025 21:31:41 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 52QLVftx002637; Wed, 26 Mar 2025 21:31:41 GMT (envelope-from git) Date: Wed, 26 Mar 2025 21:31:41 GMT Message-Id: <202503262131.52QLVftx002637@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Enji Cooper Subject: git: 30cfebf2f089 - stable/13 - mca_log: add missing breaks when handling thresholds List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ngie X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 30cfebf2f089466f9ee2c5fa25b0d47f868e3539 Auto-Submitted: auto-generated The branch stable/13 has been updated by ngie: URL: https://cgit.FreeBSD.org/src/commit/?id=30cfebf2f089466f9ee2c5fa25b0d47f868e3539 commit 30cfebf2f089466f9ee2c5fa25b0d47f868e3539 Author: Enji Cooper AuthorDate: 2025-01-29 21:24:53 +0000 Commit: Enji Cooper CommitDate: 2025-03-26 21:26:50 +0000 mca_log: add missing breaks when handling thresholds Per the "Intel® 64 and IA-32 Architectures Software Developer’s Manual Combined Volumes: Vol. 3B 17-7", the Green and Yellow threshold indicators are mutually exclusive. Add the missing `break` statements so they're treated that way. MFC after: 1 week Reported by: Coverity Differential Revision: https://reviews.freebsd.org/D48722 (cherry picked from commit 36d7d2044b934103ad9254cd03ea61245c16ccda) --- sys/x86/x86/mca.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/x86/x86/mca.c b/sys/x86/x86/mca.c index dca6b935e4a3..2bc8eb0cfd4c 100644 --- a/sys/x86/x86/mca.c +++ b/sys/x86/x86/mca.c @@ -453,8 +453,10 @@ mca_log(const struct mca_record *rec) switch ((rec->mr_status & MC_STATUS_TES_STATUS) >> 53) { case 0x1: printf("(Green) "); + break; case 0x2: printf("(Yellow) "); + break; } } }