From nobody Wed Mar 19 14:52:14 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZHsB65KJQz5rG1g; Wed, 19 Mar 2025 14:52:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZHsB64JYWz3tcf; Wed, 19 Mar 2025 14:52:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1742395934; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=m1LMXa5y+Hh0t8/qYNOHT6Dhb/vvfqmrEhnYXpS8m90=; b=ZRAoqsPPWZcx9nggMyGkEnY5z1N7QevoFC1T9V3QOoofLfV72KQWsZUUrWV735n49bi4be 8AyGnlnlykHllWRkCbpgOuJK/JJ/9Q6sz9PY2noMN9ZsApYaZqS8gAUO5uxlb5GBxV1WmI mK2spj5NkV1oxbUAZ3mmiNCuCnUEl8hLEgsaK/oJr1XPZuJEERWEFtOqxW5MtCufT8bigw BIZbcb11gk9zmCBoQOt2PYTTo/a54QxIfXbs3w5i83r39iDjy7FMWHwwTRUwQ9ymbvbX2p yDVp3Us8E6JD+cxXkVGQHIztgKGUepqI/Dx3CLtVwvrvPhqEzJTK/OExbiq9TQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1742395934; a=rsa-sha256; cv=none; b=TUEs64UBKzhsNTScYgPyHqk6VBeY29Vv55I67wfI1z6nShDoOFtK8TaJAYbo8yBFmDr56n bqQ+wU8aoU0zTTQF+JsYOHb19nBkztF8VQASnhoQkEHzTLJT2Ka//AZHqaZ7ltZ77P81xf KVTxlQ9wCio4U1R/YkqFhjxqZT5SMVPeXBwZ13t98BZI6VeB0mQU5ktkz8+bZXm9kVDX97 z9q3ZvmApOP9G4sSJYIEJdmPzY6UU5PHjnycd1qOmBgokhs58PGPNtT0/0z0aF/yMgIifI BUtKSXm1bkij4qMylljX5frW0WnU7mUVKIPkdAf8Fa7GnYRQ5osKW08j9IJj+w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1742395934; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=m1LMXa5y+Hh0t8/qYNOHT6Dhb/vvfqmrEhnYXpS8m90=; b=GgvoyAq7Bw5ossrhtHIEZiqkUU92HTnlWlwnx8OX2ksebCgUo2iYqftCgBu2Sk0eU5SMbV DUJlnlkLZYZ9GFipDfWYC37EBpr/TyAnG8dzpmXEjL8UKv8L/q4MEo/ioPQydc1DMa+9VQ ZR0wWV8U6LiLs8Y8O8N7C6Ic03dfeYUB+NXoW7NsmuOQHQQvlp2oV1T2nLMbsf+lNSdi8n EnYK/HjTl8ra7ovkkxIN6lXUxYEg33YAMOM83yKIWmLR0jGRa82rV06v7H/QSj2Zhs4JWi DJYHlbkI6ke1GI6EwDPxfngPGuaqNhNCs2d1l8ByDUWLLKxo+seDp3j9znhGOg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZHsB63vYLz87V; Wed, 19 Mar 2025 14:52:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 52JEqEZC000789; Wed, 19 Mar 2025 14:52:14 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 52JEqE7W000786; Wed, 19 Mar 2025 14:52:14 GMT (envelope-from git) Date: Wed, 19 Mar 2025 14:52:14 GMT Message-Id: <202503191452.52JEqE7W000786@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Christos Margiolis Subject: git: b61c045ff868 - stable/14 - sound: Remove redundant check in mixer_clone() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: b61c045ff868581009b740eaae047603d76da1c7 Auto-Submitted: auto-generated The branch stable/14 has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=b61c045ff868581009b740eaae047603d76da1c7 commit b61c045ff868581009b740eaae047603d76da1c7 Author: Christos Margiolis AuthorDate: 2025-03-12 21:15:34 +0000 Commit: Christos Margiolis CommitDate: 2025-03-19 14:52:08 +0000 sound: Remove redundant check in mixer_clone() PCM_REGISTERED() does this check through PCM_ALIVE(). Sponsored by: The FreeBSD Foundation MFC after: 1 week (cherry picked from commit cabf76fde8368222a68865953521e1c3668b5298) --- sys/dev/sound/pcm/mixer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/sound/pcm/mixer.c b/sys/dev/sound/pcm/mixer.c index b5b5814e667b..7bd0a2e14c46 100644 --- a/sys/dev/sound/pcm/mixer.c +++ b/sys/dev/sound/pcm/mixer.c @@ -1365,7 +1365,7 @@ mixer_clone(void *arg, bus_topo_lock(); d = devclass_get_softc(pcm_devclass, snd_unit); /* See related comment in dsp_clone(). */ - if (d != NULL && PCM_REGISTERED(d) && d->mixer_dev != NULL) { + if (PCM_REGISTERED(d) && d->mixer_dev != NULL) { *dev = d->mixer_dev; dev_ref(*dev); }