From nobody Tue Mar 04 15:47:04 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z6g6L2nlyz5qGkf; Tue, 04 Mar 2025 15:47:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z6g6J4cTrz42TJ; Tue, 04 Mar 2025 15:47:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741103224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kobJJfs8it/M/PRCXY36fcRhYlPFIXSai65KcIXp5VM=; b=JYzAthRtFSQJygiHgHUJWY7lXnXmS+6HM+rA56Eov5PSpwtyU3Ww93Db8LSzyDCdkQ63eY 3vJHWOhTy10BUaQnGUPfOJMnwfUw2GIqfcy+uVjMSZoFh7kqQ0nWt3HLq3Y+TY+bfRnm8c p0IY39cp2nsUE6TsT+Lp9zGUzH4U4zbeCE7UM3ysOyVbPaVamQlNHCviDXePjh5D7g1lAK w/8D2QSUPqgdS10eY8b/wAPgkC/AGnaURKWFgNmHTpYrbPAND6dsgAo0JkTE90Mn3aC26b zQ+MsYDwdq6YJ3GMOgp4q9AccswHzyy8Rg3Z6C5HaP04WKD26EjKFvnXg7C0Zg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741103224; a=rsa-sha256; cv=none; b=jIpDv9Ll0v+nJCxdD+CJ7sXDnyfwvSpfwywlBldOmLTwh1DCRyBtTzAdJ60FTRrBA8qIz5 Z0BhP5jbcetwsa2ADwuicpQuPkZXmt1Sl2wYykKKVjK0C+p9fZ0gPESfvfVHy5UWIDPszO 6ZZ+mbukNfRO/fhHLN0cTEwGAjNNgogk5A9f0pFgh5ruT7xMyJ3czT/+3YsQmT0PW5mviD cHKtXwwe7HRYKbQW8m4kV+oQ6fIKKEIPfQzSd5zuV6rOjA2Wk2sUw+lhI75+8FaqnQHllc YLmHn1yDBz049prhxxOTsaXd9FcVbnzCDvhHKgkzyvoseZuOYH3HXuz2UTZ8aQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741103224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kobJJfs8it/M/PRCXY36fcRhYlPFIXSai65KcIXp5VM=; b=Lj+wgzyMUr8p+NICedOBpiC2PJjYj9+JcP4EWuNJvCoc5JWzJbQ3rCAF1IalznYQnJgoGh GsCMUSeAFU5/OvEltOY/vr1Wn3YZYHOrQ3aqn6n+MYTaAwzzn3sKT5kXmHsYjPnlxxfmMe 6uYU+0zOgz0SoAjYGcDFYAhteMFjRHuJTqhJ2NoD/MWl+iYSbqE54m6VujyWcHlxCJIQXc kFAaZYK7gEZch+61AhReW/heiKk9b/4bRD1SbZehzbYeUJDfhJCU73KBrfci5G3wYTKCIN ShNhgkoyi59nL6woLjDyPESy0DGEzG3RMwMMLV/2q9BO/6K1t8rBzdVOoA6DMw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Z6g6J42Pnz8Fb; Tue, 04 Mar 2025 15:47:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 524Fl4Jn050070; Tue, 4 Mar 2025 15:47:04 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 524Fl4QW050067; Tue, 4 Mar 2025 15:47:04 GMT (envelope-from git) Date: Tue, 4 Mar 2025 15:47:04 GMT Message-Id: <202503041547.524Fl4QW050067@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Christos Margiolis Subject: git: 21e0d2aa35bf - stable/14 - sound: Return if the new speed/format is the same as the current one List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 21e0d2aa35bf41951f1835eac0dd58be257cbc17 Auto-Submitted: auto-generated The branch stable/14 has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=21e0d2aa35bf41951f1835eac0dd58be257cbc17 commit 21e0d2aa35bf41951f1835eac0dd58be257cbc17 Author: Christos Margiolis AuthorDate: 2025-02-25 11:44:12 +0000 Commit: Christos Margiolis CommitDate: 2025-03-04 15:46:06 +0000 sound: Return if the new speed/format is the same as the current one This gives us a slight performance boost since we do not have to go through chn_setparam() and the driver functions. Sponsored by: The FreeBSD Foundation MFC after: 1 week Reviewed by: dev_submerge.ch, emaste Differential Revision: https://reviews.freebsd.org/D48012 (cherry picked from commit 40616b7e41ff96b6d7522445b00f27f26d593a85) --- sys/dev/sound/pcm/channel.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sys/dev/sound/pcm/channel.c b/sys/dev/sound/pcm/channel.c index 19b2db321cee..c3ee50d51c4b 100644 --- a/sys/dev/sound/pcm/channel.c +++ b/sys/dev/sound/pcm/channel.c @@ -2110,6 +2110,9 @@ chn_setspeed(struct pcm_channel *c, uint32_t speed) oldformat = c->format; oldspeed = c->speed; + if (c->speed == speed) + return (0); + ret = chn_setparam(c, c->format, speed); if (ret != 0) { if (snd_verbose > 3) @@ -2138,6 +2141,9 @@ chn_setformat(struct pcm_channel *c, uint32_t format) oldformat = c->format; oldspeed = c->speed; + if (c->format == format) + return (0); + ret = chn_setparam(c, format, c->speed); if (ret != 0) { if (snd_verbose > 3)