From nobody Sat Feb 22 02:51:39 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z0BND5BS5z5ntXn; Sat, 22 Feb 2025 02:51:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z0BND0djGz3n0S; Sat, 22 Feb 2025 02:51:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740192700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=z4g/1CKPneYmlZUvS0WpzVJWNqS+W0Z44o100dxHysY=; b=TZhgONQiqeUgB6hwcRjqDEQCOHv7/5Awl/LVddeTo6H2+FgkKurhe4DWuk2s1Yp+liXgrH 1pyEI24+Wonnz+XgGVEMD/ScjtJznL9GFKMDUXYs8t21LQ2QKUN4YLlfPfYlQEqI8l90Eg plfrlLoVIHEeo8n5krU5J6tPqv0pDmbJO2/cFui8ssP+Yh7rRbTp0FimZat+s7Z8r/hYI2 jXmFXDKQp3PXf50fJJ4F0YCKRLKO/Y91UFZTW5mrFlkrewX/lXeu0nGHbxEdK9+F63RwL9 /FLLdBygpcPA63Yy2WZZpESaEJeFc/1J7e+zjd/0Q3sIu3NcMd63+VyIj6iW3w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1740192700; a=rsa-sha256; cv=none; b=FSwzMbKw1PHMm8YBVMMRBD38rsGhaoJZxd6WScXmUE5UWCAVZmxSdmDR9XbiYnbombheoo 8ZZL+zvDYk/Ggku5b53/3jHwvwpyneCq7/bhdR6AT7BBEvcvEKMNeYAgB1FY7IBdm0iVnF Kyz5CIJszJS+8j8RXeEnyrODvWpU+I6r6zCM0L7bUUAwhnz14dP22PTjGAUGHmkX5RY6/e kFjcrww76aC8ysE29BMJui1VVWLRJqLttzuoD03fwY5hN+PIesmrmARE6T+WsHfiOs97Gy iPzFh7rAHz0GHAaheniMSm8ENwwStfuVvY36CYzr/0sEsBWFgSOpLA31W0tEqA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740192700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=z4g/1CKPneYmlZUvS0WpzVJWNqS+W0Z44o100dxHysY=; b=i3OwNmcH3gAetYvHkPXjHYxYarCjxm9t7uAnaMGLIVo0FBR7nWSVFSuImPyoRiB2k/c1GV FNHvR+nW+lg/uhrZfhPxaQqAG+8aqxl4zVcnF6y3pwe8gSj8fP1d4iGrSY5QEAofp0fSG5 H1IcImp7feuPTSme5Yfn0OVYQ/o5fAgBo7ey8vD8QcfC07fdJZGEhJoEUmJAt0qxvXZ2jF F41ZTBlEvK7vvgLc7LPGrxscj6J+ZukPBQ1joZkSpM77MLeHWuZllEA5RaU5051ZahkVG9 7EoO9+qluIGpo/LWyprMWAF3vJk/MfTl00Ytbj/d6vt1A8S35o8D4aFGPcNXnA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Z0BND08z9zqP2; Sat, 22 Feb 2025 02:51:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 51M2pdju069832; Sat, 22 Feb 2025 02:51:39 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 51M2pdFL069829; Sat, 22 Feb 2025 02:51:39 GMT (envelope-from git) Date: Sat, 22 Feb 2025 02:51:39 GMT Message-Id: <202502220251.51M2pdFL069829@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Zhenlei Huang Subject: git: 072303d432eb - stable/14 - bnxt_en: Remove pointless NULL check for sysctl arg1 List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 072303d432ebe02637c2fbfaf9d6a2805c5514ed Auto-Submitted: auto-generated The branch stable/14 has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=072303d432ebe02637c2fbfaf9d6a2805c5514ed commit 072303d432ebe02637c2fbfaf9d6a2805c5514ed Author: Zhenlei Huang AuthorDate: 2025-02-14 10:38:30 +0000 Commit: Zhenlei Huang CommitDate: 2025-02-22 02:50:55 +0000 bnxt_en: Remove pointless NULL check for sysctl arg1 Those sysctl handlers have been guaranteed to have non-null softc. No need for NULL check within sysctl handlers. No functional change intended. Reviewed by: markj Tested by: Daniel Porsch MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D48495 (cherry picked from commit 747fd2db538a85df84ae6ac1e58494295b4a65ee) --- sys/dev/bnxt/bnxt_en/bnxt_sysctl.c | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/sys/dev/bnxt/bnxt_en/bnxt_sysctl.c b/sys/dev/bnxt/bnxt_en/bnxt_sysctl.c index 9114f5d1deaa..671ceef570f4 100644 --- a/sys/dev/bnxt/bnxt_en/bnxt_sysctl.c +++ b/sys/dev/bnxt/bnxt_en/bnxt_sysctl.c @@ -1793,9 +1793,6 @@ bnxt_dcb_dcbx_cap(SYSCTL_HANDLER_ARGS) int val; int rc; - if (softc == NULL) - return EBUSY; - val = bnxt_dcb_getdcbx(softc); rc = sysctl_handle_int(oidp, &val, 0, req); if (rc || !req->newptr) @@ -1945,9 +1942,6 @@ bnxt_dcb_list_app(SYSCTL_HANDLER_ARGS) int rc, num_inputs = 0; char *buf; - if (softc == NULL) - return EBUSY; - #define BNXT_APP_TLV_STR_LEN 4096 buf = malloc(BNXT_APP_TLV_STR_LEN, M_DEVBUF, M_NOWAIT | M_ZERO); if (!buf) @@ -1973,9 +1967,6 @@ bnxt_dcb_del_app(SYSCTL_HANDLER_ARGS) char buf[256] = {0}; int rc, num_inputs; - if (softc == NULL) - return EBUSY; - rc = sysctl_handle_string(oidp, buf, sizeof(buf), req); if (rc || req->newptr == NULL) return rc; @@ -2000,9 +1991,6 @@ bnxt_dcb_set_app(SYSCTL_HANDLER_ARGS) char buf[256] = {0}; int rc, num_inputs; - if (softc == NULL) - return EBUSY; - rc = sysctl_handle_string(oidp, buf, sizeof(buf), req); if (rc || req->newptr == NULL) return rc; @@ -2030,9 +2018,6 @@ bnxt_dcb_pfc(SYSCTL_HANDLER_ARGS) int pri_mask = 0; char pri[8]; - if (softc == NULL) - return EBUSY; - rc = bnxt_dcb_ieee_getpfc(softc, &pfc); if (!rc) bnxt_pfc_get_string(softc, buf, &pfc); @@ -2088,9 +2073,6 @@ bnxt_dcb_ets(SYSCTL_HANDLER_ARGS) char buf[256] = {0}; char tsa[8]; - if (softc == NULL) - return EBUSY; - rc = bnxt_dcb_ieee_getets(softc, &ets); if (!rc) bnxt_ets_get_string(softc, buf);