From nobody Wed Feb 12 10:19:29 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YtDnb14Scz5mXB9; Wed, 12 Feb 2025 10:19:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YtDnY70lLz3YHy; Wed, 12 Feb 2025 10:19:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1739355571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7p7kHodJb8ErqnRlr4V44+XmXYwhYY7Hlnzg1yqUOXI=; b=h7z7KXqyVhBoHRAiNVo833GSmWabSBccfFfgT3BCTzm1GfSwWtZtMdQUrADRgkFEI7HNAe xhXUjR58uuUEIzQCEC97ogJT17Skzj12RQ9TSADAaaQ0NJnbi/TM927sb1xygzgTtii1ft 4c+zdcjiPzKUeODcPfhsFIRkyYz2OXOc6qE0+PHirWZg7rdqmX4HpXHSVQYzAKk4dgF8/N upLU+rc1UO0trBjueU/VkoWC1RVqvvmxV0r27zbh678+A4cxMnZQTXLjCKS+dfIudeNZ1V 2qXOlLK0ZAeWjO52b5DmukIL6UmsnMdQwWIlV70H1navIXDk0DdEeYYRjGNQKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1739355570; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7p7kHodJb8ErqnRlr4V44+XmXYwhYY7Hlnzg1yqUOXI=; b=A44IETZNz5p/3fszoNuZopAaethKpSZsGno/HkmsvPESz0v+0P24HDEog3mLLDNdFr3t7T YV6ZC5SikcCrjyBXShlcSnZEaqG+fuk5v9acdqVi94O1bGASs527JNU/uf0UPCZipYXJ14 wXhRtJJ4ypyCjjNmdlCYHfSPgFvY5ooKJk0dMVWYcjPk17YifVIZU+mfGl5H6Id5z5XU/X lNmbGdDqh+lK8LfUyxwnw4nqqv7XNr01lUWWa54ORmG5m+N2xhlGXsVC+PEeqQclK913fp kZfYnfqvXEbP/GBLL8f+D2E9M9SJx5hbboPEqAgtIYyt1KrJarK+gUZnxxPUvg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1739355570; a=rsa-sha256; cv=none; b=RABJdjZMjU70MMvf48yfuaXD3bLR/AfyugyauSw9IijThTKVlD77pBMspHXnZb1k/xxr1U OmibaPd34kV9gpgZnMUsnfMAdTTph+wdtdHpuPdv71VHeerqMzBhXDDk1/tmI4myHAhDse CNANdpsln4t3pLEgahGlvsjW2/yVv32JVFQzn67ltWYndFEyzIKIq2Q+UHBYrCRPNT1OuX JzNZr+kTTUvuMgCfWxyLUAMbBH6wwJJSR8efBn/eEpAYkbEZB3IcedIUNDFMTI03NLrJDZ d5iDn/R7fddDndQ/bs64m/HOrXNNTfVfh97+1fOjyPZgIYH2MeFEe95FY4woIA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YtDnY64dmzvhG; Wed, 12 Feb 2025 10:19:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 51CAJTBK012765; Wed, 12 Feb 2025 10:19:29 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 51CAJTP6012762; Wed, 12 Feb 2025 10:19:29 GMT (envelope-from git) Date: Wed, 12 Feb 2025 10:19:29 GMT Message-Id: <202502121019.51CAJTP6012762@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: 0939f3a04653 - stable/13 - icmp: do not store per-VNET identical array of strings List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 0939f3a046533a2df1d2b10fd914c98755dacb0b Auto-Submitted: auto-generated The branch stable/13 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=0939f3a046533a2df1d2b10fd914c98755dacb0b commit 0939f3a046533a2df1d2b10fd914c98755dacb0b Author: Gleb Smirnoff AuthorDate: 2024-03-24 16:13:23 +0000 Commit: Michael Tuexen CommitDate: 2025-02-12 10:15:53 +0000 icmp: do not store per-VNET identical array of strings We need per-VNET struct counter_rate, but we don't need per-VNET set of const char *. Also, identical word "response" can go into the format string instead of being stored 7 times. Reviewed by: kp, zlei, tuexen Differential Revision: https://reviews.freebsd.org/D44475 (cherry picked from commit 7142ab4790666022a2a3d85910e9cd8e241d9b87) --- sys/netinet/ip_icmp.c | 37 ++++++++++++++++++------------------- 1 file changed, 18 insertions(+), 19 deletions(-) diff --git a/sys/netinet/ip_icmp.c b/sys/netinet/ip_icmp.c index f0e63d6c8b1a..54411d55f49c 100644 --- a/sys/netinet/ip_icmp.c +++ b/sys/netinet/ip_icmp.c @@ -1085,28 +1085,26 @@ ip_next_mtu(int mtu, int dir) * the 'final' error, but it doesn't make sense to solve the printing * delay with more complex code. */ -struct icmp_rate { - const char *descr; - struct counter_rate cr; -}; -VNET_DEFINE_STATIC(struct icmp_rate, icmp_rates[BANDLIM_MAX]) = { - { "icmp unreach response" }, - { "icmp ping response" }, - { "icmp tstamp response" }, - { "closed port RST response" }, - { "open port RST response" }, - { "icmp6 unreach response" }, - { "sctp ootb response" } -}; +VNET_DEFINE_STATIC(struct counter_rate, icmp_rates[BANDLIM_MAX]); #define V_icmp_rates VNET(icmp_rates) +static const char *icmp_rate_descrs[BANDLIM_MAX] = { + [BANDLIM_ICMP_UNREACH] = "icmp unreach", + [BANDLIM_ICMP_ECHO] = "icmp ping", + [BANDLIM_ICMP_TSTAMP] = "icmp tstamp", + [BANDLIM_RST_CLOSEDPORT] = "closed port RST", + [BANDLIM_RST_OPENPORT] = "open port RST", + [BANDLIM_ICMP6_UNREACH] = "icmp6 unreach", + [BANDLIM_SCTP_OOTB] = "sctp ootb", +}; + static void icmp_bandlimit_init(void) { for (int i = 0; i < BANDLIM_MAX; i++) { - V_icmp_rates[i].cr.cr_rate = counter_u64_alloc(M_WAITOK); - V_icmp_rates[i].cr.cr_ticks = ticks; + V_icmp_rates[i].cr_rate = counter_u64_alloc(M_WAITOK); + V_icmp_rates[i].cr_ticks = ticks; } } VNET_SYSINIT(icmp_bandlimit, SI_SUB_PROTO_DOMAIN, SI_ORDER_ANY, @@ -1117,7 +1115,7 @@ icmp_bandlimit_uninit(void) { for (int i = 0; i < BANDLIM_MAX; i++) - counter_u64_free(V_icmp_rates[i].cr.cr_rate); + counter_u64_free(V_icmp_rates[i].cr_rate); } VNET_SYSUNINIT(icmp_bandlimit, SI_SUB_PROTO_DOMAIN, SI_ORDER_THIRD, icmp_bandlimit_uninit, NULL); @@ -1136,7 +1134,7 @@ badport_bandlim(int which) if ((V_icmplim + V_icmplim_curr_jitter) <= 0) V_icmplim_curr_jitter = -V_icmplim + 1; - pps = counter_ratecheck(&V_icmp_rates[which].cr, V_icmplim + + pps = counter_ratecheck(&V_icmp_rates[which], V_icmplim + V_icmplim_curr_jitter); if (pps > 0) { /* @@ -1154,8 +1152,9 @@ badport_bandlim(int which) if (pps == -1) return (-1); if (pps > 0 && V_icmplim_output) - log(LOG_NOTICE, "Limiting %s from %jd to %d packets/sec\n", - V_icmp_rates[which].descr, (intmax_t )pps, V_icmplim + + log(LOG_NOTICE, + "Limiting %s response from %jd to %d packets/sec\n", + icmp_rate_descrs[which], (intmax_t )pps, V_icmplim + V_icmplim_curr_jitter); return (0); }