From nobody Wed Feb 05 20:55:16 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YpCDN36psz5mNml; Wed, 05 Feb 2025 20:55:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YpCDN2LL5z3V0D; Wed, 05 Feb 2025 20:55:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738788916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0kJ3PaZM2dTUw4ZRhIkVbQ9B3dt4m+ryQI5C/LlzFvE=; b=YnL+JVcOUveC4TGTqJlhRWaD5fgYnLWSiC7Q82dtElxlyW3rK9xG6its/asZVx99srJ2QQ WwbcqgNgADmramNMOchNkXjELBiVW+kbKEuznzHF7SdoYkmp0+CK7by7tbbgGo9CLqoUGD 5YGUNZOOtyzGxgFruxmbzzlRhKBebCdoghOEiGUXQ9QE0phlcENFfgH9lQ+DwGdNlJPJlS Kd9Ej+OLA0mCXPaovE1qhRzQN6xJRTe/if2oM480JkkV5IpVnBOBn2X4tdVC7M9AxEkigO FYQKqO8lUt/VYHUGDJSsjl5FmwzbZWPsabcQAp67NfbiWczw9adzWRbcpt7dNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738788916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0kJ3PaZM2dTUw4ZRhIkVbQ9B3dt4m+ryQI5C/LlzFvE=; b=OCaKILkqr+cqbI95nm/bydKWOMOLl9Qt1KoxoQHnpIg8ZNz2D0mBNXS3NIuy13YANJY1AV /3MUZQ5tVTNEARlj7qlwKyZBhrPBykKFQVTsxB6IuiFfT6E7pMOY14USKIFzdAiajOfVas T4ZWuT+AeUIxZqSlJD48ws6KkiBuH5qTu6smEvJjdKDEyC2AQu9kLCVfqhybpMxan6RkWP vz+4M5dXcHR72wBh2s35P3yncZXNZctLClekY1n2EQarpjomhQ5QXhHKR5ipliyZIkMLdT GKuFXstmdqlR8GhcDsLLLxqZdR4gg8so8HyILMrKWfe/tye06zy+eHKaISMyGA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738788916; a=rsa-sha256; cv=none; b=hbWQM1CELZVxxKVFNJTQcpYI64RSU6lBpgLaHY82O7I8JagnoMpP1tK/U9xR3wxe0S3Z1w 9cDFinJL25MVvZVley0xaOAYOsauUarBbhPXFtxnRq+iMIZw0jqNBeGoHJiH2lk7Xlvd9y OEYKG6Emz5EPDJRAUUPb49KDYJOoSpj21oTbkj9Pb7vL73TBNhyEXEfrJZYYPP4JZi6ITn 149aY4RHd5MVTPpZdALR+4OvuqkZJ09oyhln6U9Ux/i9b5dOIrUzC0KGZzur4yFYroOM4i VKO6UueLx9Xc45skz6qwR7KmXAa6/0Q2b9yevgP6jzr5tufmsloXbgOMJ2Yx3g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YpCDN1xzNz179H; Wed, 05 Feb 2025 20:55:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 515KtG9T004105; Wed, 5 Feb 2025 20:55:16 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 515KtGum004102; Wed, 5 Feb 2025 20:55:16 GMT (envelope-from git) Date: Wed, 5 Feb 2025 20:55:16 GMT Message-Id: <202502052055.515KtGum004102@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: 2a704e9ca7e9 - stable/14 - TCP BBR: remove dead code List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 2a704e9ca7e940d960ac493d015af59f0326b9b8 Auto-Submitted: auto-generated The branch stable/14 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=2a704e9ca7e940d960ac493d015af59f0326b9b8 commit 2a704e9ca7e940d960ac493d015af59f0326b9b8 Author: Michael Tuexen AuthorDate: 2025-01-06 19:40:33 +0000 Commit: Michael Tuexen CommitDate: 2025-02-05 09:55:36 +0000 TCP BBR: remove dead code bw is unsigned and not zero. So it cannot be smaller than 1. No functional change intended. Reviewed by: rrs, cc CID: 1523791 Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D48323 (cherry picked from commit c28fefe1dc44b69743dd18d038440da38a2867a7) --- sys/netinet/tcp_stacks/bbr.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/netinet/tcp_stacks/bbr.c b/sys/netinet/tcp_stacks/bbr.c index 6c6bc5d1532f..73751e984125 100644 --- a/sys/netinet/tcp_stacks/bbr.c +++ b/sys/netinet/tcp_stacks/bbr.c @@ -2992,9 +2992,6 @@ use_initial_window: /* We should not be at 0, go to the initial window then */ goto use_initial_window; } - if (bw < 1) - /* Probably should panic */ - bw = 1; if (bw < min_bw) bw = min_bw; return (bw);