From nobody Wed Feb 05 19:50:24 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Yp9nY5T38z5mHsq; Wed, 05 Feb 2025 19:50:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Yp9nX6wwMz3vj9; Wed, 05 Feb 2025 19:50:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738785025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xZwaZDQsjq8BPkb7Jb5dwgKIWML0ZDnXkj+4eq35Lqc=; b=sQvatFwnfyBP2WXyxjAgezO5UFt9cnBoK+ldVvLy0l1XoF9EY3Q71t5AupFakJF3IxgCwS 6+8m5pcs8PJ2Mkc8vOHqpL8ovB1ZozHyaU5an2C1R8g1fjWHrTBQVW4oLEeAeMq9TKrv6e P5MKn08dN3SflPXrV7cDCr1RsVXOIqCZP53lhSTDLw3qsUM3AaAtu2Yzq7FOvwpqlqvN/D Cy2/2E/7fi8gWhLBUUtdQSfI6xSRfAr6FNPiHERPS/1FZmW0OtXyJD/OZCW3vt5Xl4mR1R S6FCMG/GlHpghp7SQCa+LbsFghIrPpVjAh2j5VMRlihb2l7MkBoC1f7DV31t0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738785025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xZwaZDQsjq8BPkb7Jb5dwgKIWML0ZDnXkj+4eq35Lqc=; b=LxeCzRHAiESKrLMF76kqMa+jPrFtyxN6TSheeeEG8nc0sYyOtJJwdEcnyftkqQV8JhHL1J /l15/fRpoirWMVRtuXt6Z6ZNXuQhxyiGXUifBXrC99zMZtWMq66UHIslTmlBRBvLJ5TG1O GvQHdCU5b1btGrb+j8JxJPwUAMKQ6RgvGgC/sazQODBMQBs9mmwA9gDTRK4LsCA1h3k8lu mgYXqIfPSGui3uaaYjrD6bDuf6aubSjOJ/jjGvrUbXbQNs7QjJi8jo2y0lHbRoJs7jILL4 5fsuodxW0pUNe9RIoqTJdX0e5gM08RLS6GoPU+Vka30MSOglZ4brUYGTugbSyA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738785025; a=rsa-sha256; cv=none; b=BBtkQsaJxnQlMYLn0qsUKGgz7na9h5uTIrf+joh+Ckh7tRCJy1DRoyPVsl+ZPz51TRtmKr 1RO/dnAq1dcrNWjQ8Bq4OqXe2n26QCQXpMlC4CwXNpGVg3mMx2Nk2wvVv8Q8uaLbA5vGz+ QsJ3M5BGIHSIR7ZjyxbeGzBbqjJuo5EuQMDnRmQsyTjpF1qXpDWlC8vL8YkPZlTwiv6S0q hEUezR8KmBZYlfEFiGZeL586x44KyrulAj6vWx6/CUZu5LtWqm9Ovj6BvtRNbGQba++9tB dfYrOurK8ZgTYnqAq/GpLom/BrLg2H6enzjW27EzLQrnzCgfS4lA6Kl0qNa04w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Yp9nX4SBkz14ZN; Wed, 05 Feb 2025 19:50:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 515JoOOG079302; Wed, 5 Feb 2025 19:50:24 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 515JoOPA079299; Wed, 5 Feb 2025 19:50:24 GMT (envelope-from git) Date: Wed, 5 Feb 2025 19:50:24 GMT Message-Id: <202502051950.515JoOPA079299@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: 8d5e624d8daf - stable/14 - TCP RACK: don't use an uninitialized variable List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 8d5e624d8daf05b778ac3f10d085a670eef5a2c0 Auto-Submitted: auto-generated The branch stable/14 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=8d5e624d8daf05b778ac3f10d085a670eef5a2c0 commit 8d5e624d8daf05b778ac3f10d085a670eef5a2c0 Author: Michael Tuexen AuthorDate: 2024-12-31 16:26:04 +0000 Commit: Michael Tuexen CommitDate: 2025-02-05 08:50:40 +0000 TCP RACK: don't use an uninitialized variable When storing the old beta values in rack_swap_beta_values(), ensure that the newreno_flags field is initialized appropriately instead of using an uninitialized value. Since the stored newreno_flags aren't actually used, this fix should not have any functional change. Reviewed by: rrs CID: 1523796 Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D48260 (cherry picked from commit 4f3a0c719780fdd57c660ceb353bbc71fc555600) --- sys/netinet/tcp_stacks/rack.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c index 061bc286e11c..3d13ff380a8e 100644 --- a/sys/netinet/tcp_stacks/rack.c +++ b/sys/netinet/tcp_stacks/rack.c @@ -631,6 +631,7 @@ rack_swap_beta_values(struct tcp_rack *rack, uint8_t flex8) failed = 2; goto out; } + old.newreno_flags = CC_NEWRENO_BETA_ECN_ENABLED; /* Get the current values out */ sopt.sopt_valsize = sizeof(struct cc_newreno_opts); sopt.sopt_dir = SOPT_GET;