From nobody Wed Feb 05 19:39:16 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Yp9Xj1pKDz5mGh0; Wed, 05 Feb 2025 19:39:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Yp9Xj0ZRSz3qwL; Wed, 05 Feb 2025 19:39:17 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738784357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=v4Fco2odWZwzLfGZO3HAT4sOB/7i5oh13ZOBMacq604=; b=iS9Qe4sD9S4cotMjnFiQmp4TrqA7NmQtCAGit53MLufJUgAKj0PUqd3ecBP0GNyi9bpuxK aJ2Q8QczDXNuiw9pnQzJFGuMAfkZZNHSSDob2QT3UETiHRTP0kz/rik/LKjmgHnBNE2Sru WSe3/9lsxpvHRNaH5/kPUVuk1If7rQjjVtx2LElbvCFW/r02zMeQoa3XjGTFEycEQzbELT st2ZKNiD6/WVPBXZVxVWvFt4Y4xZulg78x28++BTAkF6iqgX6Y0mNsvhI9Y+UuffwGS8Oh dqX8rzzInJli1FSP2uLUYLrkihfjjoum9R0Rj/NTfqDDMY8Br4qHzu30piy/Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738784357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=v4Fco2odWZwzLfGZO3HAT4sOB/7i5oh13ZOBMacq604=; b=YGMwYOQ3m7HX2oTzloFDIYrWI4sqPKp02GVH/dOMDtCXo+XF46ZAsEhcNuVzkz0VM4o2KZ HMSek0p2MoBjfWCBtIcheUsTk4r920AcmeYNEbqgEKXF+SDpBa84lgrsZfBn0JjJD6/bNY rue90AHTRC2pOOwCRnfAedOA63sp3Ph0Ee1WBg9KMJNO2jplzGpPgb/W+oQWugQJEkMBKd UJ8E0j9aoCZvsDC3LRHtsR/KM3sHEK9Vnt06pFKvlBH1ZIbaGQ4n3LSSX0Dj3qP7XRVwQl j+dbZbUsZjnxdgcAX1JJFKEAOBeIAdQFvikyAz26gYxF4Ay/whDeOeJuotgw6Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738784357; a=rsa-sha256; cv=none; b=H++aF5iGqjw8qDIhoJFj1S0DFws/3buhtOmf04ZOsJAdSrhxDZf4CdSD8QDSlGFkL4fKO0 u4w9YS83qjtjPJTB/XiQfcFLQkjH73hoaBc20fGxeMvrKzf8hDeOw5jEZKb8Nhioj//bpc o3SK0dzMN3zlT4MdA6ZusDQ9RA42LyjfvKmkg6V2r52meKbpLCiNnwHhKsCyuw/mjIdrEM ZSUlBINBZKphMtbdLpo13SFY6PpmWXHCFTDYBt4Awy2AEiuglIYTVntdi/k6bHAWQ2GBd8 5e3pNvNvGwhigTN5JxDZMuaktpoDqNkfqQ7TVRYLO3Wv4QhTHVU38blkDIB32w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Yp9Xh6w9Tz14vd; Wed, 05 Feb 2025 19:39:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 515JdG6U050458; Wed, 5 Feb 2025 19:39:16 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 515JdGI3050455; Wed, 5 Feb 2025 19:39:16 GMT (envelope-from git) Date: Wed, 5 Feb 2025 19:39:16 GMT Message-Id: <202502051939.515JdGI3050455@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: b9c89008cca9 - stable/14 - TCP RACK: remove redundant check List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: b9c89008cca9346ffc68e8e1b954db3d338332b8 Auto-Submitted: auto-generated The branch stable/14 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=b9c89008cca9346ffc68e8e1b954db3d338332b8 commit b9c89008cca9346ffc68e8e1b954db3d338332b8 Author: Michael Tuexen AuthorDate: 2024-12-30 15:00:11 +0000 Commit: Michael Tuexen CommitDate: 2025-02-05 08:39:26 +0000 TCP RACK: remove redundant check No functional change intended. Reviewed by: rrs CID: 1523811 Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D48216 (cherry picked from commit 16e8e99f1d412103d8f42e5ed740555c545bffc5) --- sys/netinet/tcp_stacks/rack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c index 8cdb6e1f9efe..061bc286e11c 100644 --- a/sys/netinet/tcp_stacks/rack.c +++ b/sys/netinet/tcp_stacks/rack.c @@ -23042,7 +23042,7 @@ rack_process_option(struct tcpcb *tp, struct tcp_rack *rack, int sopt_name, switch (sopt_name) { case TCP_RACK_SET_RXT_OPTIONS: - if ((optval >= 0) && (optval <= 2)) { + if (optval <= 2) { rack_init_retransmit_value(rack, optval); } else { /*