From nobody Mon Aug 25 15:22:55 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c9ZL76nvCz65vh9; Mon, 25 Aug 2025 15:22:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c9ZL75Gtxz3Xw8; Mon, 25 Aug 2025 15:22:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756135375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9AFBalJ5RidwYzD5QPULPmB7COKkYQ1iP5bZdrReo8o=; b=yJpBAwIVvG3PwkYOEy5puv+9Oce1tl7+2t5ds4IVFrfXsXWPH6XwO646MrmHI0awGO2E17 ttULiQCRTRs0sn81Ue9AmFCl8Ne+sa1VMMaREjlclCVSMKJkwEzNP0SFpIJm0O1BkHRsZ7 Op7u0Jxv2p2maTTVCmVLU7T3euLVn5gKPJJ7+dNsX6uoztmu3t4fYJH4pZ8ZasHf0fbOaS 9cg3Vd4QydVQ5HfhJoRycDTy4o0b4+P8CFt2Rrv91AxichQt0SYILMWDURn8eKbxMRADrw tjQ6l+Fdy56qeZRuigioK+YKUqtXcfi6sfI/IL4eNPzMfdUWombfqcXYwtyXlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756135375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9AFBalJ5RidwYzD5QPULPmB7COKkYQ1iP5bZdrReo8o=; b=ZaCSH4xKDaCwFr7LE5q26AmvZmoCgaa+nucJf4Py7qYI/hUchd2cgWkDY6f1gQdl1MjXys qS1J9sHGqzRE8h+Wh9IsGdw/mB2Q/P46O9XklJZD2XxH/QtsnvqeKgUCuhdWD2GxxXC1Gq hQpeNZ6QZcN9PaOW39hglRGtcpvcc0nrSvgBkurkoaXtq4GMVzoZIaTb6QsJ9FeYkFSsiN qxLhjLcBg6eDWC4g+b0hseuSEGIhjyzxPPS7FFa/nY6lrmY7LWmGUGl8Mz7Y9ATUZ+Y7yS WV5xUpOLuW6WHONAvbL1EX2U3PoS4ZKS+aTlz/CcwBtfsfU/S7IXOvPxXb4UGg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1756135375; a=rsa-sha256; cv=none; b=dmMwyMHO/bkjxGPv+tJJhnl+H1ZzAOQKRem6kFqMGqW3XFOQZJFrpexSuUAxOJ1457Ntjx 8yIXJCey5zs5sjaz+UjC0NplhrKJdNWojR71kWJ9NAYb0CRpqR3WzlIZ6hTuzqcvlGAufO AfVebHfcI3K4qInNEtY5/wImX3kIOpXBb1t05eU1ugh+zykG0NFVvbSIA8xYvFq7FcXVCm IQpzx0isrbirr8/gLpJbTe9uFLbxdUs4sJeePzmwK6D3cao2Q/mElUrsD6/5F80Z6F2PlT BX5uY1GBfGx9/FXgzt9cUx1p462HA9gmq8vDASfxQ0yXoyuXOwE32dE2p6F7XA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4c9ZL74bm5zvx6; Mon, 25 Aug 2025 15:22:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 57PFMt3p054069; Mon, 25 Aug 2025 15:22:55 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 57PFMtPw054067; Mon, 25 Aug 2025 15:22:55 GMT (envelope-from git) Date: Mon, 25 Aug 2025 15:22:55 GMT Message-Id: <202508251522.57PFMtPw054067@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: d9ddd261ef3e - stable/14 - vm_page: Clear VM_ALLOC_NOCREAT in vm_page_grab_pflags() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: d9ddd261ef3e746704385889a38d275a32284de4 Auto-Submitted: auto-generated The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=d9ddd261ef3e746704385889a38d275a32284de4 commit d9ddd261ef3e746704385889a38d275a32284de4 Author: Mark Johnston AuthorDate: 2025-08-01 23:34:46 +0000 Commit: Mark Johnston CommitDate: 2025-08-25 13:57:57 +0000 vm_page: Clear VM_ALLOC_NOCREAT in vm_page_grab_pflags() Otherwise vm_page_grab_zero_partial() and vm_page_grab_pages() can pass it to vm_page_alloc_*(), which results in an assertion failure since that flag is meaningless when allocating a page: panic: invalid request 0x8400 cpuid = 0 time = 1754074745 KDB: stack backtrace: db_trace_self_wrapper() at db_trace_self_wrapper+0x49/frame 0xfffffe00542859c0 vpanic() at vpanic+0x1ea/frame 0xfffffe0054285b00 panic() at panic+0x43/frame 0xfffffe0054285b60 vm_page_alloc_domain_iter() at vm_page_alloc_domain_iter+0x720/frame 0xfffffe0054285be0 vm_page_grab_zero_partial() at vm_page_grab_zero_partial+0x1d4/frame 0xfffffe0054285c90 shm_fspacectl() at shm_fspacectl+0x1cd/frame 0xfffffe0054285d30 kern_fspacectl() at kern_fspacectl+0x49f/frame 0xfffffe0054285db0 sys_fspacectl() at sys_fspacectl+0x5b/frame 0xfffffe0054285e00 amd64_syscall() at amd64_syscall+0x29c/frame 0xfffffe0054285f30 fast_syscall_common() at fast_syscall_common+0xf8/frame 0xfffffe0054285f30 Reported by: syzkaller Reviewed by: alc, kib MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D51692 (cherry picked from commit 9a1b3303352beb44d48b8251b80656a316b7a2e9) --- sys/vm/vm_page.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/vm/vm_page.c b/sys/vm/vm_page.c index 1da7ddce86a6..5b5282dc5c9b 100644 --- a/sys/vm/vm_page.c +++ b/sys/vm/vm_page.c @@ -4553,7 +4553,7 @@ vm_page_grab_pflags(int allocflags) pflags = allocflags & ~(VM_ALLOC_NOWAIT | VM_ALLOC_WAITOK | VM_ALLOC_WAITFAIL | - VM_ALLOC_NOBUSY | VM_ALLOC_IGN_SBUSY); + VM_ALLOC_NOBUSY | VM_ALLOC_IGN_SBUSY | VM_ALLOC_NOCREAT); if ((allocflags & VM_ALLOC_NOWAIT) == 0) pflags |= VM_ALLOC_WAITFAIL; if ((allocflags & VM_ALLOC_IGN_SBUSY) != 0)