From nobody Sat Aug 02 06:39:09 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bvCpn0GSwz63fwL for ; Sat, 02 Aug 2025 06:39:29 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic.asd.mail.yahoo.com (sonic310-20.consmr.mail.gq1.yahoo.com [98.137.69.146]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4bvCpm2qXHz3JBZ for ; Sat, 02 Aug 2025 06:39:28 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=B5vtaZeH; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.69.146 as permitted sender) smtp.mailfrom=marklmi@yahoo.com; dmarc=pass (policy=reject) header.from=yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1754116761; bh=bqXIZQ7GDypeCDtAAjR6qEVlikn5zORCzShMjA0KC4U=; h=From:Subject:Date:Cc:To:References:From:Subject:Reply-To; b=B5vtaZeH8lYwJW7NBYELKX18A909/oE3ejUhIggtRh4ICvgRBHaXikarqunbQVMwDjrDHbp80j4DH7pGLjsDze1IUtDzHltchluRImySKtDxzy3ld3qaZXmaWYfcZ5SvoXUBhLg7uzIk+3r7e5X6Lr7XMatKSbS114ZBGU0+XPYIWg8dcj4IoaPLWjR0wKybRwgKLtCv4xvw6zUPeTnbgrTcMSQSAhN7OIFg8SXWEFe5/YJ0ZlcktdRUycn3UVCZS5hbL0lJuABli8gkizUss39m9PJtJxvczReks9J7lmYvi7P/LE824PITC8Tpu+LqyeSFIgk2Gh37U8ExIvxF5w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1754116761; bh=f6/wwgnbPNgprt4T9ZJqi6xQwAVzb75GMPWYmNKkJyr=; h=X-Sonic-MF:From:Subject:Date:To:From:Subject; b=a3MvTkibBUrtXWe5D7MhNVFk+SvR+37IFEAZxB8Vn0qUEczztMUmR47ROM8G86+YGrrhmBsHn82DkGRIO5VQpXfvg37K8LSzuTni2zcwEFPcYXeaWYdbM5SSYHjIae9lW/D0cwt0ZgEqLy6JejnL3wZ39s+IfaE6AAfqlhWSMJJr0TgR5FQZuFbqRVfvw2b6/O9Q3ED/RqLbQeSnXYQwlY2IjAptZJzPzln4qAbDxaCu7lmcO+uEmzPnPdhwILsyGXFrO1An/XSQhDseWzqSBkWC07yCIpSyNoDUz2lMCap93JoSF959tcj+ctjPRfAgED3VO3RDmU9KlFVSolrd5g== X-YMail-OSG: zxmkMa8VM1nfDaOsyEpEZdJo1B..0wEf5oAN9POuVQl9eYpQhcn5Jy0.x8.gKp6 zyHbuNJnf6nOduratVAWtBcriP0Id5oXs63b6oXowdcjAbBl53xAx7oS0JdrAvZMORfIqV4sG9H. AHspDbcX34pXINTvxaKZX2GTgnL41e.IFwgKuvDkrVfx.cnno3D6pSOGSme_K8lxAser5TsPZqCW 2GaiZFcJUtSguA0YqOmOVOCdUpPGsJqVKQ9OhyI6kqcGJlXj.upFfrJCKlHgrirtmTJ7YqNYRfkd 9MSHLZjkfO8QioVll6ttLaGv5U8z2MwtWlvCvVd_a7ZxbtIEl1vOA.8PE2Ga1We2ROatOm25WTO6 hbZzOQr5ILTPLKlxmNVTfOWK.7iXNK7Fs1IxeoFU4Rwflz_YELAST62AeiUa2zdhh4g7mobWioZo BJWKRFpZ957EfceBXNkn0pSrLGXd4vF4ODaJLXMUtDMY78Rom_CmZrTRegbW4QQOthLcUwyCYcuZ d0LAWcuunD6dYAspA02rxV1YWgvpTBDIyVtS_4JyWVVfoF8SWUM1vHPWh2u6C5Laj._WN7i5X2hU T0fj5tZbxigH6w2ChJFC1aD_86j4C1S2pAgKCv_BXCALXq1_FJC_VWlZ7CUhdSFtjv2wFdtUlNtt RzBkZovCJYSlI9ztjR3pxf6AgN1pZdhLDR.J27ZW9qmGe4Z4CFDYBlhHW80mhRUkoQJe_bJIRueq TWoxG_Z0jzQev1ockB8BkfzkYKBPCbiORKB7QJiHEcD4jSGDys1qAwjyvC30KPlKzU1VmUMpEiMB f4qh9K0f7z6sHPcbIcGrRl8LjJbA6qd4EwxRqgr6gNfLaer18sG16vOFU2WkYs3j5hwEtPYYSuZf LBo9vo5VLzqD4RgSGybkc26hEC1COXjmhpJr51IzFshto7Au_jDtybSlR2gvSAiEHeEq6TQ1H2Rt bgcp29ZB.gTIf2IDFBjJn4PZbon8fySRPCBPLD8frjLyrfUpAibFVchbYZe2hSEBfScbxYdUlP6n 7MVLwopreUo3cBM_jRTE3MdkTao77dlWrTozyeoJ3qcGZKCRWKp5IFbS1_1U1AwXwIS99.mHkGP7 A8N4Qg.SuUTUiaZIHBbAgjzTIhV1cRobtUwskUX2IZnDcvuEZa5pnDQ3Jeh9wOdoqmZB2XdM9asj .qLIUaXuEtSTCciWsNUGnp5e7GIdtCCsxYVij_Ru2PaEmj0M.uTp2rhEpQrXv_fVzmFWqa8Hs1em cytCqIDx3jodQAGVjg0Yuy0jaD_fGIfV9PrVrHgBWSxHIeMPJoiY1Cp3InXv33sQFECdTD1xj0q7 uHjM2XOM.Z8MbdukhYljutbrZD5l6Jzs5YYTuDxrTzWasZsHKiYRS_QhfeO_9pnOsOLejRmYSJIG rlmDLUcAUX6Nz35cWKbFKfmVFHSpkq.biwukJEieMWbcltYW3VvTkaPE9hLVGRE5To0.H1F0Xj3b L34_R5wnkPLWv4t3u4G4GBB1eNGplK7O.hL6FGsSIEpaDrTNq0uuHg0XcFMdo2VQLFJPGCulijUF BPVbGkWR59kAta.B0.y3Uw09sHgBz6q_8zkVMpjbMWYEHFpp7XR0YZUzcuwG2umn6mjSzSwsThcP SrSfw6V9t6kPClDuXz98C8kVUZnp2CizAqfIG9lJUQXdANGoTRg9xbMJR8V1m6YviVz4xTKsriIO Un.ixKwqw_NTOxmbzNbfeGQ8LvwpcBoVXvLizOuw2lWTSyf59xZqF8PB5ODZgvt8Lf817D9l0k64 1SlbLcnVcP4ZeizoWRo1Z.dznzaGlgk4vZvUl6xGQIcRv7bL5xIm2VBAqXIo2Ydn4n4S8Rki4k13 UU0uhNkU2btGEn6jnFPZOdP2iVrtvPdU8GwuE1QCZhhY3kGiEvD6Q_LBVmFocvCtd1FwNIjQLbH2 HLdDuIS6mHtTdPeOtenecQ919WKIGUv1olIOQCdgcqR5hZAv0FVp7i8K4ljs2gfKwSj28NAG9ZN3 XXTpldvZt0M5AkIXFGBXW48orNvhe1bpAbL1XfccZ1DpOY11XivbwXtujXNzizxUfJtfJVEth2vc EEjsjE8U91P.47aXHNqhO6IJeQn1OYTXiwmZ1iP.9HX5cu3yPb8WDob4Yd_nGWouqP9v._BlvSjp oDLQhHqmOqjuv8swmfehLv4RR1STBQO87cY_zSBEu8TCIj9MM4KhQL2I.gKOsq909DJQi8WqSJE9 dcEA.c0XXoPIPMX4XNwDRcYdbHqdiP7b7NDe1tH7sth9BVP_INaohQca6U1zBAZwdcwzMduPddT9 3kO13HV9pKUcEcOrBjhN5S.3CwXODn2ha1zg4mDBLyFEI3uE- X-Sonic-MF: X-Sonic-ID: d4921dd5-5939-483d-a190-971f2945b0eb Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.gq1.yahoo.com with HTTP; Sat, 2 Aug 2025 06:39:21 +0000 Received: by hermes--production-gq1-74d64bb7d7-r4nbl (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 48eb9184372d616902793749eae74ec1; Sat, 02 Aug 2025 06:39:20 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\)) Subject: RE: git: 8d4464377219 - stable/14 - vm_page: Fix loading bad memory addresses from file Message-Id: Date: Fri, 1 Aug 2025 23:39:09 -0700 Cc: Konstantin Belousov , Mark Johnston To: "romain@freebsd.org" , dev-commits-src-branches@freebsd.org, dev-commits-src-main@freebsd.org X-Mailer: Apple Mail (2.3826.600.51.1.1) References: X-Spamd-Result: default: False [-3.50 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MV_CASE(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; MIME_GOOD(-0.10)[text/plain]; TO_DN_EQ_ADDR_SOME(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; RCVD_TLS_LAST(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; FREEMAIL_FROM(0.00)[yahoo.com]; FROM_HAS_DN(0.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; RCVD_IN_DNSWL_NONE(0.00)[98.137.69.146:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; MLMMJ_DEST(0.00)[dev-commits-src-branches@freebsd.org]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.69.146:from]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_FIVE(0.00)[5] X-Rspamd-Queue-Id: 4bvCpm2qXHz3JBZ X-Spamd-Bar: --- Romain Tarti=C3=A8re wrote on Date: Sat, 02 Aug 2025 05:31:12 UTC : > Romain Tarti=C3=A8re > Date: Sat, 02 Aug 2025 05:31:12 UTC > The branch stable/14 has been updated by romain: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D8d4464377219dcf45e87510b73767c9e= c3515bc2 >=20 > commit 8d4464377219dcf45e87510b73767c9ec3515bc2 > Author: Romain Tarti=C3=A8re > AuthorDate: 2025-07-25 18:31:57 +0000 > Commit: Romain Tarti=C3=A8re > CommitDate: 2025-08-02 05:30:18 +0000 >=20 > vm_page: Fix loading bad memory addresses from file > =20 > When loading bad memory addresses from a file, we are passed an = end > pointer that points on the first byte after the buffer. We want = the > buffer to be null-terminated (by changing the last byte to \0 if = it is > reasonable to do so), so adjust the end pointer to be on that = byte. > =20 > Approved by: kib, markj > MFC after: 1 week > Differential Revision: https://reviews.freebsd.org/D51433 > =20 > (cherry picked from commit = 202f8bde836dc86627be2b5b98174d9a0fb2eaba) > --- > sys/vm/vm_page.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/sys/vm/vm_page.c b/sys/vm/vm_page.c > index ac922f4a3bc8..f013cbc84c25 100644 > --- a/sys/vm/vm_page.c > +++ b/sys/vm/vm_page.c > @@ -393,7 +393,7 @@ vm_page_blacklist_load(char **list, char **end) > } > *list =3D ptr; > if (ptr !=3D NULL) > - *end =3D ptr + len; > + *end =3D ptr + len - 1; This looks wrong to me if/when len=3D=3D0 is possible. It looks possible, see below. > else > *end =3D NULL; > return; > return; More context, original code(from main): . . . mod =3D preload_search_by_type("ram_blacklist"); if (mod !=3D NULL) { ptr =3D preload_fetch_addr(mod); len =3D preload_fetch_size(mod); } *list =3D ptr; if (ptr !=3D NULL) *end =3D ptr + len; else *end =3D NULL; return; . . . But in /usr/src/sys/kern/subr_module.c : size_t preload_fetch_size(caddr_t mod) { size_t *mdp; mdp =3D (size_t *)preload_search_info(mod, MODINFO_SIZE); if (mdp =3D=3D NULL) return (0); return (*mdp); } Note the "return (0);" (possibly *mdp=3D=3D0 as well when mdp!=3D0 ?). Then, for that return, showing the substitution: + *end =3D ptr + 0 - 1; Simplifying for the specific case: + *end =3D ptr - 1; That looks likely to be wrong to me. =3D=3D=3D Mark Millard marklmi at yahoo.com