From nobody Fri Apr 18 14:37:06 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZfHQq4BMcz5stWW; Fri, 18 Apr 2025 14:37:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZfHQq00pMz3KVm; Fri, 18 Apr 2025 14:37:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744987027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=So3OWCnbfPHALwgHM0207P85Oq7Gdbb7EI5nGZUdDoI=; b=YrLPfJhIouWg4q9Ova8hjgTDb7Vg+g5Rn/jeVb2RrSvb9PQRS0PhlPQyCWP2Bfqweas9td qjLyOefis8VrrcALDIzigg9uecNQfTYwlQh9IjvlyU5dA3hDKfzQjt529f13qbLPGLJq+C m8OxI/ggifimLw9yoKdF3h4jZjKiyE1JwQEHTlmlYpOjIO1AlvvFjnPoWOsRJ3yyCFrWkM EqSE11r6PK2j6BG25ZxkgqKCs1CRFgDa8JlZwam20+g9lAOKQoFj1qNiMn8LO90xAroU5k uHr+EXxBjcZoDALOM9eHOKR1LSZNFnowcobT2vj/5WTxPTCZh8AY6K/DL9liNw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1744987027; a=rsa-sha256; cv=none; b=mSrsIbqb12sr3/KBtwbVazPRPJgZ9Y2JlG/z3Xkp1x122Ktd+VSPlkDeebSQ2Vl8SsTADs ZKEWWsmxhQa/zkk329XXIY4rpZs8z5Ca/qYQ26Cpz0gCGJFZ1uHHrtqZ1rdRgKIMZTGuwq +noC1eJIe/wXJgSA3SK8nIOpIqRS+HUlvV2jb1K9TnuWquAs8aOznMwrXytXPd/XTTy2xn odix9aoBkKX7SOYK650ZF347ax9VbhW4MT7XIgMuojTTEr1Ai6awi3EqAEr58W4EOlolcp 9ljKOtD56RWvi6AwLq+EoCq5ZyxYqOz46YJbTaL43VeW9/hkebhX35dPV/AT2A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744987027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=So3OWCnbfPHALwgHM0207P85Oq7Gdbb7EI5nGZUdDoI=; b=vc3lJYu/lGKKPaKb/KGFW8Zv7fN14f0JEny9iDMG2Fna9g873u2Afr3TrVpYjavH4hOqFT gRXqe+melCRKHPTrIAEe/ChJCZRKHctreR9sLUayzq6sVURbJbnFyqZb8ptHSrQFy5vSor XlKMKBex31CJzgdKy4BpFiRnTAio7Zh+gLuQPsorj2/H62YqdEjlfSK+ghqDmBQE09T/SZ J7Zm3M5+X3ZZwY6LKwP9TO41tvXZjQuAm6RTo5WDQQdaxb+rZLzBgyx1yqScwTjY8ODiJ4 ETP/kYNoOdZuc18bZmk8sVJre2mw29TZrgCpVag92NaqxmyiFUo3sa0jRKR5mw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZfHQp6GPkzdxw; Fri, 18 Apr 2025 14:37:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 53IEb66u091620; Fri, 18 Apr 2025 14:37:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 53IEb6c3091617; Fri, 18 Apr 2025 14:37:06 GMT (envelope-from git) Date: Fri, 18 Apr 2025 14:37:06 GMT Message-Id: <202504181437.53IEb6c3091617@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: 998fc383bd02 - stable/14 - LinuxKPI: 802.11: remove ieee80211_node_get_txrate_dot11rate() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 998fc383bd02e8f1abe3c67decb60dc326c87908 Auto-Submitted: auto-generated The branch stable/14 has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=998fc383bd02e8f1abe3c67decb60dc326c87908 commit 998fc383bd02e8f1abe3c67decb60dc326c87908 Author: Bjoern A. Zeeb AuthorDate: 2025-03-04 15:20:06 +0000 Commit: Bjoern A. Zeeb CommitDate: 2025-04-18 14:35:59 +0000 LinuxKPI: 802.11: remove ieee80211_node_get_txrate_dot11rate() net80211 ieee80211_node_get_txrate_dot11rate() does not yet support VHT and that means we get a lot of log lines when doing VHT for a debugging statement even if it's not active. Remove the calls to ieee80211_node_get_txrate_dot11rate() as with hw/fw based rate control (modern iwlwifi) they are pointless anyway as they are currently. Sponsored by: The FreeBSD Foundation Reported by: J.R. Oldroyd (jr opal.com) Fixes: 706745001093 (I should have noticed during review) (cherry picked from commit d1a37f280be46a707b42c3eca5f8b6a38ecf726b) --- sys/compat/linuxkpi/common/src/linux_80211.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/sys/compat/linuxkpi/common/src/linux_80211.c b/sys/compat/linuxkpi/common/src/linux_80211.c index b0bf54744e3a..3d60404537e2 100644 --- a/sys/compat/linuxkpi/common/src/linux_80211.c +++ b/sys/compat/linuxkpi/common/src/linux_80211.c @@ -6986,12 +6986,6 @@ linuxkpi_ieee80211_tx_status_ext(struct ieee80211_hw *hw, } if (ni != NULL) { - int ridx __unused; -#ifdef LINUXKPI_DEBUG_80211 - int old_rate; - - old_rate = ni->ni_vap->iv_bss->ni_txrate; -#endif txs.pktlen = skb->len; txs.flags |= IEEE80211_RATECTL_STATUS_PKTLEN; if (info->status.rates[0].count > 1) { @@ -7008,16 +7002,13 @@ linuxkpi_ieee80211_tx_status_ext(struct ieee80211_hw *hw, txs.flags |= IEEE80211_RATECTL_STATUS_RSSI; } - IMPROVE("only update of rate matches but that requires us to get a proper rate"); + IMPROVE("only update rate if needed but that requires us to get a proper rate from mo_sta_statistics"); ieee80211_ratectl_tx_complete(ni, &txs); - ridx = ieee80211_ratectl_rate(ni->ni_vap->iv_bss, NULL, 0); #ifdef LINUXKPI_DEBUG_80211 if (linuxkpi_debug_80211 & D80211_TRACE_TX) { - printf("TX-RATE: %s: old %d new %d ridx %d, " - "long_retries %d\n", __func__, - old_rate, ni->ni_vap->iv_bss->ni_txrate, - ridx, txs.long_retries); + printf("TX-RATE: %s: long_retries %d\n", __func__, + txs.long_retries); } #endif }