From nobody Mon Sep 30 12:11:54 2024 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XHKgZ6wgWz5YBw4; Mon, 30 Sep 2024 12:11:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XHKgZ6Qxpz4JtS; Mon, 30 Sep 2024 12:11:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727698314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fy2bxPcK4J2XhQ/qLBTF6TjT3DUwBMhHNjWYNzfW6wA=; b=PCXKkPzSLq9/890IEVvKDN08xov6uIZ+8vK0YXEyiaLovUZQN2n5E3b9XXxMliRSKAkRbs lYqGwqfTVNa/OEUSzCffZqsQvzud77ouPHJ9IhShhGWtJH6TeYJCwJxCJKeQr5UkWsv6Gn A4yi8yvDz9n0E1R5aCYAx/eoJ4qrfzBp7mRitW/KBF/W3lLqo9NfRifgS3FKk7EBDz8MpY dGYX43lL9ysOC/suMNZTwhaj+zMHd9QK7/+CQp4LmMe1hgS9AYJPQTLPhI4T/bz5sjKQhN QOECkBDX6vnpsxS3HmgrGBlWsHMYZXIOVs/1zNiY3ew8G33XZbpssLzKQZXGbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727698314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fy2bxPcK4J2XhQ/qLBTF6TjT3DUwBMhHNjWYNzfW6wA=; b=CzChTzXGNcXWhLeWhiyyNWtnNZF4zRMSXy1gJVnSGQ7kj4Qo1HbSbJedicLmpkezp52v3s L0Dtf6XmGJ2x/DDCg63UBows94F4jDjM+F+IMmc59PEEDP2DWUpyKW6cVEl5NpSeeNQClZ ODfwViyDqXsD+nKgW6OxkAk84LhMO7RjOca7V5ZKobhQ94CZHbgh0mTUYOU7hA3tqiTdW2 0hE8JUL3bigaYJzNvUNq+vua+Cu8o/4UfvclHR1iFZ4CMFdS6mI/E5NdgQFJ787IzG/eDI XD+bq+ijjO36Ukv0NpKN4249oGGP8hSGw6vQuJ+n0fgIg26hBEktAicXuAW8+g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1727698314; a=rsa-sha256; cv=none; b=h1ucL67YfZ0xm6N9jgv7ty1NGDCa2G9vnnfV7wsLdZUEgxgoHZ6VdnZdoPnfoX2XyrGHOf 66W8HAuOZuhJeMN+HTL3k9ca4hR+JTG3WYHrjdpCY5G1d3HENXPu1EyusWiWTcOKaYa0Bg jRkrKRzwVJ0qeqxbJCuLTQJSJVA3bOf1lXgN4fMml9yepTyWuJrVZRFJTg8F5dw5r3jFdU WzzVGitMaVDf+xmrotvizUKGQ9fztLk9Gob5+shp4vsszgiZmoS7NDhAi2Dvtu3HwJvNBN uMTbQWnF8IbZMyxfYvvW69e/jzL9g0zNvl88++MBniJw1Hbhjb8ZcNEcOxfBAQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XHKgZ5rxhzssw; Mon, 30 Sep 2024 12:11:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 48UCBsJF053536; Mon, 30 Sep 2024 12:11:54 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 48UCBslq053533; Mon, 30 Sep 2024 12:11:54 GMT (envelope-from git) Date: Mon, 30 Sep 2024 12:11:54 GMT Message-Id: <202409301211.48UCBslq053533@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ed Maste Subject: git: 32e077f273d9 - stable/13 - bhyve: initialize register value List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 32e077f273d90c377faaddc5333758940cc52cef Auto-Submitted: auto-generated The branch stable/13 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=32e077f273d90c377faaddc5333758940cc52cef commit 32e077f273d90c377faaddc5333758940cc52cef Author: Pierre Pronchery AuthorDate: 2024-07-24 19:33:26 +0000 Commit: Ed Maste CommitDate: 2024-09-30 12:11:47 +0000 bhyve: initialize register value In case of an error in a code pattern like ``` uint64_t val; error = memread(vcpu, gpa, &val, 1, arg); error = vie_update_register(vcpu, reg, val, size); ``` uninitialized stack data would be used. Reported by: Synacktiv Reviewed by: markj Security: HYP-21 Sponsored by: The Alpha-Omega Project Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D46107 (cherry picked from commit 94693ec7c85363f9b0098247489cea3efdb183f9) (cherry picked from commit a03acfa43410b3a449fa8d5b1dbba20e0bf02d5a) --- sys/amd64/vmm/vmm_ioport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/amd64/vmm/vmm_ioport.c b/sys/amd64/vmm/vmm_ioport.c index ec270df80c3e..3caea7deac16 100644 --- a/sys/amd64/vmm/vmm_ioport.c +++ b/sys/amd64/vmm/vmm_ioport.c @@ -101,7 +101,7 @@ static int emulate_inout_port(struct vcpu *vcpu, struct vm_exit *vmexit, bool *retu) { ioport_handler_func_t handler; - uint32_t mask, val; + uint32_t mask, val = 0; int error; /*