From nobody Thu Oct 31 01:53:48 2024 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xf6V47359z5Zl3K; Thu, 31 Oct 2024 01:53:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xf6V46P9gz4kPM; Thu, 31 Oct 2024 01:53:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730339628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fLWfth6yiO9vfx07m6yhPRha/NNxQaKfp18G9BnR78I=; b=DAvYiflUr+1jEsHLOggK5FUwPurBixykxLRh9RpYgYPmjhoOjFu1L5LAVbbWT9tChPo3ko K1BCSvBQjVOJtRIQqwmsA12mzayd/iO1fgRhBBHIV1TuPYyeHRVRXu8ullRC3JcWts4TrQ /3EnRj/lQoMB3Nqs7veC60GRNdWW9bmueUsHPWAF5u9/bNM6/WkpncWmCI6B7NbAYT7svl K8LkwddRvXpr9639VYUhpgrgXYPxh5AldQtho3aySrIFcF5q1F6njvj36SC6NKuibEmiOU Hhp3c2MiiMba77n/Odqfyq2fPZHAYQk/5SihPx/fwfxoe5t30RR0G4Tlucrayw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730339628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fLWfth6yiO9vfx07m6yhPRha/NNxQaKfp18G9BnR78I=; b=raQ0Kqu/mDGH8VsHy8wVU0wrf3Us78PJ4b2McRy+9sQQUnYA0wH0wU6ChKeh+UXiTjRVj9 lTYe1+x3xIvRoM1j61+l9uV4TaFOnVZrSp464Oy7rTIF1bPJfdinjnLSIWrHaMNjkt9yk+ 8jPCX7ThDNf9gOeY22vhaVNBt2/og07rB7YR0iFAjIaH4tdr5iSizOiIg8QVS55gnmAawW jM2ExEqlEVgvurtw5rPMMMBzfsADERo994fu9XxK02DUTcVyQOaeb6Y+g5UbHo8w/CJU0/ oP1gwajtZ83px0yP6sgEjQYTlQPTLFHjEkK7DIrTNzw5l2wzovxTjJr8qL2Dgw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730339628; a=rsa-sha256; cv=none; b=bt5l7ZAqK0j59+PbJqKMl3c1KilthocEYlKXA3jUBlQtymTiA3ZBG32hir+9quH6wlg7E4 Z98tcO9rN8YHFMm1Wut9OYaiR1Bd5hKTzyF7nmnM5clfc8Qq+MFAp53qlPVw5gtdwe8kDl gCtgZs1Rj0tlqNuvJw/1eRhmBUVowKUrClsuXAnfcH6YD1zIUp7O+RimBbG7pLkGms+EKW XdlJqEq3oa3MZ3TJo4R5zQ5HtIHIDtQE/sEUjn/2IDxuq+GUWlUmXgpmJHjZKw0eigVRse es6aF69R4t06dbOJijw9aHKRxG2FU2lHfTZ94QMsDv+ddGC1kMqjz8UsHjoG+A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Xf6V460KnzH1F; Thu, 31 Oct 2024 01:53:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 49V1rmQ5088568; Thu, 31 Oct 2024 01:53:48 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 49V1rmDs088565; Thu, 31 Oct 2024 01:53:48 GMT (envelope-from git) Date: Thu, 31 Oct 2024 01:53:48 GMT Message-Id: <202410310153.49V1rmDs088565@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Navdeep Parhar Subject: git: 843c1b516019 - stable/14 - cxgb(4): Register ifmedia callbacks before ether_ifattach. List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 843c1b516019efec22295234bdda26b838b1e6b7 Auto-Submitted: auto-generated The branch stable/14 has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=843c1b516019efec22295234bdda26b838b1e6b7 commit 843c1b516019efec22295234bdda26b838b1e6b7 Author: ScottD AuthorDate: 2024-10-28 20:48:16 +0000 Commit: Navdeep Parhar CommitDate: 2024-10-31 01:09:06 +0000 cxgb(4): Register ifmedia callbacks before ether_ifattach. This prevents a panic that occurs if netlink tries to invoke the driver's media callbacks during ifattach. PR: 282374 Reported by: ScottD (cherry picked from commit f2daf89954a45c7eed22990dd4cf2cf879763dc0) --- sys/dev/cxgb/cxgb_main.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sys/dev/cxgb/cxgb_main.c b/sys/dev/cxgb/cxgb_main.c index 4d754aa8b1b7..c159849076c5 100644 --- a/sys/dev/cxgb/cxgb_main.c +++ b/sys/dev/cxgb/cxgb_main.c @@ -1041,6 +1041,11 @@ cxgb_port_attach(device_t dev) if_sethwassistbits(ifp, 0, CSUM_TSO); } + /* Create a list of media supported by this port */ + ifmedia_init(&p->media, IFM_IMASK, cxgb_media_change, + cxgb_media_status); + cxgb_build_medialist(p); + ether_ifattach(ifp, p->hw_addr); /* Attach driver debugnet methods. */ @@ -1055,11 +1060,6 @@ cxgb_port_attach(device_t dev) return (err); } - /* Create a list of media supported by this port */ - ifmedia_init(&p->media, IFM_IMASK, cxgb_media_change, - cxgb_media_status); - cxgb_build_medialist(p); - t3_sge_init_port(p); return (err);