From nobody Thu Oct 10 19:11:25 2024 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XPfW215Zxz5YTdJ; Thu, 10 Oct 2024 19:11:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XPfW20ZVSz4DCq; Thu, 10 Oct 2024 19:11:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1728587486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Oa+ym3VWHtd3F/AXXJZiBa8UKVeE3rELksiNGUKiBYQ=; b=wVm7l5rHSorvbroRcqmGr+MM9XCcK8achjX2KcGGAGyuh6lFa+yPrL/cHEVFlzYUuVanNP dU/fxu3VrdtBmArIOypRtk9cfcS+Nq7FAdjtw18Ay50HaDXl05e3BdEtYtRE+x/qKP9PsN 67pK/5zZ/u92aaFkGIjFzZCc7C3nRsRol5/KdSCDK9ZfgkQCKjf41oz/UfJXTwalEXsZE+ ehhNqZ4PyqcIrXmJT41d9IVtHeeGgr+8T8b9CZ6bajGxqZBwOL5PVtB0oJ7DR0KA2td2NT lAFZdI9AGxlmwnYoaHWNqjk0w1InI5ldWSn5jhuzAP8jLFe+ucvj7q06FtXy3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1728587486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Oa+ym3VWHtd3F/AXXJZiBa8UKVeE3rELksiNGUKiBYQ=; b=mLdBHfK3n0aMmJSERuMX/Eyc81ijnZiTtWN7xMV80nnNU+3hEAuBW9BMtd7FLkb9s7JEEn pB6FV3VjpobSRBlePptJftQMY/yIyYQ+8BQ5UwCANUG5ABkWWJCyMKcf3kfdYD3MoRu6Nm 4nw5J/Fn7bNqdticyDZHyNiWEXLa08mEvFSfsFwiJ9hp10Z0G8AjOJf4fjovkgGueP3me6 zzHO5q5nbTArvOjpB80GAY0l1GWfwt1CwNxUs5PvxpuM0njefBcwf1IeSQ/TfAD/zLJ1ku 2hLnUl7yUzTkfi855QspZwHAyZa2RDOLsO7qf6ZJW7TTDD79GfsRvQjW72+KPA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1728587486; a=rsa-sha256; cv=none; b=qYwbOyKDicwIQcqKeYn+dYrrorIkDxAqJNuXWeP1vx+vb6gmS+tjztROblXd0v8LJGMVXg iL8mbsPT6gRvZW4/t2PttFV/IY117CqM7YVzdcaJiINZvJGmPW2gbeepeQdoZTIW7lLO+S iXGyPKhwygSm5RA7AMkDPK0Ndu6qfqRHg0TafSzYC4yNBtniymXZp2NuvoRENXhHeuOHlG Ug7yRK33fZprnnpT5p5qWFElcwsnh3O4t8l8p4eOeTzP9g6ak1FZYehPpAIHv5rNK4HwQU J6QBYzfUmk7ITABUufw8qa5zEuMcB2fA5a5SyzUd7Z++81kiX5Bm8y4f3iYMXQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XPfW202GVz19QG; Thu, 10 Oct 2024 19:11:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 49AJBPqH084711; Thu, 10 Oct 2024 19:11:25 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 49AJBPmt084708; Thu, 10 Oct 2024 19:11:25 GMT (envelope-from git) Date: Thu, 10 Oct 2024 19:11:25 GMT Message-Id: <202410101911.49AJBPmt084708@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Alan Somers Subject: git: 4421ce1328df - stable/14 - nfscl: fix uninitialized memory in nfsv4_loadattr List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: asomers X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 4421ce1328dff275ae522222010b6b3b791730e7 Auto-Submitted: auto-generated The branch stable/14 has been updated by asomers: URL: https://cgit.FreeBSD.org/src/commit/?id=4421ce1328dff275ae522222010b6b3b791730e7 commit 4421ce1328dff275ae522222010b6b3b791730e7 Author: Alan Somers AuthorDate: 2024-09-08 20:42:38 +0000 Commit: Alan Somers CommitDate: 2024-10-10 19:08:12 +0000 nfscl: fix uninitialized memory in nfsv4_loadattr When processing an RPC response that did not include any Owner attribute, nfsv4_loadattr would return na_uid and na_gid uninitialized. The uninitialized values could then make their way into the NFS attribute cache via nfscl_loadattrcache. PR: 281279 Reported by: KMSAN Reviewed by: rmacklem Sponsored by: Axcient (cherry picked from commit 44328abfb7aca8150b07b83ff502c9185677e3fb) --- sys/fs/nfs/nfs_commonsubs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/fs/nfs/nfs_commonsubs.c b/sys/fs/nfs/nfs_commonsubs.c index f2305795e53e..9f0e98bc93ce 100644 --- a/sys/fs/nfs/nfs_commonsubs.c +++ b/sys/fs/nfs/nfs_commonsubs.c @@ -1320,6 +1320,7 @@ nfsv4_loadattr(struct nfsrv_descript *nd, vnode_t vp, * Just set default values to some of the important ones. */ if (nap != NULL) { + VATTR_NULL(&nap->na_vattr); nap->na_type = VREG; nap->na_mode = 0; nap->na_rdev = (NFSDEV_T)0;