git: aeba4bd10f08 - releng/14.2 - acpi_gpiobus: Narrow scope of NOT_YET
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sun, 03 Nov 2024 16:16:54 UTC
The branch releng/14.2 has been updated by cperciva:
URL: https://cgit.FreeBSD.org/src/commit/?id=aeba4bd10f08559c599b08e4c2e9ef899e758740
commit aeba4bd10f08559c599b08e4c2e9ef899e758740
Author: Colin Percival <cperciva@FreeBSD.org>
AuthorDate: 2024-10-22 18:25:11 +0000
Commit: Colin Percival <cperciva@FreeBSD.org>
CommitDate: 2024-11-03 16:15:30 +0000
acpi_gpiobus: Narrow scope of NOT_YET
GPIO interrupts work just fine and will be used shortly. We still
do not support GPIO_INTR_SHAREABLE however, so leave that within
the NOT_YET scope.
Reviwed by: andrew
Approved by: re (kib)
MFC after: 1 week
Sponsored by: Amazon
Differential Revision: https://reviews.freebsd.org/D47251
(cherry picked from commit 2d4219919a48aa6d67ae62e2b8859ffe3b035bd2)
(cherry picked from commit 1f6941760746367704c9f1fa730a00b99d4d46b2)
---
sys/dev/gpio/acpi_gpiobus.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sys/dev/gpio/acpi_gpiobus.c b/sys/dev/gpio/acpi_gpiobus.c
index 3b6fc6dde674..9828170daeca 100644
--- a/sys/dev/gpio/acpi_gpiobus.c
+++ b/sys/dev/gpio/acpi_gpiobus.c
@@ -52,8 +52,6 @@ acpi_gpiobus_convflags(ACPI_RESOURCE_GPIO *gpio_res)
uint32_t flags = 0;
/* Figure out pin flags */
-#ifdef NOT_YET
- /* These are currently unused. */
if (gpio_res->ConnectionType == ACPI_RESOURCE_GPIO_TYPE_INT) {
switch (gpio_res->Polarity) {
case ACPI_ACTIVE_HIGH:
@@ -69,10 +67,12 @@ acpi_gpiobus_convflags(ACPI_RESOURCE_GPIO *gpio_res)
break;
}
+#ifdef NOT_YET
+ /* This is not currently implemented. */
if (gpio_res->Shareable == ACPI_SHARED)
flags |= GPIO_INTR_SHAREABLE;
- }
#endif
+ }
switch (gpio_res->IoRestriction) {
case ACPI_IO_RESTRICT_INPUT:
flags |= GPIO_PIN_INPUT;