From nobody Sat Nov 02 14:29:53 2024 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xgg9Z1hvWz5c6xM; Sat, 02 Nov 2024 14:29:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xgg9Y64VZz44s1; Sat, 2 Nov 2024 14:29:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730557793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qmWqZxnYdzg9+PukNdciyRK5aIxeG2lsNfC/qx8eSg0=; b=Bnth98W+aUGOLSKP9rpKRuRwarpPRg3d8UIhNpQ7bgwNTm5keoTmJjxpAsphX//MBiPjJz Y9hCAtWg/8m5Jr6zaYCgEbsmV60ylKpCLg+cFOJBNi7n6uq5AmVFIp6sCtkEDkkOejaL+t 0GNsEfTg9+ufNPW6euwYbgAoy/oBR9d1Ix/qoo6ks84TBih0xVFuoBmEl7KbygRKimrUg1 sIfwGsjIlQVGaydXpHPzVxTXMbwpANAgW/PDEUc0Kj/spL4rYNTo34/oHEDGuff01nTNVD cEKtgREgrHuTG0YEugqs3execexY3TLl5gQ5OdqSgK1Hz2gTWDlmsoUUVdYDlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730557793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qmWqZxnYdzg9+PukNdciyRK5aIxeG2lsNfC/qx8eSg0=; b=oyWENukfDRXuoZh4e8gnrV4MOdYkYGjvsZLyIexb2ysYB4hpRtFv5/ZgOir7hqK4SAfWVy OyWvBAAvrsiD4+cxVibBJkuKCHY3bgKeT1uH+fUVZS0e9G7Vvrz3aZGrK41BsPJ1CaN+oK 93DmYPaHlE4ao4/5oZVNiouje4xX/S2QWdeEMUGcfHeTVDvU7PHbDA3V3tAX5Ivv0bkHSK afiLprm8if5RBD1Oqwe6bbsYI3PV4nqZ7qneFhSWzHfyOMpmxdLOZNH22jALHny5V0w7+m URdtBXUgvCYKKA+a2o/ajp0NcOGYTPbwHC3tYCortEG3fwiLImyGLsfoJtK4Nw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730557793; a=rsa-sha256; cv=none; b=ug99EY2ANn9DZzDiB04PxW89jAxcBOQ0T87Jx9HsViVPVHK5XYZPJNOerlLnTQ6QUx+NWu Gz3PZOkAsQbAAXymI+wrzGxUg1MqOsjKIdnt6zkQA3kadTEgZAxxqd2Zvoj0gLv1qDoSJf 8SsHsl471eimxMPyDVBpmcdT5ThOjgiJKtPzZV1ko+JyB4JXk3Ua9pcd0fAUsfC8pXVUmy wiGqR6j6vxd/Yfsf7fR4/HBq0vkSSCQrr5S2mnDPwZXxB9G1/PO5fOuf570KkNR/QBKWb0 1DMMDYlFIKtFXWcCRUION7zTpCpO3c7EIyei2681sNP1FCGAEXk+Eyrbsxr5uA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Xgg9Y47Lrz17FF; Sat, 2 Nov 2024 14:29:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4A2ETrYq057999; Sat, 2 Nov 2024 14:29:53 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4A2ETrwA057996; Sat, 2 Nov 2024 14:29:53 GMT (envelope-from git) Date: Sat, 2 Nov 2024 14:29:53 GMT Message-Id: <202411021429.4A2ETrwA057996@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 57d879534096 - stable/13 - igc: Remove a bogus register write in igc_if_queues_free() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 57d879534096d8b49d0e6ba72dae1783e9a1cccc Auto-Submitted: auto-generated The branch stable/13 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=57d879534096d8b49d0e6ba72dae1783e9a1cccc commit 57d879534096d8b49d0e6ba72dae1783e9a1cccc Author: Mark Johnston AuthorDate: 2024-10-26 21:04:59 +0000 Commit: Mark Johnston CommitDate: 2024-11-02 14:29:46 +0000 igc: Remove a bogus register write in igc_if_queues_free() As explained in PR 277038, iflib calls IFDI_DETACH() and then IFDI_QUEUES_FREE(). With igc, the latter writes to a register after it has been unmapped. igc_if_detach() already calls igc_release_hw_control(), and looking at callers of igc_if_queues_free(), that appears to be sufficient. So, just remove the igc_release_hw_control() call. PR: 277038 Reported by: Mike Belanger Reviewed by: kbowling Tested by: kbowling MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D47293 (cherry picked from commit 35d05a14ed7e9935be1ed0fe965b91aaaa4c92ef) --- sys/dev/igc/if_igc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/dev/igc/if_igc.c b/sys/dev/igc/if_igc.c index 1daec6e09694..5851b715b932 100644 --- a/sys/dev/igc/if_igc.c +++ b/sys/dev/igc/if_igc.c @@ -2051,8 +2051,6 @@ igc_if_queues_free(if_ctx_t ctx) sc->rx_queues = NULL; } - igc_release_hw_control(sc); - if (sc->mta != NULL) { free(sc->mta, M_DEVBUF); }