From nobody Sat Nov 02 14:29:38 2024 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xgg9G3XFkz5c6fl; Sat, 02 Nov 2024 14:29:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xgg9G2sltz44fC; Sat, 2 Nov 2024 14:29:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730557778; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=q4NJoZ0LCpXY26ZL6Sb92p8NztfWdEm5VqmRTD6ZBFE=; b=jTW79eQ6Nal8bUXEcKz/POpJaFYWa5TVe7lqj70NpISjaM1NNoC5/4cduw7akgL1gZTSUY Vh+1i8iHCchwPW2OzrXlNaHDMQjXknGaitnXqhBSmigb7EHtuEQ/k0tRsAGiEI4cyzDLsF fIQLJROovio6ERv9ycBcYdu7kVufRIMqMWL9s0g/SeGNNq/mHwYoWtl6LXKDCUKxZlhy5N SS5WEzOQI00otlsnOwLjQGDu2VBVcPTL936hVDxJPT2VHPGntQO/GtgL6OTpZBVCybXBZ6 wLXbQE8rGe2AX5vYkPdQKw2dB9UuR01uP78ZEwM2yL2/p5DKZCD4waL8MTsbpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730557778; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=q4NJoZ0LCpXY26ZL6Sb92p8NztfWdEm5VqmRTD6ZBFE=; b=bUg7UaUUaY4GesORctIhAxHotBgZfosWVB3cHmLw4fuGomp4PuQak4G99U6VggGGfYKhyI +hzn13Q92Ln/W2O1w36JC1t/+KE+9MxwE07uPOy4siE0SD3Ma+Dh1rBDmcoYm24UyAatX2 Ph8xveDcoMJI6lusHiIhCQf1loYjFLx3vPitOkeRp+9wTi27rdGK9POOwFKIkhSdVX1ukb iPQVyhOnsez++yTkzm9W23Tap8IC5oXnHUs2icaLHEWbQoT4/pEEhai0QMXTidqW9VU1tL H8WYjapRpsBYjNq43CYjoZg1QMLL8LBCvO49cfMn84tc/MdamCfd6Ji81q8bQg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730557778; a=rsa-sha256; cv=none; b=WNesacJm89csrYu+73msQUmanHSDejFveisT5lpVSfoWRrAp0lVYTNhs+VTLmLxzT3vIu7 24pshLjENAnmEXnJtc4c5QIieDAfTvWVWXevRwhTQOMYg003tbRmuaECIMrxpj43rVW7B2 NBs7htYCk7CBv76vc56RttiJJ1Anj9vAXcHPt9OSDez3Ju14cl5KG0QJmkTDY5CdPVkTTT gk7bVOLTNK0uNqV8qDykerJvISW61dLcYSQVw/z4lpnD8fkgQFBoznVRvbu5420xHHExGv vCZxwZ415NlcKUaNpzMnWUOBD/N8s7GBWxQ2i0jf1iUNHyT7qP1lio5l40kHzQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Xgg9G2C2Nz17FB; Sat, 2 Nov 2024 14:29:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4A2ETcSr057787; Sat, 2 Nov 2024 14:29:38 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4A2ETc4Z057784; Sat, 2 Nov 2024 14:29:38 GMT (envelope-from git) Date: Sat, 2 Nov 2024 14:29:38 GMT Message-Id: <202411021429.4A2ETc4Z057784@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 16b24ba87227 - stable/14 - igc: Remove a bogus register write in igc_if_queues_free() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 16b24ba8722735ee2657f07e32e5a5bf7ee62a2e Auto-Submitted: auto-generated The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=16b24ba8722735ee2657f07e32e5a5bf7ee62a2e commit 16b24ba8722735ee2657f07e32e5a5bf7ee62a2e Author: Mark Johnston AuthorDate: 2024-10-26 21:04:59 +0000 Commit: Mark Johnston CommitDate: 2024-11-02 14:29:26 +0000 igc: Remove a bogus register write in igc_if_queues_free() As explained in PR 277038, iflib calls IFDI_DETACH() and then IFDI_QUEUES_FREE(). With igc, the latter writes to a register after it has been unmapped. igc_if_detach() already calls igc_release_hw_control(), and looking at callers of igc_if_queues_free(), that appears to be sufficient. So, just remove the igc_release_hw_control() call. PR: 277038 Reported by: Mike Belanger Reviewed by: kbowling Tested by: kbowling MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D47293 (cherry picked from commit 35d05a14ed7e9935be1ed0fe965b91aaaa4c92ef) --- sys/dev/igc/if_igc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/dev/igc/if_igc.c b/sys/dev/igc/if_igc.c index dd89b27e134c..38fb1406b1c1 100644 --- a/sys/dev/igc/if_igc.c +++ b/sys/dev/igc/if_igc.c @@ -2050,8 +2050,6 @@ igc_if_queues_free(if_ctx_t ctx) sc->rx_queues = NULL; } - igc_release_hw_control(sc); - if (sc->mta != NULL) { free(sc->mta, M_DEVBUF); }