From nobody Mon Mar 11 00:30:31 2024 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TtHk01673z5DDRN; Mon, 11 Mar 2024 00:30:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TtHjz64C6z4v6c; Mon, 11 Mar 2024 00:30:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1710117031; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cpK5VRyLcv4TXf3dSESbY+QATTRnsynY0Y4YZyPlzFA=; b=kboUIno/Avt7dEmxTywaK7YMJKp0e43zm68cPO2XRg8qMPMHnxohJF0gEoT3WKkf6CV8/v A8i54rXsq3f/FXE9FLjf8rDrU/B9X4TF1FsxHuU5ukwX8l90gs9gBtGZI+B0rbqMjnhp3y QWnMDt2seVXd11aPrFGxEuXKHJyWW1lyi6yJ8jPNKl0VarZX5afxzWkwMmP5wiqD/ZgLy/ fCY8eqmDifRdhQVl6AhbbyRNp450o4PpXRGgYiRGM6TVNk/+5Btj+ZAVnHVqaz7SRlK5fF ynpsmpD3ZtJONmIQLxwP1YcsbV0XktjGkKx9FZiKClpEOSu5Qc1QCbpnSIHAyA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1710117031; a=rsa-sha256; cv=none; b=Xf0WY80C6tfzoFBwcE01KuRakVoDvSsadFIQkGj1AQ0xhxS26ReaXHkzoNZCkF3Dkjsl2x bopQAekuGaK2CxbOduQTKaK8AjcA/+85iY52tVzL8zDl/EGIaYQhE3KwtgXYRmDBBur9b7 lkgX3akCQRspiOhOsVRWU3Leeksf6RCmFTxn0aNjV6x0dbTWuIGovZ4d/DpOUuDYspX2lX UlS99WvElysR9RRqo3pallHTmASHoEz1Ba/MGRFNUz/RKAPCiiDhBCqrs3hNHaN7aWfute Pywf0pNfsuvCf2+V29OYyWa4N0W7M0GVlq47nNCG6cqVC5Gltupiou1OIf/VVQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1710117031; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cpK5VRyLcv4TXf3dSESbY+QATTRnsynY0Y4YZyPlzFA=; b=pYZBoTn5vfvV3bcwlmbxvLXbhx67blzaksNPfMQGAqfI9dqLEUwSP774INmwTvzDzV0HMj sYTG/5KPyXzSJbT/sfBCCQI7+fyazKbnNqANyJdtSbQhDwJyaVpBBwD+L7bYlnHoz9MYap VXKsiKwOwa4elN3/cK4gunCBo065gsj068glWujv6DSgBVFumCMAz8FjBfvpDTixJJq5iU zfytQpVpwqPqN8HZsDASPu9Odsybhu7Bf/GftyE22Dpgn4IrxShjm1OusEBZtahRQwzX1z T2a8HkD3qbpHtbApe4k43rikE4ekOq/Lc7OvufhJTHUYiCGSlOewln4CwV+aCQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TtHjz5NK7z17Lc; Mon, 11 Mar 2024 00:30:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 42B0UVd5002991; Mon, 11 Mar 2024 00:30:31 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 42B0UVJk002988; Mon, 11 Mar 2024 00:30:31 GMT (envelope-from git) Date: Mon, 11 Mar 2024 00:30:31 GMT Message-Id: <202403110030.42B0UVJk002988@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Konstantin Belousov Subject: git: 2c34a6f77008 - stable/13 - posix_spawnattr_setflags(3): validate argument List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 2c34a6f77008780307df85d9387adf37bf74026f Auto-Submitted: auto-generated The branch stable/13 has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=2c34a6f77008780307df85d9387adf37bf74026f commit 2c34a6f77008780307df85d9387adf37bf74026f Author: Konstantin Belousov AuthorDate: 2024-03-03 13:19:37 +0000 Commit: Konstantin Belousov CommitDate: 2024-03-11 00:29:51 +0000 posix_spawnattr_setflags(3): validate argument (cherry picked from commit 80ac36c3a2a87a19790eba487466bf70d55f566e) --- lib/libc/gen/posix_spawn.c | 4 ++++ lib/libc/gen/posix_spawnattr_getflags.3 | 7 +++++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/lib/libc/gen/posix_spawn.c b/lib/libc/gen/posix_spawn.c index 77f7dd9955cd..49a63bb40501 100644 --- a/lib/libc/gen/posix_spawn.c +++ b/lib/libc/gen/posix_spawn.c @@ -630,6 +630,10 @@ posix_spawnattr_getsigmask(const posix_spawnattr_t * __restrict sa, int posix_spawnattr_setflags(posix_spawnattr_t *sa, short flags) { + if ((flags & ~(POSIX_SPAWN_RESETIDS | POSIX_SPAWN_SETPGROUP | + POSIX_SPAWN_SETSCHEDPARAM | POSIX_SPAWN_SETSCHEDULER | + POSIX_SPAWN_SETSIGDEF | POSIX_SPAWN_SETSIGMASK)) != 0) + return (EINVAL); (*sa)->sa_flags = flags; return (0); } diff --git a/lib/libc/gen/posix_spawnattr_getflags.3 b/lib/libc/gen/posix_spawnattr_getflags.3 index 9a468cbb8b0f..18cf6683e935 100644 --- a/lib/libc/gen/posix_spawnattr_getflags.3 +++ b/lib/libc/gen/posix_spawnattr_getflags.3 @@ -83,9 +83,12 @@ The default value of this attribute is as if no flags were set. .Sh RETURN VALUES The .Fn posix_spawnattr_getflags -and +function returns zero. +The .Fn posix_spawnattr_setflags -functions return zero. +function returns zero on success, and +.Er EINVAL +on failure due to invalid flag specified. .Sh SEE ALSO .Xr posix_spawn 3 , .Xr posix_spawnattr_destroy 3 ,