git: 144e7a72f476 - stable/14 - gtaskqueue: Fix a typo
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sun, 07 Jan 2024 16:58:11 UTC
The branch stable/14 has been updated by markj:
URL: https://cgit.FreeBSD.org/src/commit/?id=144e7a72f476f8f8453c40532c6f95c1f9add7ae
commit 144e7a72f476f8f8453c40532c6f95c1f9add7ae
Author: Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2023-12-31 16:36:12 +0000
Commit: Mark Johnston <markj@FreeBSD.org>
CommitDate: 2024-01-07 16:56:04 +0000
gtaskqueue: Fix a typo
This is a no-op in practice since gtaskqueue_thread_enqueue() and
taskqueue_thread_enqueue() are identical, and while _gtaskqueue_create()
compares the enqueue callback pointer with gtaskqueue_thread_enqueue(),
the result has no effect since TQ_FLAGS_UNLOCKED_ENQUEUE was copied
directly from subr_taskqueue.c and is unused in the gtaskqueue code.
Fix it anyway since it's a bug. More generally we really need to
consolidate subr_taskqueue.c and subr_gtaskqueue.c.
PR: 270661
MFC after: 1 week
(cherry picked from commit e1f336704d308679d4178fd5063dba854b22a07b)
---
sys/kern/subr_gtaskqueue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sys/kern/subr_gtaskqueue.c b/sys/kern/subr_gtaskqueue.c
index 3558b534967d..590dd53d0ea3 100644
--- a/sys/kern/subr_gtaskqueue.c
+++ b/sys/kern/subr_gtaskqueue.c
@@ -614,7 +614,7 @@ taskqgroup_cpu_create(struct taskqgroup *qgroup, int idx, int cpu)
qcpu = &qgroup->tqg_queue[idx];
LIST_INIT(&qcpu->tgc_tasks);
qcpu->tgc_taskq = gtaskqueue_create_fast(NULL, M_WAITOK,
- taskqueue_thread_enqueue, &qcpu->tgc_taskq);
+ gtaskqueue_thread_enqueue, &qcpu->tgc_taskq);
gtaskqueue_start_threads(&qcpu->tgc_taskq, 1, PI_SOFT,
"%s_%d", qgroup->tqg_name, idx);
qcpu->tgc_cpu = cpu;